tine20
5 years agoupgrade vagrant box to saucy 64 bit with php5.5
Michael Spahn [Fri, 2 Jan 2015 14:55:12 +0000 (15:55 +0100)]
upgrade vagrant box to saucy 64 bit with php5.5

cherry-picked from master and originally committed by c.weiss@metaways.de

Change-Id: Id99cc0b5540f4d9d545afab61d9f863103fe17f0
Reviewed-on: http://gerrit.tine20.com/customers/1532
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Tue, 20 Jan 2015 15:02:07 +0000 (16:02 +0100)]
Merge branch '2013.10' into 2014.11

Conflicts:
tine20/Felamimail/Frontend/ActiveSync.php

Change-Id: I327dee422c5248195af380ac9130091c16daf094

5 years agofixes Timetracker edit dialogs with disabled Sales Invoices module
Philipp Schüle [Tue, 20 Jan 2015 14:31:16 +0000 (15:31 +0100)]
fixes Timetracker edit dialogs with disabled Sales Invoices module

TODO: implement feature switch

Change-Id: I5877fb220d0ec53c79a1c8140bab93b6f3451f74
Reviewed-on: http://gerrit.tine20.com/customers/1537
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agofix billing and delivery address translations
sstamer [Thu, 15 Jan 2015 12:58:38 +0000 (13:58 +0100)]
fix billing and delivery address translations

TODO: this should use the singular/plural translations

Change-Id: Id6ce73c9c4d1e58fc3192ed93d0a3fb200f12333
Reviewed-on: http://gerrit.tine20.com/customers/1533
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoset correct AS foldertype for drafts folder
Lars Kneschke [Sun, 18 Jan 2015 15:35:07 +0000 (16:35 +0100)]
set correct AS foldertype for drafts folder

https://forge.tine20.org/view.php?id=10520

Change-Id: Ie0dd527983cfa8076280ea860ab0289b74a96212
Reviewed-on: http://gerrit.tine20.com/customers/1538
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agosend all folders to client
Lars Kneschke [Sun, 18 Jan 2015 19:33:27 +0000 (20:33 +0100)]
send all folders to client

- most unselectable folders have subfolders

Change-Id: If7fea99aef3cb8bb98aae0e2c6fda290e318498d
Reviewed-on: http://gerrit.tine20.com/customers/1539
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoscroll position in crop mode
sstamer [Fri, 9 Jan 2015 10:59:12 +0000 (11:59 +0100)]
scroll position in crop mode

* fix initial layouting:
  scroller needs to be sized to apply scolling
  otherwise mainBody is not bigger than scroller
  and scrolling is not nessesary when initializing

Change-Id: Id580b2cdf46ec93b23d7b6f7ee50a97c5612b230
Reviewed-on: http://gerrit.tine20.com/customers/1524
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoFix 24:00 again
sstamer [Fri, 9 Jan 2015 12:33:10 +0000 (13:33 +0100)]
Fix 24:00 again

Change-Id: I0d6b65f91be9ec1b465f45ff4f02b01fe50fabb0
Reviewed-on: http://gerrit.tine20.com/customers/1519
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agomissing colon
Cornelius Weiß [Wed, 14 Jan 2015 10:53:17 +0000 (11:53 +0100)]
missing colon

Change-Id: I6fc9c72a9616970e3c35edc59c31d5a2fd0a674c
Reviewed-on: http://gerrit.tine20.com/customers/1528
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodisable community sales features
Lars Kneschke [Wed, 14 Jan 2015 07:47:01 +0000 (08:47 +0100)]
disable community sales features

Change-Id: I463b9fc045b66e37a3b385730cdc870df444090e
Reviewed-on: http://gerrit.tine20.com/customers/1526
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years ago0010720: allow to filter for foreign records with "not" operator
Philipp Schüle [Fri, 9 Jan 2015 13:45:41 +0000 (14:45 +0100)]
0010720: allow to filter for foreign records with "not" operator

* adds a test

https://forge.tine20.org/view.php?id=10720

Change-Id: Iec82053a82b98ddaf9e60fc8ffacc149016b7937
Reviewed-on: http://gerrit.tine20.com/customers/1521
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoavoid reading preferences on every request
Lars Kneschke [Sun, 11 Jan 2015 14:21:50 +0000 (15:21 +0100)]
avoid reading preferences on every request

Change-Id: I2bd5e1f106d907c22ef9e731d83149f406d7322d
Reviewed-on: http://gerrit.tine20.com/customers/1522
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoenable 'not'-operator for foreign record filter
Lars Kneschke [Fri, 9 Jan 2015 12:27:41 +0000 (13:27 +0100)]
enable 'not'-operator for foreign record filter

Change-Id: Ia98e143eb30ec337377c8bcebba1d4f0f7f10c0f
Reviewed-on: http://gerrit.tine20.com/customers/1520
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoenable 'not'-operator for id filter
Lars Kneschke [Fri, 9 Jan 2015 12:25:11 +0000 (13:25 +0100)]
enable 'not'-operator for id filter

Change-Id: I258552fbc18810c6f9d1fce698d06135c6b34699
Reviewed-on: http://gerrit.tine20.com/customers/1518
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Thu, 8 Jan 2015 13:09:58 +0000 (14:09 +0100)]
Merge branch '2013.10' into 2014.11

5 years agoFix Printproblem with offset 0
sstamer [Tue, 6 Jan 2015 08:51:38 +0000 (09:51 +0100)]
Fix Printproblem with offset 0

- 24:00

Change-Id: I72ce7bb393b9920309f62807bda9304b99ea8e54
Reviewed-on: http://gerrit.tine20.com/customers/1510
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0010710: Shorten Usernames
sstamer [Wed, 7 Jan 2015 13:28:23 +0000 (14:28 +0100)]
0010710: Shorten Usernames

https://forge.tine20.org/view.php?id=10710

Change-Id: I7012154dea1b469bef78838c5aa6b442af48d1a2
Reviewed-on: http://gerrit.tine20.com/customers/1512
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimproves user contact addressbook handling
Philipp Schüle [Wed, 7 Jan 2015 16:42:03 +0000 (17:42 +0100)]
improves user contact addressbook handling

* set DEFAULTINTERNALADDRESSBOOK config on the fly
* don't update content sequence if empty

Change-Id: I74a6d7a7e5b7a39e918d167c8468422174605fcd
Reviewed-on: http://gerrit.tine20.com/customers/1514
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodo not overwrite modlog properties with empty values
Philipp Schüle [Wed, 7 Jan 2015 16:38:01 +0000 (17:38 +0100)]
do not overwrite modlog properties with empty values

... because sometimes (for example during user sync from LDAP) we do not
fetch the current values before updating the user

Change-Id: Id8753e2b1e9e84e67ce4ef66efe3c709816437d6
Reviewed-on: http://gerrit.tine20.com/customers/1513
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Wed, 7 Jan 2015 16:48:58 +0000 (17:48 +0100)]
Merge branch '2013.10' into 2014.11

Conflicts:
tine20/Tinebase/Group/Sql.php

Change-Id: I42c8f9924e73ae522c9a8a7e452d75f79debf46f

5 years ago0010616: Tld with more than 4 letter in Webmail as receipt address
Philipp Schüle [Tue, 6 Jan 2015 10:11:43 +0000 (11:11 +0100)]
0010616: Tld with more than 4 letter in Webmail as receipt address

* increases allowed tld length to 63

https://forge.tine20.org/view.php?id=10616

Change-Id: I9c848c550053a546b0fa1016802339fe98724a6c
Reviewed-on: http://gerrit.tine20.com/customers/1505
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadded in class cache to Tinebase_Group_Abstract/Sql
Lars Kneschke [Sat, 20 Dec 2014 22:11:52 +0000 (23:11 +0100)]
added in class cache to Tinebase_Group_Abstract/Sql

Change-Id: I641a22c1db8ac4970e021a6ec29533d9a2894060
Reviewed-on: http://gerrit.tine20.com/customers/1478
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Tue, 6 Jan 2015 11:27:11 +0000 (12:27 +0100)]
Merge branch '2013.10' into 2014.11

5 years agoreplaces deprecated /e modifier in preg_replace
Philipp Schüle [Mon, 5 Jan 2015 15:04:16 +0000 (16:04 +0100)]
replaces deprecated /e modifier in preg_replace

... by using preg_replace_callback

Change-Id: Icac5749b5b2cf7e884900176809c7b782c3dc4fc
Reviewed-on: http://gerrit.tine20.com/customers/1503
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0010630: LDAP user sync needs to set creation and lasr modified time
Philipp Schüle [Mon, 5 Jan 2015 10:58:15 +0000 (11:58 +0100)]
0010630: LDAP user sync needs to set creation and lasr modified time

* takes care of user and group modlog

https://forge.tine20.org/view.php?id=10630

Change-Id: Id0836ed090434d77fdada97aa750066b9f5f90fd
Reviewed-on: http://gerrit.tine20.com/customers/1502
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Fri, 2 Jan 2015 17:25:16 +0000 (18:25 +0100)]
Merge branch '2013.10' into 2014.11

5 years ago0010622: user contact email is not updated during LDAP sync
Philipp Schüle [Fri, 2 Jan 2015 12:57:12 +0000 (13:57 +0100)]
0010622: user contact email is not updated during LDAP sync

* includes email, name and other data from user object in LDAP contact
sync
* adds some logging
* only update contact if diff is not empty

https://forge.tine20.org/view.php?id=10622

Change-Id: I2168197676cfdd2a5c68359bf23b9781691e885a
Reviewed-on: http://gerrit.tine20.com/customers/1498
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0010347: fix failing tests in Sales_JsonTest (user is not resolved)
Philipp Schüle [Fri, 28 Nov 2014 15:32:01 +0000 (16:32 +0100)]
0010347: fix failing tests in Sales_JsonTest (user is not resolved)

* improves foreign record resolving (user resolving should not depend on
Addressbook)
* improves logging
* renames a function
* reactivated tests
* extend abstract TestCase
* fixes teardown in roles test (enable app again)

https://forge.tine20.org/view.php?id=10347

Change-Id: Id8638bdc518d35b7c7ff14a421edf7efbb6d79e2
Reviewed-on: http://gerrit.tine20.com/customers/1399
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadd option to split ldap username during login
Flávio Gomes da Silva Lisboa [Tue, 30 Dec 2014 22:33:25 +0000 (23:33 +0100)]
add option to split ldap username during login

Change-Id: I0e1f00008391971c3b42e57af035c3252d0ecf94
Reviewed-on: http://gerrit.tine20.com/customers/1497
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
5 years agohide some unimportant columns
Lars Kneschke [Tue, 30 Dec 2014 15:57:18 +0000 (16:57 +0100)]
hide some unimportant columns

Change-Id: I4443245ff27d604411ec7508bc62c53cfc249f53
Reviewed-on: http://gerrit.tine20.com/customers/1496
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Tue, 30 Dec 2014 15:41:09 +0000 (16:41 +0100)]
Merge branch '2013.10' into 2014.11

5 years agofix problem during installation
Lars Kneschke [Tue, 30 Dec 2014 11:50:29 +0000 (12:50 +0100)]
fix problem during installation

- Setup_Controller::_installApplication::1498 error at installing: Sales
Table: sales_offers Exception: No Permission.

Change-Id: I63c4b740ece7c82ce52b41dbe05544578933f37e
Reviewed-on: http://gerrit.tine20.com/customers/1493
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
5 years agofixes merge problems
Philipp Schüle [Tue, 30 Dec 2014 13:05:26 +0000 (14:05 +0100)]
fixes merge problems

* Tinebase_Helper::convertCacheId
* improves date handling in Sales test and Employee controller
* merge conflicting Date/DateTime handling

Change-Id: I30c9ace53c040f7466f5408a2b6dd9f6516b8f06
Reviewed-on: http://gerrit.tine20.com/customers/1494
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0010610: yearly event is not shown in week view
Philipp Schüle [Mon, 29 Dec 2014 12:25:34 +0000 (13:25 +0100)]
0010610: yearly event is not shown in week view

* Skipping performance optimization (removal of base events with
non-matching rrule) because we can't handle year boundaries yet

https://forge.tine20.org/view.php?id=10610

Change-Id: I2e35bf9fdc541264da6c8a5533078e4fd510ce7d
Reviewed-on: http://gerrit.tine20.com/customers/1489
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimproves HTTP Server exception handling
Philipp Schüle [Tue, 30 Dec 2014 11:17:22 +0000 (12:17 +0100)]
improves HTTP Server exception handling

* return 500 error code if some error occurs during download or export
* adds a TODO in Calendar ods export test

Change-Id: I2d03e45397ab32557dc037838be550bc11556218
Reviewed-on: http://gerrit.tine20.com/customers/1492
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Tue, 30 Dec 2014 11:37:05 +0000 (12:37 +0100)]
Merge branch '2013.10' into 2014.11

Conflicts:
tests/tine20/Calendar/JsonTests.php
tine20/Tinebase/Container.php
tine20/Tinebase/Export/Spreadsheet/Ods.php
tine20/Tinebase/Frontend/Json.php
tine20/Tinebase/Record/Abstract.php
tine20/composer.json
tine20/composer.lock

Change-Id: I3d3cf870d6341a33f5262b95a9868c5a9b5ac089

5 years agocheck if cache is initialized and if result of describeTable is valid
Lars Kneschke [Mon, 29 Dec 2014 21:21:20 +0000 (22:21 +0100)]
check if cache is initialized and if result of describeTable is valid

Change-Id: I00e13a9cf5916840363f696579d4da0ad915ad20
Reviewed-on: http://gerrit.tine20.com/customers/1490
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoimprove perfomance by avoiding double cache hit
Lars Kneschke [Mon, 29 Dec 2014 12:11:58 +0000 (13:11 +0100)]
improve perfomance by avoiding double cache hit

Change-Id: Ib5366851ed72f6ba5857f5a186e29f256cc340ec
Reviewed-on: http://gerrit.tine20.com/customers/1488
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0009542: load event relations on demand
Cornelius Weiß [Mon, 22 Dec 2014 16:05:22 +0000 (17:05 +0100)]
0009542: load event relations on demand

* exclude recurring events (not exceptions)
* adds generic getRelations() to Tinebase JSON frontend

https://forge.tine20.org/view.php?id=9542

Change-Id: I88a5311e42b2f9aae8d6665a21714bfb5fb181ef
Reviewed-on: http://gerrit.tine20.com/customers/1484
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoupdates metaways/opendocument to version 0.2
Philipp Schüle [Mon, 29 Dec 2014 11:27:56 +0000 (12:27 +0100)]
updates metaways/opendocument to version 0.2

* to allow direct styling of nodes and columns

Change-Id: I78126a740e58e85031b1efd9ccb1a8037d594cf2
Reviewed-on: http://gerrit.tine20.com/customers/1487
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadd ods export to calendar
Cornelius Weiß [Mon, 22 Dec 2014 13:47:49 +0000 (14:47 +0100)]
add ods export to calendar

* export button to be added in master
** merge with import btn to a single height btn group

Change-Id: Ic506628f165a0d39a59571cecb1c7f9dd0096537
Reviewed-on: http://gerrit.tine20.com/customers/1461
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
5 years agoperformance improvements for Tinebase_Convert_Json
Lars Kneschke [Sat, 20 Dec 2014 22:04:36 +0000 (23:04 +0100)]
performance improvements for Tinebase_Convert_Json

- skip hasGrant as Tinebase_Core::getApplicationInsatce calls hasGrant
anyway
- don't try to resolve id's of empty recordSets

Change-Id: I9c9ee43d9635948a4e8a28d3b118630e9b46ab08
Reviewed-on: http://gerrit.tine20.com/customers/1477
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimproved performance of getTableDescriptionFromCache
Lars Kneschke [Sat, 20 Dec 2014 22:16:08 +0000 (23:16 +0100)]
improved performance of getTableDescriptionFromCache

- call Zend_Db::describeTable() without the overhead of Zend_Db_Table

Change-Id: I584152a1c77b1552e45d78bb048dbefe782eec4e
Reviewed-on: http://gerrit.tine20.com/customers/1479
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadd inClassCache for Tinebase_Acl_Roles class
Lars Kneschke [Fri, 19 Dec 2014 21:14:32 +0000 (22:14 +0100)]
add inClassCache for Tinebase_Acl_Roles class

- read all rights of given account at once, cache them in class cache
and check for requested right in PHP

Change-Id: I8f85acf0accd16ebb32cba994887fcf212c049f4
Reviewed-on: http://gerrit.tine20.com/customers/1476
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimplemented users count function in user backend
Lars Kneschke [Mon, 29 Dec 2014 07:34:27 +0000 (08:34 +0100)]
implemented users count function in user backend

Change-Id: I5a50a45c5daefcaf71b0475a437403054e53be97
Reviewed-on: http://gerrit.tine20.com/customers/1486
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoupdated notes tests
Lars Kneschke [Mon, 22 Dec 2014 09:45:11 +0000 (10:45 +0100)]
updated notes tests

- wrapped test in transaction
- added test to get notetypes ids only

Change-Id: I3f2e6ef44ac7d918f723c08aaa7152f8e90b460e
Reviewed-on: http://gerrit.tine20.com/customers/1483
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoimprove perfomance by avoiding double cache hit
Lars Kneschke [Sat, 20 Dec 2014 22:21:54 +0000 (23:21 +0100)]
improve perfomance by avoiding double cache hit

Change-Id: I9e7b02b518cceda4db45537c563c0cb5fb85d1c3
Reviewed-on: http://gerrit.tine20.com/customers/1481
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoimproved performance of Tinebase_Notes
Lars Kneschke [Sat, 20 Dec 2014 22:19:16 +0000 (23:19 +0100)]
improved performance of Tinebase_Notes

- switched from Zend_Db_Table to Zend_Db_Select to reduce processing
time
- added support for fetching id's of note_types only

Change-Id: Iaba8c075514883ad08eb0b5f300b69eac0218a0a
Reviewed-on: http://gerrit.tine20.com/customers/1480
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoadded in class cache for Tinebase_Container
Lars Kneschke [Thu, 18 Dec 2014 12:15:28 +0000 (13:15 +0100)]
added in class cache for Tinebase_Container

Change-Id: Icd655be9c08fdef643a0ebeed4fc38399c0acc80
Reviewed-on: http://gerrit.tine20.com/customers/1465
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoImproves customfield configuration dialog
Michael Spahn [Tue, 16 Dec 2014 15:40:06 +0000 (16:40 +0100)]
Improves customfield configuration dialog

* use app default model
* reset model field on app change
* don't allow to choose apps without model
* allow to translation app names

Change-Id: I19ba9e24ea4abbda143ba4c728551d90d3bd3aea
Reviewed-on: http://gerrit.tine20.com/customers/1475
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agorobusten code by checking variables before accessing
Philipp Schüle [Fri, 19 Dec 2014 12:18:44 +0000 (13:18 +0100)]
robusten code by checking variables before accessing

Change-Id: I73b03fddfb221d55734d6f8fd6b43c7707e32b9a
Reviewed-on: http://gerrit.tine20.com/customers/1474
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoFix 24:00 crop
sstamer [Fri, 19 Dec 2014 11:54:37 +0000 (12:54 +0100)]
Fix 24:00 crop

- don't set height to 0 if offset is 0 (24:00 = no offset)

Change-Id: If585022a0abe1d85c518bfc4370df4951af05f82
Reviewed-on: http://gerrit.tine20.com/customers/1472
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimproved performance
Lars Kneschke [Wed, 17 Dec 2014 08:09:35 +0000 (09:09 +0100)]
improved performance

- avoid multiple calls to get the same array value
- removed unused code

Change-Id: Ic6c6737a6c6f1ad850a875f130a4cec1c2dc4d98
Reviewed-on: http://gerrit.tine20.com/customers/1457
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Cornelius Weiss <c.weiss@metaways.de>
5 years agoimprove class logic
Lars Kneschke [Fri, 19 Dec 2014 08:54:53 +0000 (09:54 +0100)]
improve class logic

- avoid multiple calls to get the same variable (performance)
- avoid call to get all displayContainerIds

Change-Id: Ibf2284eef43d117cb823d9f749686d07a3a20454
Reviewed-on: http://gerrit.tine20.com/customers/1469
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadded internal class cache
Lars Kneschke [Fri, 19 Dec 2014 09:01:28 +0000 (10:01 +0100)]
added internal class cache

- avoid multiple lookup of the same data

Change-Id: I9c5f7d2e119dd617ad41fe6e3e09ef85cb78a22f
Reviewed-on: http://gerrit.tine20.com/customers/1470
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agomicro code optimization
Lars Kneschke [Fri, 19 Dec 2014 08:49:39 +0000 (09:49 +0100)]
micro code optimization

- do string conversation only when not a DateTime object

Change-Id: Ic29f4657c4b72ba6d793c2291e190bd40ef5d3e1
Reviewed-on: http://gerrit.tine20.com/customers/1468
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Thu, 18 Dec 2014 11:43:45 +0000 (12:43 +0100)]
Merge branch '2013.10' into 2014.11

5 years agofixes some variable names (ActiveSync.resetsync CLI)
Philipp Schüle [Wed, 17 Dec 2014 20:30:00 +0000 (21:30 +0100)]
fixes some variable names (ActiveSync.resetsync CLI)

Change-Id: I46c87dcde2b2c6f1a6457d78421d4cc904ef3b14
Reviewed-on: http://gerrit.tine20.com/customers/1459
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoallign checkbox style to standards
Cornelius Weiß [Thu, 18 Dec 2014 09:29:24 +0000 (10:29 +0100)]
allign checkbox style to standards

Change-Id: I631d430650714a71cb98e55bcc84d3a89e7a29f3
Reviewed-on: http://gerrit.tine20.com/customers/1460
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoWIP increase content Sequence with ldap
sstamer [Thu, 18 Dec 2014 10:04:03 +0000 (11:04 +0100)]
WIP increase content Sequence with ldap

- for now reverted

Change-Id: I40c66c87f68cf9f7555c7307f31b9acfbd297bbd
Reviewed-on: http://gerrit.tine20.com/customers/1462
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoWIP increase content Sequence with ldap
sstamer [Thu, 18 Dec 2014 10:04:03 +0000 (11:04 +0100)]
WIP increase content Sequence with ldap

- for now reverted

Change-Id: I40c66c87f68cf9f7555c7307f31b9acfbd297bbd
Reviewed-on: http://gerrit.tine20.com/customers/1462
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoTranslation fix Filemanager
sstamer [Wed, 17 Dec 2014 16:00:25 +0000 (17:00 +0100)]
Translation fix Filemanager

Change-Id: Iae9124210f1234927f51c82228d6d3d2c5e2a144
Reviewed-on: http://gerrit.tine20.com/customers/1458
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Wed, 17 Dec 2014 15:57:50 +0000 (16:57 +0100)]
Merge branch '2013.10' into 2014.11

5 years agoTranslate Modules
sstamer [Tue, 16 Dec 2014 12:24:19 +0000 (13:24 +0100)]
Translate Modules

Change-Id: Icd3c7701848e6f5e5d110c7b148798eeee116ecf
Reviewed-on: http://gerrit.tine20.com/customers/1454
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoTranslate HumanRes dialogs
sstamer [Tue, 16 Dec 2014 13:56:38 +0000 (14:56 +0100)]
Translate HumanRes dialogs

- Make dialogs higher
- Translate stuff
- Translate Modlog

Change-Id: If5b7e323ff25890308a6bfa6f036b9ba5dc06bac
Reviewed-on: http://gerrit.tine20.com/customers/1455
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Michael Spahn <m.spahn@metaways.de>
Tested-by: Michael Spahn <m.spahn@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoTranslate the last filter used
sstamer [Tue, 16 Dec 2014 11:37:35 +0000 (12:37 +0100)]
Translate the last filter used

- This translation comes from Tinebase

Change-Id: I3c66873251d20dcbbcc6604379f1e64156817cd7
Reviewed-on: http://gerrit.tine20.com/customers/1453
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Michael Spahn <m.spahn@metaways.de>
Tested-by: Michael Spahn <m.spahn@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agofixes backend variable
Philipp Schüle [Mon, 15 Dec 2014 20:50:04 +0000 (21:50 +0100)]
fixes backend variable

Change-Id: Iea6f0b78f2582888d80aeed89b4797b413881c67
Reviewed-on: http://gerrit.tine20.com/customers/1452
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoFix translation typo for window title
sstamer [Mon, 15 Dec 2014 15:24:38 +0000 (16:24 +0100)]
Fix translation typo for window title

- Felamimail Account

Change-Id: I74b3c6a23bc1f1bd7c19ef1fa6d80d64c398ed35
Reviewed-on: http://gerrit.tine20.com/customers/1451
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoremove install web app
sstamer [Mon, 15 Dec 2014 11:42:19 +0000 (12:42 +0100)]
remove install web app

- we don't need this any more

Change-Id: Ib2bf1ee08fa1d8a509ec84f6b5d63198a2e99df0
Reviewed-on: http://gerrit.tine20.com/customers/1446
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoFix leadstate length
Michael Spahn [Mon, 15 Dec 2014 14:50:45 +0000 (15:50 +0100)]
Fix leadstate length

Change-Id: Ib21b72fa7975964fceca6d31fc23c110fabd347c
Reviewed-on: http://gerrit.tine20.com/customers/1449
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoTranslate Anyone
sstamer [Mon, 15 Dec 2014 14:50:10 +0000 (15:50 +0100)]
Translate Anyone

Change-Id: I0448d39aa0fc2a8471a83462ea38aaa9daa5fcb8
Reviewed-on: http://gerrit.tine20.com/customers/1450
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoincrease sequence when updating user from sync Backend
sstamer [Mon, 8 Dec 2014 13:59:05 +0000 (14:59 +0100)]
increase sequence when updating user from sync Backend

and allows to configure, if user contact data should be synced

plus: renamed a function (syncContact -> createContactForSyncedUser)

Change-Id: I827dfcac287a99b72e89992a427d16e660a30ed9
Reviewed-on: http://gerrit.tine20.com/customers/1445
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agotoggle text of 'show details' filter toolbar button
sstamer [Fri, 5 Sep 2014 20:38:37 +0000 (22:38 +0200)]
toggle text of 'show details' filter toolbar button

Change-Id: I7641a4f2bf6f333acc39e145fd980d4e146b2b33
Reviewed-on: http://gerrit.tine20.com/customers/1447
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0010584: CLI function for resetting sync on devices
Philipp Schüle [Fri, 12 Dec 2014 10:47:21 +0000 (11:47 +0100)]
0010584: CLI function for resetting sync on devices

* allows to reset sync state for user + sync class (Calendar, Contacts,
...) via CLI
* adds a test
* moves parts of Syncroton init to ActiveSync_Controller

https://forge.tine20.org/view.php?id=10584

Change-Id: I1362fbee97c6a3cc6039233b2e23468fc846a7fb
Reviewed-on: http://gerrit.tine20.com/customers/1441
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoFix calendar export tests
Michael Spahn [Wed, 10 Dec 2014 12:00:33 +0000 (13:00 +0100)]
Fix calendar export tests

Change-Id: I3d90dd16ea89aa8cf1812f6290447fa88609f052
Reviewed-on: http://gerrit.tine20.com/customers/1442
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoAdd model picker to admin/containers
Michael Spahn [Mon, 27 Oct 2014 15:46:40 +0000 (16:46 +0100)]
Add model picker to admin/containers

Change-Id: I7a113640b4128eed3b401f19129ddbad7541a067
Reviewed-on: http://gerrit.tine20.com/customers/1443
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agofill atendee cache only when needed
Lars Kneschke [Sun, 14 Dec 2014 18:26:29 +0000 (19:26 +0100)]
fill atendee cache only when needed

Change-Id: Id99d8d3ee139ca7857d6b9df6ef0ecf42d6291f2
Reviewed-on: http://gerrit.tine20.com/customers/1444
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoavoid duplicate call of isRegistered
Lars Kneschke [Fri, 12 Dec 2014 06:14:30 +0000 (07:14 +0100)]
avoid duplicate call of isRegistered

Change-Id: I2faf6597d9b52fbc643c3a03b7d7a0c51583c32e
Reviewed-on: http://gerrit.tine20.com/customers/1439
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Fri, 12 Dec 2014 09:24:50 +0000 (10:24 +0100)]
Merge branch '2013.10' into 2014.11

5 years agoAdd AllServerTests to build.xml
Michael Spahn [Wed, 10 Dec 2014 14:39:35 +0000 (15:39 +0100)]
Add AllServerTests to build.xml

* adds workaround for server tests to getTranslation()
* deactivates failing ActiveSync_Server_HttpTests

Change-Id: I6da45e7a041826e0f4aa2105b5f2c7ec557ef2aa
Reviewed-on: http://gerrit.tine20.com/customers/1437
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoImplement a combobox to select currency in sales admin
Michael Spahn [Mon, 8 Dec 2014 08:57:00 +0000 (09:57 +0100)]
Implement a combobox to select currency in sales admin

Change-Id: I9783f58f29c28bc6053b9524ba19a3b77db2bbf7
Reviewed-on: http://gerrit.tine20.com/customers/1420
Tested-by: Jenkins CI (http://ci.tine20.com/)
Tested-by: sstamer <s.stamer@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoShort usernames script
sstamer [Thu, 30 Oct 2014 15:06:44 +0000 (16:06 +0100)]
Short usernames script

Change-Id: I9adca764fc69806933a32e943b56037e921b034b
Reviewed-on: http://gerrit.tine20.com/customers/1326
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoremoves merge conflicts in tine20/Courses/translations/de.po
Philipp Schüle [Wed, 10 Dec 2014 16:05:13 +0000 (17:05 +0100)]
removes merge conflicts in tine20/Courses/translations/de.po

Change-Id: I80ee3d9baefd79ca808088952f2567ba5b0b9351

5 years agomake sure that caldav attachments filenames are decoded
Philipp Schüle [Mon, 8 Dec 2014 11:15:40 +0000 (12:15 +0100)]
make sure that caldav attachments filenames are decoded

* always (raw)urldecode attachment filenames before saving them in Tine
2.0 vfs
* adjusts regex for utf-8 dispositions

Change-Id: I894e53f02792c52b965133d03a39747ce4d7d4c0
Reviewed-on: http://gerrit.tine20.com/customers/1424
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0010578: Fix for groups in active directory is broken
sstamer [Tue, 9 Dec 2014 15:35:27 +0000 (16:35 +0100)]
0010578: Fix for groups in active directory is broken

https://forge.tine20.org/view.php?id=10578

Change-Id: Ie72c06f612a85e34b5ffb60654ede3a61c80ae80
Reviewed-on: http://gerrit.tine20.com/customers/1432
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoChange internet access default
sstamer [Tue, 9 Dec 2014 14:54:58 +0000 (15:54 +0100)]
Change internet access default

- and translations

Change-Id: I1020c1f5f12ea23197b5cc77ce003c229ee9deca
Reviewed-on: http://gerrit.tine20.com/customers/1431
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agooptimized _checkGrants for performance
Lars Kneschke [Sun, 7 Dec 2014 13:25:52 +0000 (14:25 +0100)]
optimized _checkGrants for performance

- resultset will not be cloned any more
- needed data will stored in separate variables
- avoid unneeded function calls

Change-Id: I94cce34bdf394aab9a9df94dbb76b1ed774b9dc3
Reviewed-on: http://gerrit.tine20.com/customers/1419
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agofixes merge failure (missing braces)
Philipp Schüle [Tue, 9 Dec 2014 15:06:00 +0000 (16:06 +0100)]
fixes merge failure (missing braces)

5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Tue, 9 Dec 2014 14:45:18 +0000 (15:45 +0100)]
Merge branch '2013.10' into 2014.11

Conflicts:
tine20/Calendar/Frontend/WebDAV/Event.php
tine20/Tinebase/Config.php
tine20/Tinebase/Container.php
tine20/Tinebase/Core.php
tine20/Tinebase/User/Abstract.php

Change-Id: I802c8cb9d54ad4dbf43f0bc0f8d5645d399b84f1

5 years ago0010554: create default department (school) on Courses installation
Philipp Schüle [Mon, 8 Dec 2014 10:54:20 +0000 (11:54 +0100)]
0010554: create default department (school) on Courses installation

https://forge.tine20.org/view.php?id=10554

Change-Id: Ie2dce15ec889f2738b02b623a1571a2e29abb1e6
Reviewed-on: http://gerrit.tine20.com/customers/1423
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0010568: maximal username length
sstamer [Wed, 29 Oct 2014 14:38:33 +0000 (15:38 +0100)]
0010568: maximal username length

https://forge.tine20.org/view.php?id=10568

- Config optiont for max username length

Change-Id: I4d6fc19f84dc811fd3178b3546cbb3ea81aee8d5
Reviewed-on: http://gerrit.tine20.com/customers/1318
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimprove perfomance of Tinebase_Core::isLogLevel
Lars Kneschke [Mon, 8 Dec 2014 09:35:31 +0000 (10:35 +0100)]
improve perfomance of Tinebase_Core::isLogLevel

- cache value of getLogLevel in class variable
- 58 calls took 625 ms before modification
- 58 calls took  10 ms after modification

Change-Id: I3604fbdf7a9612c6cafefe79d4bc57457a743d12
Reviewed-on: http://gerrit.tine20.com/customers/1422
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agosplitted logic of container grants in to two functions
Lars Kneschke [Sun, 7 Dec 2014 13:22:07 +0000 (14:22 +0100)]
splitted logic of container grants in to two functions

- one function will return the grants only
- another one to merge the grants into resultset

Change-Id: I03aefcaa984aa7d4fa4b65d61aeb1863b951bc3a
Reviewed-on: http://gerrit.tine20.com/customers/1418
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimprove performance of Tinebase_Core::get
Lars Kneschke [Mon, 8 Dec 2014 09:28:19 +0000 (10:28 +0100)]
improve performance of Tinebase_Core::get

Zend_Registry::get calls Zend_Registry::isRegistered too and throws an
exception when the key is not registered.

Executiontime for Tinebase_Core::get is reduced by 20%.

Change-Id: I09b8457665ca2c4dce923ee6b4dd9ec8c66069c7
Reviewed-on: http://gerrit.tine20.com/customers/1421
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoattendee has to be cloned before it can be added to result set
Lars Kneschke [Sun, 7 Dec 2014 12:50:00 +0000 (13:50 +0100)]
attendee has to be cloned before it can be added to result set

Change-Id: I718fa0cae78c3ff8bf71451e75d1649ef592aa7a
Reviewed-on: http://gerrit.tine20.com/customers/1417
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agofix test testAlarmAckInRecurException
Lars Kneschke [Sat, 6 Dec 2014 03:44:08 +0000 (04:44 +0100)]
fix test testAlarmAckInRecurException

- the format of the validated string was wrong

Change-Id: I7942dbfa728cd7a967be36df33547407da41fcf5
Reviewed-on: http://gerrit.tine20.com/customers/1416
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoarray key must be scalar value
Lars Kneschke [Fri, 5 Dec 2014 23:02:32 +0000 (00:02 +0100)]
array key must be scalar value

Change-Id: I073b28a5e8a09609dd21be0f9b77cecfbc098aae
Reviewed-on: http://gerrit.tine20.com/customers/1415
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Lars Kneschke <l.kneschke@metaways.de>
5 years agoExtend filter field for leadsource to 350px
Michael Spahn [Fri, 5 Dec 2014 10:26:58 +0000 (11:26 +0100)]
Extend filter field for leadsource to 350px

Change-Id: Ifed480726344f7d4b73954cf27db1100150cbf81
Reviewed-on: http://gerrit.tine20.com/customers/1411
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
5 years agodelay creating instance of converter until really needed
Lars Kneschke [Fri, 5 Dec 2014 06:37:55 +0000 (07:37 +0100)]
delay creating instance of converter until really needed

... to improve performance

- creating the converter instance can be avoided in many use cases

Change-Id: Iaae99edd1006b075bc60feec2fd9289b7d3c78f0
Reviewed-on: http://gerrit.tine20.com/customers/1410
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
5 years agorefactored Calendar_Model_Attender::getAttendee
Lars Kneschke [Fri, 5 Dec 2014 05:00:27 +0000 (06:00 +0100)]
refactored Calendar_Model_Attender::getAttendee

... to improve performance

- don't process empty $_attendeesSet
- avoid manipulating $_attendeesSet
- avoid calling ->filter 4 times in worst case
- stop processing as soon as possible (->filter always loops all elements in recordSet)

Change-Id: Idc02a533a1ce840a9fd513b14c7e21111f4ba023
Reviewed-on: http://gerrit.tine20.com/customers/1408
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)