tine20
3 years ago0011958: Decouple Tinebase_EmailUser backend from Felamimail
Flávio Gomes da Silva Lisboa [Mon, 20 Jun 2016 18:54:08 +0000 (15:54 -0300)]
0011958: Decouple Tinebase_EmailUser backend from Felamimail

- Create abstract class Tinebase_EmailUser_Model_Account
and move Felamimail_Model_Account constants into it
- Change references to Felamimail_Model_Account constants by
Tinebase_EmailUser_Model_Account constants

Change-Id: I5593003e914dd7528363e98412fefacb15947cfa
Reviewed-on: https://gerrit.tine20.org/tine20/3348
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11-develop' into 2016.03 2016.03.4
Philipp Schüle [Mon, 20 Jun 2016 11:47:35 +0000 (13:47 +0200)]
Merge branch '2015.11-develop' into 2016.03

3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Mon, 20 Jun 2016 11:47:10 +0000 (13:47 +0200)]
Merge branch '2015.11' into 2015.11-develop

3 years agouse correct variable: $folder instead of $folderId
Philipp Schüle [Mon, 20 Jun 2016 09:06:46 +0000 (11:06 +0200)]
use correct variable: $folder instead of $folderId

... in updateFolder()

Change-Id: I1b8ed0323ec2c31823d9f2b77f7e087b7bd998cc
Reviewed-on: http://gerrit.tine20.com/customers/3256
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011956: terms and conditions writing misstake
sstamer [Mon, 20 Jun 2016 10:38:52 +0000 (12:38 +0200)]
0011956: terms and conditions writing misstake

https://forge.tine20.org/view.php?id=11956
Fix typo OpenStreetMap

Change-Id: I3338a6f95d72b8f737f5c4192825e067f0dd2915
Reviewed-on: http://gerrit.tine20.com/customers/3258
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011954: setup.php (webbased) "accept conditions"-dialog broken now
Philipp Schüle [Mon, 20 Jun 2016 09:57:59 +0000 (11:57 +0200)]
0011954: setup.php (webbased) "accept conditions"-dialog broken now

* fixes MixedCollection event handling in store.compat.js
... to make registry 'replace' work again
* adds a log message if Terms have not been accepted

 https://forge.tine20.org/view.php?id=11954

Change-Id: Id19cc397f1a9163d304653933085d45a53105c71
Reviewed-on: http://gerrit.tine20.com/customers/3257
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agodo not try to rename folder that has not changed
Philipp Schüle [Mon, 20 Jun 2016 09:04:08 +0000 (11:04 +0200)]
do not try to rename folder that has not changed

Change-Id: I6288a329deeccca1eb3580622aaadffaa497ffc4
Reviewed-on: http://gerrit.tine20.com/customers/3255
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agodeactivates failing testImportMembersIntoCourse2
Philipp Schüle [Thu, 16 Jun 2016 16:26:41 +0000 (18:26 +0200)]
deactivates failing testImportMembersIntoCourse2

0011950: fix failing test in Courses_JsonTest
https://forge.tine20.org/view.php?id=11950

Change-Id: Ia5b3a0460019b1d4552037983765ad89bcb84290
Reviewed-on: https://gerrit.tine20.org/tine20/3347
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoimprove webpack alert (adds anchor)
Philipp Schüle [Thu, 16 Jun 2016 09:21:42 +0000 (11:21 +0200)]
improve webpack alert (adds anchor)

Change-Id: Idf677904f45f72147b26a8364a4ca83c0466ba51
Reviewed-on: http://gerrit.tine20.com/customers/3243
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11-develop' into 2016.03 2016.03.3
Philipp Schüle [Thu, 16 Jun 2016 10:14:58 +0000 (12:14 +0200)]
Merge branch '2015.11-develop' into 2016.03

3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Thu, 16 Jun 2016 10:14:22 +0000 (12:14 +0200)]
Merge branch '2015.11' into 2015.11-develop

Conflicts:
tine20/Tinebase/Core.php

Change-Id: I93ec1d66b8324c804db4d1e26955128527946790

3 years agocatch setup user creation exceptions
Philipp Schüle [Thu, 16 Jun 2016 09:20:19 +0000 (11:20 +0200)]
catch setup user creation exceptions

... and skip call update in Phone if that
 is the case

 see 0011934: show contacts in phone call grid

Change-Id: I54281f20e66fa39b2dd04b32b5f581afcde35d62
Reviewed-on: http://gerrit.tine20.com/customers/3242
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011898: Download links missing server subdir part
Philipp Schüle [Thu, 9 Jun 2016 16:37:46 +0000 (18:37 +0200)]
0011898: Download links missing server subdir part

* make use of new Tinebase_Core::getUrl()
* 'full' is default part for getUrl()

https://forge.tine20.org/view.php?id=11898

Change-Id: I91076e42d4f4ad44a3ac6114677153c80b43ed81
Reviewed-on: http://gerrit.tine20.com/customers/3245
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agobackports Tinebase_Core::getUrl
Philipp Schüle [Thu, 16 Jun 2016 09:29:41 +0000 (11:29 +0200)]
backports Tinebase_Core::getUrl

... from 2015.11-develop

Change-Id: I7382b9e44b72b1e1a17e5b4c19947099a9c95d1c
Reviewed-on: http://gerrit.tine20.com/customers/3244
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11-develop' into 2016.03
Philipp Schüle [Thu, 16 Jun 2016 08:53:54 +0000 (10:53 +0200)]
Merge branch '2015.11-develop' into 2016.03

3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Thu, 16 Jun 2016 08:53:35 +0000 (10:53 +0200)]
Merge branch '2015.11' into 2015.11-develop

3 years agoMerge branch '2014.11' into 2015.11
Philipp Schüle [Thu, 16 Jun 2016 08:53:08 +0000 (10:53 +0200)]
Merge branch '2014.11' into 2015.11

Conflicts:
tine20/Calendar/Convert/Event/Json.php
tine20/Calendar/Frontend/iMIP.php
tine20/Sales/Setup/Update/Release8.php

Change-Id: I94ce69a37d81e860f8fdef95fe687d3eb26bf735

3 years ago0011942: MacOSX - GROUP rewrite to INTELLIGROUP
Paul Mehrer [Thu, 2 Jun 2016 10:33:16 +0000 (12:33 +0200)]
0011942: MacOSX - GROUP rewrite to INTELLIGROUP

rewrite attendee cutype 'GROUP' to 'INTELLIGROUP' for export
and vice versa for import due to malbehaviour of ical

https://forge.tine20.org/view.php?id=11942

Change-Id: I83651323a682dae2688a9b34508cbd366bb906eb
Reviewed-on: http://gerrit.tine20.com/customers/3187
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011934: show contacts in phone call grid
Philipp Schüle [Tue, 14 Jun 2016 14:20:15 +0000 (16:20 +0200)]
0011934: show contacts in phone call grid

... Addressbook update script version has
 been raised to 9.8

Change-Id: Ia52b9e8836ec87247c4a1e0005ee3794cd6d9e93
Reviewed-on: http://gerrit.tine20.com/customers/3235
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoshow instructions for webpack-dev-server in alert message
Philipp Schüle [Thu, 16 Jun 2016 06:52:38 +0000 (08:52 +0200)]
show instructions for webpack-dev-server in alert message

 ... in dev mode

 see https://forge.tine20.org/view.php?id=11882
 0011882: add webpack as javascript packager for libraries

Change-Id: Id91b9e8d725d0c219986d1b1039b4e462e221d37
Reviewed-on: http://gerrit.tine20.com/customers/3241
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0010890: Sales module can not be successfully updated to 2014.09.8
Philipp Schüle [Mon, 13 Jun 2016 11:02:51 +0000 (13:02 +0200)]
0010890: Sales module can not be successfully updated to 2014.09.8

https://forge.tine20.org/view.php?id=10890

Change-Id: Ia213a0ea378824dc91d3b67e9342f344410ecdda
Reviewed-on: http://gerrit.tine20.com/customers/3228
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011890: disallow external attendee status setting for external organizer
Cornelius Weiß [Mon, 30 May 2016 16:00:12 +0000 (18:00 +0200)]
0011890: disallow external attendee status setting for external organizer

Change-Id: I47bc3235431650d786b6798b14b500b62d7addd4
Reviewed-on: http://gerrit.tine20.com/customers/3184
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago'Internal Contacts' container was missing contact model
Philipp Schüle [Tue, 14 Jun 2016 12:09:46 +0000 (14:09 +0200)]
'Internal Contacts' container was missing contact model

Change-Id: Ib380acad54946cf0ac0d5e6bc3b054692a097969
Reviewed-on: http://gerrit.tine20.com/customers/3232
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Tue, 14 Jun 2016 09:14:42 +0000 (11:14 +0200)]
Merge branch '2015.11' into 2015.11-develop

Conflicts:
tine20/Felamimail/js/MessageEditDialog.js
tine20/Tinebase/js/MainMenu.js
tine20/Tinebase/js/widgets/grid/FilterToolbar.js

Change-Id: I97ba4a6a9aab47e3dc1efc0cc0f7890be7b256f4

3 years agoMerge branch '2014.11' into 2015.11
Philipp Schüle [Tue, 14 Jun 2016 09:11:59 +0000 (11:11 +0200)]
Merge branch '2014.11' into 2015.11

3 years agohandle default config values
Cornelius Weiß [Fri, 10 Jun 2016 14:39:33 +0000 (16:39 +0200)]
handle default config values

* don't save if default wasn't changed
* delete db config if value returned to default

Change-Id: Ic052324752a688afb9fbef2ac493382bbbfd1ae8
Reviewed-on: http://gerrit.tine20.com/customers/3224
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agotranslation scope in keyfield get lost
Cornelius Weiß [Fri, 10 Jun 2016 09:50:55 +0000 (11:50 +0200)]
translation scope in keyfield get lost

Change-Id: If7f9de7425c581f19362be861451dc7a95eb1f40
Reviewed-on: http://gerrit.tine20.com/customers/3223
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011930: conjunction operator not shown correctly in rule edit dialog
Philipp Schüle [Mon, 13 Jun 2016 09:59:12 +0000 (11:59 +0200)]
0011930: conjunction operator not shown correctly in rule edit dialog

* set operator on record load
* adds translation for 'or' operator

https://forge.tine20.org/view.php?id=11930

Change-Id: I7a0f0fdcb7e3315792460e4883bb5eadce01dd31
Reviewed-on: http://gerrit.tine20.com/customers/3226
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011932: show address and customer data for manual invoices
Philipp Schüle [Mon, 13 Jun 2016 10:39:08 +0000 (12:39 +0200)]
0011932: show address and customer data for manual invoices

* fixes company name and address data display

https://forge.tine20.org/view.php?id=11932

Change-Id: I89301971a531d8adf7020651744fccab03a588e7
Reviewed-on: http://gerrit.tine20.com/customers/3227
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011934: show contacts in phone call grid
Paul Mehrer [Mon, 9 May 2016 13:23:46 +0000 (15:23 +0200)]
0011934: show contacts in phone call grid

* adds new contact fields for normalized numbers
* adds update script that creates contact relations
 for the most recent phone calls
* creates SETUPUSER on the fly if it does not exist

https://forge.tine20.org/view.php?id=11934

Change-Id: I881ca4526207f047657de1594a4242ae7d34f969
Reviewed-on: http://gerrit.tine20.com/customers/3142
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011936: Allow compose Mail for select all pages
sstamer [Tue, 31 May 2016 08:50:55 +0000 (10:50 +0200)]
0011936: Allow compose Mail for select all pages

https://forge.tine20.org/view.php?id=11936

Change-Id: Id2fb6ab0ee872f63493070103e1f09a50938fd99
Reviewed-on: http://gerrit.tine20.com/customers/3230
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoremove external_seq from modlog
Philipp Schüle [Fri, 10 Jun 2016 15:57:31 +0000 (17:57 +0200)]
remove external_seq from modlog

... as the user does not know what this means

Change-Id: I8ed889d8b7812b9d5d6c775be6bdb11159d9462c
Reviewed-on: http://gerrit.tine20.com/customers/3225
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011808: Tine 2.0 blocks emClient 7
Johannes Nohl [Sun, 12 Jun 2016 23:55:03 +0000 (01:55 +0200)]
0011808: Tine 2.0 blocks emClient 7

* Arrange cardDAV converter for eM Client 7 (Release Candidate)
* make contacts writable and adjust fields.

https://forge.tine20.org/view.php?id=11808

Change-Id: Ie77cb7ccd6ca2e0fd94ca01daf8d8fbf076ce76a
Reviewed-on: https://gerrit.tine20.org/tine20/3345
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11-develop-postal' into 2015.11-develop
Philipp Schüle [Fri, 10 Jun 2016 16:18:29 +0000 (18:18 +0200)]
Merge branch '2015.11-develop-postal' into 2015.11-develop

3 years ago0011898: Download links missing server subdir part
Philipp Schüle [Thu, 9 Jun 2016 16:37:46 +0000 (18:37 +0200)]
0011898: Download links missing server subdir part

* make use of new Tinebase_Core::getUrl()
* 'full' is default part for getUrl()

https://forge.tine20.org/view.php?id=11898

Change-Id: I92e8889623d11eaa748e0ee134f4326d6f6c40f5
Reviewed-on: http://gerrit.tine20.com/customers/3222
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agouse Addressbook list view feature switch to disable query
Paul Mehrer [Fri, 27 May 2016 15:20:47 +0000 (17:20 +0200)]
use Addressbook list view feature switch to disable query

surrounding a query part by a feature switch

Change-Id: If42e2395a785e0499620a9e075bdebc9478e6116
Reviewed-on: http://gerrit.tine20.com/customers/3203
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011904: Disable manage profile if the user has no right
sstamer [Tue, 31 May 2016 12:46:40 +0000 (14:46 +0200)]
0011904: Disable manage profile if the user has no right

https://forge.tine20.org/view.php?id=11904

Change-Id: Ib838e8b8388afc2ddb40475b99ca22c39c49d6b9
Reviewed-on: http://gerrit.tine20.com/customers/3197
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agobring back global _() as deprecated i18n ref
Cornelius Weiß [Thu, 9 Jun 2016 06:32:53 +0000 (08:32 +0200)]
bring back global _() as deprecated i18n ref

* with webpack we don't need to have lodash globally exposed
* using _ as i18n eases the transition as we have it used in multiple
  branches

Change-Id: I3914f537481ac36796cc427d3f12c0438fe42a6c
Reviewed-on: http://gerrit.tine20.com/customers/3219
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agomoves setting of SERVER vars in test bootstrap
Philipp Schüle [Wed, 8 Jun 2016 08:29:32 +0000 (10:29 +0200)]
moves setting of SERVER vars in test bootstrap

Change-Id: Ib64d446806fbd604032417e5364bf85a465ec376
Reviewed-on: http://gerrit.tine20.com/customers/3206
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11-develop' into 2016.03
Philipp Schüle [Thu, 9 Jun 2016 15:25:03 +0000 (17:25 +0200)]
Merge branch '2015.11-develop' into 2016.03

3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Thu, 9 Jun 2016 15:24:29 +0000 (17:24 +0200)]
Merge branch '2015.11' into 2015.11-develop

3 years ago0011918: shorten for export fields
sstamer [Thu, 2 Jun 2016 14:42:15 +0000 (16:42 +0200)]
0011918: shorten for export fields

* configure maxlines and maxcharacters

https://forge.tine20.org/view.php?id=11918

Change-Id: I64fd764885851310ed65e19f57b214f2c3dbd31c
Reviewed-on: http://gerrit.tine20.com/customers/3198
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agogetRelations: fixes phpdoc and set fallback for types
Philipp Schüle [Thu, 9 Jun 2016 12:16:28 +0000 (14:16 +0200)]
getRelations: fixes phpdoc and set fallback for types

... as sometimes the clients sends NULL for $type

Change-Id: I58e2b0d5e0cf13df094521a151d15bb0175c25d6
Reviewed-on: http://gerrit.tine20.com/customers/3221
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoSetup needs Tinebase libs (webpack), too
Philipp Schüle [Thu, 9 Jun 2016 10:20:29 +0000 (12:20 +0200)]
Setup needs Tinebase libs (webpack), too

Change-Id: Iaec7e2fd8bb28019c15d5c77c9b0dd7b6ebd7442
Reviewed-on: http://gerrit.tine20.com/customers/3220
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
3 years agoMerge branch '2015.11-develop' into 2016.03
Philipp Schüle [Wed, 8 Jun 2016 14:54:40 +0000 (16:54 +0200)]
Merge branch '2015.11-develop' into 2016.03

3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Wed, 8 Jun 2016 14:54:22 +0000 (16:54 +0200)]
Merge branch '2015.11' into 2015.11-develop

3 years agoMerge branch '2014.11' into 2015.11
Philipp Schüle [Wed, 8 Jun 2016 14:54:03 +0000 (16:54 +0200)]
Merge branch '2014.11' into 2015.11

3 years agoCalendar printing in FF
Cornelius Weiß [Mon, 6 Jun 2016 21:41:18 +0000 (23:41 +0200)]
Calendar printing in FF

new printing approach:
- take screenshot with html2canvas
- print screenshot
=> looks better in FF in other browsers

fixes:
 0011708: Firefox printing is broken again
 0011340: Second page corrupt, when printing calender in landscape
 0010628: Calender print shows only time range 0-11 o'clock

Change-Id: I99e0f36249a109fb8acdee447dd95d264f288b3b
Reviewed-on: http://gerrit.tine20.com/customers/3215
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011882: add web pack as javascript packager for libraries
Cornelius Weiß [Thu, 26 May 2016 18:23:46 +0000 (20:23 +0200)]
0011882: add web pack as javascript packager for libraries

Change-Id: Ieacbd2aec5626b31f49016b2c16d4907720ec97f
Reviewed-on: http://gerrit.tine20.com/customers/3214
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agocatch promise error in js log
sstamer [Wed, 8 Jun 2016 11:52:39 +0000 (13:52 +0200)]
catch promise error in js log

Change-Id: Ic9f7b5ce9e7671c34aac417ff7d2be947c30da4a
Reviewed-on: http://gerrit.tine20.com/customers/3207
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoFix scroller jump bug at calendar page start
sstamer [Wed, 8 Jun 2016 11:55:08 +0000 (13:55 +0200)]
Fix scroller jump bug at calendar page start

Change-Id: I3682d359f444d20057d0558b88bcf206c44ff26d
Reviewed-on: http://gerrit.tine20.com/customers/3208
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoRevert "11888 increase announced own cloud server version"
Philipp Schüle [Wed, 8 Jun 2016 10:53:24 +0000 (12:53 +0200)]
Revert "11888 increase announced own cloud server version"

THIS BREAKS OLDER OWNCLOUD CLIENTS!

This reverts commit 203dadea2feb0f9ac48cbdc185526ee224a26058.

Change-Id: I94e6762b97af35b5114c288fa4dbfe9c4b623087
Reviewed-on: http://gerrit.tine20.com/customers/3205
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011824: show raw message when PGP decryption fails
Cornelius Weiß [Wed, 4 May 2016 08:00:11 +0000 (10:00 +0200)]
0011824: show raw message when PGP decryption fails

NOTE: Mailvelope has a bug in it's error handling for displayContainers
      see: https://github.com/mailvelope/mailvelope/pull/386

Change-Id: I1a2af8b0bcef44e5cd1f19dc08edfa7629d661f5
Reviewed-on: http://gerrit.tine20.com/customers/3126
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Tue, 7 Jun 2016 13:58:08 +0000 (15:58 +0200)]
Merge branch '2015.11' into 2015.11-develop

Conflicts:
tine20/Tinebase/js/extFixes.js

Change-Id: I1b4a6d34d03460c784156e94ba4c746693081847

3 years agoMerge branch '2014.11' into 2015.11
Philipp Schüle [Tue, 7 Jun 2016 13:56:55 +0000 (15:56 +0200)]
Merge branch '2014.11' into 2015.11

3 years agoFix copy to clipboard loses view
sstamer [Tue, 7 Jun 2016 09:04:32 +0000 (11:04 +0200)]
Fix copy to clipboard loses view

Change-Id: Ifa74d80779ebb768d1075437de0cf80f8e4dae6a
Reviewed-on: http://gerrit.tine20.com/customers/3201
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011906: Fix contact type not sortable
sstamer [Mon, 6 Jun 2016 14:47:32 +0000 (16:47 +0200)]
0011906: Fix contact type not sortable

https://forge.tine20.org/view.php?id=11906

Change-Id: Ica5d727ce709ff090cd3a670a2276f28d648f6f0
Reviewed-on: http://gerrit.tine20.com/customers/3192
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011884: fix expresso css include flaw
Cornelius Weiß [Fri, 27 May 2016 14:08:20 +0000 (16:08 +0200)]
0011884: fix expresso css include flaw

https://forge.tine20.org/view.php?id=11884

Change-Id: Ia9e5b6a63d9c8d581a5993bef74933cf9d6757d4
Reviewed-on: http://gerrit.tine20.com/customers/3181
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago11888 increase announced own cloud server version
Cornelius Weiß [Fri, 27 May 2016 18:15:57 +0000 (20:15 +0200)]
11888 increase announced own cloud server version

-> use 9.0.2, latest version

Change-Id: I5d0593abea7c279a362a4c7494e3c39c7c8c79ba
Reviewed-on: http://gerrit.tine20.com/customers/3183
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoSales - add/edit contract dialog bug
Paul Mehrer [Fri, 20 May 2016 10:49:18 +0000 (12:49 +0200)]
Sales - add/edit contract dialog bug

in the add/edit contract dialog, in the product
tab, was an error when changing the product quantity

Change-Id: Ib82a0fe5d774846356cdedea76edb97c638220fc
Reviewed-on: http://gerrit.tine20.com/customers/3175
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago11878 allow data reload from external window
Cornelius Weiß [Mon, 23 May 2016 10:44:32 +0000 (12:44 +0200)]
11878 allow data reload from external window

Change-Id: I7479b25295e132ef791ca6cbb8c874f122fa1e55
Reviewed-on: http://gerrit.tine20.com/customers/3176
Reviewed-by: sstamer <s.stamer@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
3 years ago0011830: integrate API for cross window communication
Cornelius Weiß [Fri, 13 May 2016 15:36:31 +0000 (17:36 +0200)]
0011830: integrate API for cross window communication

integrate postal.js as pub/sub library
* integrate postal.xwindow for cross window communication
* have iframe service from server to ease third party app integration
 https://tine.example.com/?method=Tinebase.getPostalXWindow
* integrate postal.request-response for rpc style communication

https://forge.tine20.org/view.php?id=11830

Change-Id: I87592e8756f3608e31d82f3659dcffff004ccfbd
Reviewed-on: http://gerrit.tine20.com/customers/3162
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: sstamer <s.stamer@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
3 years agoRevert "0011830: integrate API for cross window communication"
Philipp Schüle [Tue, 7 Jun 2016 08:52:08 +0000 (10:52 +0200)]
Revert "0011830: integrate API for cross window communication"

This reverts commit c195e92b3035c1b4dd056c4e9829ef7ab5285f4f.

* this will be moved to a separate branch for further testing
* integration will be done when this is more stable

Change-Id: I0792dbdf0654210b36bd08acf3ef6c6faccba218
Reviewed-on: http://gerrit.tine20.com/customers/3195
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoRevert "11878 allow data reload from external window"
Philipp Schüle [Tue, 7 Jun 2016 08:49:09 +0000 (10:49 +0200)]
Revert "11878 allow data reload from external window"

This reverts commit 6bccb0992d43d0576fe4b600af7821aaf78ad2db.

Change-Id: If5ac6a897da6b01fb9e9374d5a203c04fdeef55f
Reviewed-on: http://gerrit.tine20.com/customers/3194
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago146817 can't use mail templates
Cornelius Weiß [Fri, 20 May 2016 09:44:59 +0000 (11:44 +0200)]
146817 can't use mail templates

* format autodetection failed
* add explicit property for type of body property in message records

Change-Id: Ied90d40bbac6352bd5fcd0e9c7bd47fe0f67767d
Reviewed-on: http://gerrit.tine20.com/customers/3173
Reviewed-by: sstamer <s.stamer@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
3 years ago11878 allow data reload from external window
Cornelius Weiß [Mon, 23 May 2016 10:44:32 +0000 (12:44 +0200)]
11878 allow data reload from external window

Change-Id: I7479b25295e132ef791ca6cbb8c874f122fa1e55
Reviewed-on: http://gerrit.tine20.com/customers/3176
Reviewed-by: sstamer <s.stamer@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
3 years ago0011830: integrate API for cross window communication
Cornelius Weiß [Fri, 13 May 2016 15:36:31 +0000 (17:36 +0200)]
0011830: integrate API for cross window communication

integrate postal.js as pub/sub library
* integrate postal.xwindow for cross window communication
* have iframe service from server to ease third party app integration
 https://tine.example.com/?method=Tinebase.getPostalXWindow
* integrate postal.request-response for rpc style communication

https://forge.tine20.org/view.php?id=11830

Change-Id: I87592e8756f3608e31d82f3659dcffff004ccfbd
Reviewed-on: http://gerrit.tine20.com/customers/3162
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: sstamer <s.stamer@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
3 years agoMerge branch '2015.11-develop' into 2016.03
Philipp Schüle [Thu, 19 May 2016 10:34:29 +0000 (12:34 +0200)]
Merge branch '2015.11-develop' into 2016.03

3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Thu, 19 May 2016 10:34:11 +0000 (12:34 +0200)]
Merge branch '2015.11' into 2015.11-develop

3 years ago0011872: add imported members to default group
sstamer [Fri, 13 May 2016 10:40:14 +0000 (12:40 +0200)]
0011872: add imported members to default group

https://forge.tine20.org/view.php?id=11872

Change-Id: I463b740103db13590456369025abe1f21d6d859e
Reviewed-on: http://gerrit.tine20.com/customers/3157
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago11876: Fix Resource invite for splitview
sstamer [Thu, 19 May 2016 09:28:37 +0000 (11:28 +0200)]
11876: Fix Resource invite for splitview

https://forge.tine20.org/view.php?id=11876

- Type user was forced on resource type attendee

Change-Id: I837e7c4d466a856385a13cd5bc6a072a1e36c1f7
Reviewed-on: http://gerrit.tine20.com/customers/3170
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011870: Tinebase_ActionQueue - 100% CPU worker process
Paul Mehrer [Tue, 17 May 2016 12:19:32 +0000 (14:19 +0200)]
0011870: Tinebase_ActionQueue - 100% CPU worker process

if no proper backend is configured, the worker process
just quits instead of running in an infinite loop

https://forge.tine20.org/view.php?id=11870

Change-Id: I28344d2f5124ad8cd282908d9d9d6186b5c29331
Reviewed-on: http://gerrit.tine20.com/customers/3163
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011866: free global _ for lodash library
Philipp Schüle [Wed, 18 May 2016 17:29:11 +0000 (19:29 +0200)]
0011866: free global _ for lodash library

* fixes some missing i18ns

A modern JavaScript utility library delivering
 modularity, performance, & extras.

https://lodash.com/
https://github.com/lodash/lodash

https://forge.tine20.org/view.php?id=11866

Change-Id: I86bbe66104e39a216f8a8e97daa5f4c9f4133615
Reviewed-on: http://gerrit.tine20.com/customers/3167
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoMerge branch '2015.11-develop' into 2016.03
Philipp Schüle [Wed, 18 May 2016 12:44:55 +0000 (14:44 +0200)]
Merge branch '2015.11-develop' into 2016.03

Conflicts:
tine20/Calendar/Config.php
tine20/Expressomail/js/AclsGrid.js
tine20/Tinebase/js/LoginPanel.js

Change-Id: I180380d4528260ba3469dcacfe800ccced0b7c51

3 years agoMerge branch '2015.11' into 2015.11-develop
Philipp Schüle [Wed, 18 May 2016 12:41:59 +0000 (14:41 +0200)]
Merge branch '2015.11' into 2015.11-develop

Conflicts:
tests/tine20/Tinebase/AllTests.php
tine20/Crm/Frontend/Json.php

Change-Id: I99e0f0468b7ce55a761cd43d69ca2479e513ca90

3 years agoMerge branch '2014.11' into 2015.11
Philipp Schüle [Wed, 18 May 2016 12:39:47 +0000 (14:39 +0200)]
Merge branch '2014.11' into 2015.11

3 years ago0011866: free global _ for lodash library
Cornelius Weiß [Tue, 10 May 2016 16:17:39 +0000 (18:17 +0200)]
0011866: free global _ for lodash library

A modern JavaScript utility library delivering
 modularity, performance, & extras.

https://lodash.com/
https://github.com/lodash/lodash

https://forge.tine20.org/view.php?id=11866

Change-Id: I9e902bf6dd61e85addc653195dd1758977ab20f8
Reviewed-on: http://gerrit.tine20.com/customers/3146
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoclient expects default container in 'defaultContainer' registry key
Philipp Schüle [Tue, 17 May 2016 15:03:55 +0000 (17:03 +0200)]
client expects default container in 'defaultContainer' registry key

... on CRM lead import

Change-Id: I691886022bb392d82adf08f353766b5ff9bd0a5b
Reviewed-on: http://gerrit.tine20.com/customers/3164
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011844: decodeSid fails for some encoded SIDs
Philipp Schüle [Tue, 10 May 2016 13:43:48 +0000 (15:43 +0200)]
0011844: decodeSid fails for some encoded SIDs

* encoded Sids might contain dashes -.-
* adds a test
* improves logging

https://forge.tine20.org/view.php?id=11844

Change-Id: Ief81024e3d1c4cd862a587e93529717af88c7f79
Reviewed-on: http://gerrit.tine20.com/customers/3139
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011706: After Update Some elements are broken
Philipp Schüle [Wed, 11 May 2016 08:02:57 +0000 (10:02 +0200)]
0011706: After Update Some elements are broken

* fixes CRM config update script
-> somehow javascript has been introduced
 for string concat ;)
* adds update 9.2 to fix broken 9.1

https://forge.tine20.org/view.php?id=11706

Change-Id: Ia74df585c62a6ad5b9b74c9669f649c86d5846e1
Reviewed-on: http://gerrit.tine20.com/customers/3140
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoFix missing CRM Keyfield icons
sstamer [Wed, 11 May 2016 11:03:27 +0000 (13:03 +0200)]
Fix missing CRM Keyfield icons

Change-Id: I8fbe3792dfb227d3daad96bb3dc8fc926f266be2
Reviewed-on: http://gerrit.tine20.com/customers/3143
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011860: Firefox: error message after setup.php login
Philipp Schüle [Fri, 13 May 2016 14:31:43 +0000 (16:31 +0200)]
0011860: Firefox: error message after setup.php login

* skip exception handling when tine is reloading

... this "fixes" the Firefox problem during setup
 which might be caused by a timing issue and stacked
  registry clearing / reloading

 https://forge.tine20.org/view.php?id=11860

Change-Id: I877de443753bf0014d0a7872e4786b00e6b47dff
Reviewed-on: http://gerrit.tine20.com/customers/3161
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011848: Tine 2.0 update-script creates table adb_list_m_role
Philipp Schüle [Tue, 17 May 2016 16:35:29 +0000 (18:35 +0200)]
0011848: Tine 2.0 update-script creates table adb_list_m_role

* renames table in application_tables
* fixes table name as we had to use adb_list_m_role to have
 small index key lenghts

see https://www.tine20.org/forum/viewtopic.php?f=12&t=17932

https://forge.tine20.org/view.php?id=11848

Change-Id: I4bae6e008d1e7c23e8836ada4983ffbcfa7c41e6
Reviewed-on: http://gerrit.tine20.com/customers/3145
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011864: invite resource automatically
sstamer [Thu, 12 May 2016 12:32:54 +0000 (14:32 +0200)]
0011864: invite resource automatically

... if you create a event in resource calendar

https://forge.tine20.org/view.php?id=11864

Change-Id: I8f9720238a8bc453935cca2e5f19dae4c016d626
Reviewed-on: http://gerrit.tine20.com/customers/3158
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011858: renamed fields might break concurrent update
Philipp Schüle [Thu, 12 May 2016 16:07:13 +0000 (18:07 +0200)]
0011858: renamed fields might break concurrent update

* checks if property exists in record with has()
* renames a remaining "price" property to salesprice
 in lead pdf export

https://forge.tine20.org/view.php?id=11858

Change-Id: I27d0aa661a5837498468a28f59c12bc871959a49
Reviewed-on: http://gerrit.tine20.com/customers/3154
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago11574: backup should only dump structure of some tables
Paul Mehrer [Tue, 12 Apr 2016 11:18:37 +0000 (13:18 +0200)]
11574: backup should only dump structure of some tables

added <backupStructureOnly> flag to setup.xml

https://forge.tine20.org/view.php?id=11574

Change-Id: I0959a1f5f3c006770c9ffb507d3f7a8e8fe313d3
Reviewed-on: http://gerrit.tine20.com/customers/3159
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0001264: compose text emails
Cornelius Weiß [Tue, 12 Apr 2016 08:01:02 +0000 (10:01 +0200)]
0001264: compose text emails

added toggle button in editor
added options
 - compose_format -> format when composing messages
 - preserve_format -> use original format for reply/forward

https://forge.tine20.org/view.php?id=1264

Change-Id: I71110c34724971596baf2670135422f7fde3913c
Reviewed-on: http://gerrit.tine20.com/customers/3124
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoadd feature switch for except recur feature
sstamer [Tue, 10 May 2016 13:40:04 +0000 (15:40 +0200)]
add feature switch for except recur feature

see 0011598: add rrule constraints
https://forge.tine20.org/view.php?id=11598

Change-Id: I83ff7b87a3c69d3f435d984bd068dd34a5b2432f
Reviewed-on: http://gerrit.tine20.com/customers/3138
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago0011856: setup tests: make phpunitconfig.inc.php optional
Philipp Schüle [Thu, 12 May 2016 15:24:11 +0000 (17:24 +0200)]
0011856: setup tests: make phpunitconfig.inc.php optional

improves setup tests bootstrap

* adds bootstrap.php
* extends "normal" TestServer
* allows to get test credentials from phpunit config
 OR config.inc.php

https://forge.tine20.org/view.php?id=11856

Change-Id: I05104b0bb847d24946d676da84ace6eed0e3335f
Reviewed-on: http://gerrit.tine20.com/customers/3153
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoimproved test config handling
Philipp Schüle [Thu, 12 May 2016 15:22:14 +0000 (17:22 +0200)]
improved test config handling

* adds lazy loading for config
* use test credentials in caldav test
* always use getConfig of TestServer instance

Change-Id: If8e33fcd99030bfdb7a9902d3a103161f6b69f7a
Reviewed-on: http://gerrit.tine20.com/customers/3152
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years ago11854: Fix Crm keyfield Filter Bug
sstamer [Fri, 29 Apr 2016 15:55:31 +0000 (17:55 +0200)]
11854: Fix Crm keyfield Filter Bug

https://forge.tine20.org/view.php?id=11854

- int Ids don't work

Change-Id: I05080c5764f89badc8b744b3d4fb737079093418
Reviewed-on: http://gerrit.tine20.com/customers/3151
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agofixes flaky testInvoiceRecreation
Philipp Schüle [Wed, 11 May 2016 09:32:36 +0000 (11:32 +0200)]
fixes flaky testInvoiceRecreation

Change-Id: I0d4e5ddb8c5547a5bfb0e045ea22dbefa6b2c279
Reviewed-on: http://gerrit.tine20.com/customers/3141
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agofixed blacklisting of tine20 config
Philipp Schüle [Tue, 10 May 2016 08:45:05 +0000 (10:45 +0200)]
fixed blacklisting of tine20 config

... use subdir /etc/tine20 as all of /etc
 throws "permission denied"

Change-Id: Icd22a199c8d9097951a347fe6acf6820007e73f7
Reviewed-on: http://gerrit.tine20.com/customers/3137
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoremove limitation for order confirmation and contract
sstamer [Fri, 6 May 2016 13:20:59 +0000 (15:20 +0200)]
remove limitation for order confirmation and contract

Change-Id: Ia6a032bfe4dd0fa456823198d841a63245e9e236
Reviewed-on: http://gerrit.tine20.com/customers/3135
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoremove unused columns
sstamer [Mon, 9 May 2016 11:46:09 +0000 (13:46 +0200)]
remove unused columns

- purchase invoice

Change-Id: I42da76db7ac28aebd54b2e9fb46637d928ae1b5b
Reviewed-on: http://gerrit.tine20.com/customers/3136
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoAdd Debitor and price net, tax, gross to invoice export
sstamer [Fri, 6 May 2016 13:00:51 +0000 (15:00 +0200)]
Add Debitor and price net, tax, gross to invoice export

Change-Id: I4365cbefe0f85940442658d595aea188951abff3
Reviewed-on: http://gerrit.tine20.com/customers/3134
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
3 years agoShow IMAP-Quota in Admin (Cyrus Backend). Setting quota is already implemented.
Johannes Nohl [Mon, 9 May 2016 01:16:42 +0000 (03:16 +0200)]
Show IMAP-Quota in Admin (Cyrus Backend). Setting quota is already implemented.

3 years agoEMClient 7 (beta) changed its user agend. CardDAV pattern as follow up to calDAV...
Johannes Nohl [Sun, 8 May 2016 18:33:10 +0000 (20:33 +0200)]
EMClient 7 (beta) changed its user agend. CardDAV pattern as follow up to calDAV changes.

3 years agoEMClient 7 (beta) changed its user agend. It also seems that limitations of earlier...
Johannes Nohl [Sat, 7 May 2016 20:09:02 +0000 (22:09 +0200)]
EMClient 7 (beta) changed its user agend. It also seems that limitations of earlier versions do not apply anymore (therefor did not merge with existing pattern file)

3 years ago11816: Show description qtip in recordPicker
sstamer [Thu, 28 Apr 2016 13:31:33 +0000 (15:31 +0200)]
11816: Show description qtip in recordPicker

https://forge.tine20.org/view.php?id=11816

Change-Id: I5a47f4b768c1a529468af7f2fe8f185b45e98e24
Reviewed-on: http://gerrit.tine20.com/customers/3111
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>