tine20
6 years agoadd inClassCache for Tinebase_Acl_Roles class
Lars Kneschke [Fri, 19 Dec 2014 21:14:32 +0000 (22:14 +0100)]
add inClassCache for Tinebase_Acl_Roles class

- read all rights of given account at once, cache them in class cache
and check for requested right in PHP

Change-Id: I8f85acf0accd16ebb32cba994887fcf212c049f4
Reviewed-on: http://gerrit.tine20.com/customers/1476
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimplemented users count function in user backend
Lars Kneschke [Mon, 29 Dec 2014 07:34:27 +0000 (08:34 +0100)]
implemented users count function in user backend

Change-Id: I5a50a45c5daefcaf71b0475a437403054e53be97
Reviewed-on: http://gerrit.tine20.com/customers/1486
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoupdated notes tests
Lars Kneschke [Mon, 22 Dec 2014 09:45:11 +0000 (10:45 +0100)]
updated notes tests

- wrapped test in transaction
- added test to get notetypes ids only

Change-Id: I3f2e6ef44ac7d918f723c08aaa7152f8e90b460e
Reviewed-on: http://gerrit.tine20.com/customers/1483
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoimprove perfomance by avoiding double cache hit
Lars Kneschke [Sat, 20 Dec 2014 22:21:54 +0000 (23:21 +0100)]
improve perfomance by avoiding double cache hit

Change-Id: I9e7b02b518cceda4db45537c563c0cb5fb85d1c3
Reviewed-on: http://gerrit.tine20.com/customers/1481
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoimproved performance of Tinebase_Notes
Lars Kneschke [Sat, 20 Dec 2014 22:19:16 +0000 (23:19 +0100)]
improved performance of Tinebase_Notes

- switched from Zend_Db_Table to Zend_Db_Select to reduce processing
time
- added support for fetching id's of note_types only

Change-Id: Iaba8c075514883ad08eb0b5f300b69eac0218a0a
Reviewed-on: http://gerrit.tine20.com/customers/1480
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoadded in class cache for Tinebase_Container
Lars Kneschke [Thu, 18 Dec 2014 12:15:28 +0000 (13:15 +0100)]
added in class cache for Tinebase_Container

Change-Id: Icd655be9c08fdef643a0ebeed4fc38399c0acc80
Reviewed-on: http://gerrit.tine20.com/customers/1465
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agorobusten code by checking variables before accessing
Philipp Schüle [Fri, 19 Dec 2014 12:18:44 +0000 (13:18 +0100)]
robusten code by checking variables before accessing

Change-Id: I73b03fddfb221d55734d6f8fd6b43c7707e32b9a
Reviewed-on: http://gerrit.tine20.com/customers/1474
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoFix 24:00 crop
sstamer [Fri, 19 Dec 2014 11:54:37 +0000 (12:54 +0100)]
Fix 24:00 crop

- don't set height to 0 if offset is 0 (24:00 = no offset)

Change-Id: If585022a0abe1d85c518bfc4370df4951af05f82
Reviewed-on: http://gerrit.tine20.com/customers/1472
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimproved performance
Lars Kneschke [Wed, 17 Dec 2014 08:09:35 +0000 (09:09 +0100)]
improved performance

- avoid multiple calls to get the same array value
- removed unused code

Change-Id: Ic6c6737a6c6f1ad850a875f130a4cec1c2dc4d98
Reviewed-on: http://gerrit.tine20.com/customers/1457
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Cornelius Weiss <c.weiss@metaways.de>
6 years agoimprove class logic
Lars Kneschke [Fri, 19 Dec 2014 08:54:53 +0000 (09:54 +0100)]
improve class logic

- avoid multiple calls to get the same variable (performance)
- avoid call to get all displayContainerIds

Change-Id: Ibf2284eef43d117cb823d9f749686d07a3a20454
Reviewed-on: http://gerrit.tine20.com/customers/1469
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadded internal class cache
Lars Kneschke [Fri, 19 Dec 2014 09:01:28 +0000 (10:01 +0100)]
added internal class cache

- avoid multiple lookup of the same data

Change-Id: I9c5f7d2e119dd617ad41fe6e3e09ef85cb78a22f
Reviewed-on: http://gerrit.tine20.com/customers/1470
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agomicro code optimization
Lars Kneschke [Fri, 19 Dec 2014 08:49:39 +0000 (09:49 +0100)]
micro code optimization

- do string conversation only when not a DateTime object

Change-Id: Ic29f4657c4b72ba6d793c2291e190bd40ef5d3e1
Reviewed-on: http://gerrit.tine20.com/customers/1468
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agofixes some variable names (ActiveSync.resetsync CLI)
Philipp Schüle [Wed, 17 Dec 2014 20:30:00 +0000 (21:30 +0100)]
fixes some variable names (ActiveSync.resetsync CLI)

Change-Id: I46c87dcde2b2c6f1a6457d78421d4cc904ef3b14
Reviewed-on: http://gerrit.tine20.com/customers/1459
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoallign checkbox style to standards
Cornelius Weiß [Thu, 18 Dec 2014 09:29:24 +0000 (10:29 +0100)]
allign checkbox style to standards

Change-Id: I631d430650714a71cb98e55bcc84d3a89e7a29f3
Reviewed-on: http://gerrit.tine20.com/customers/1460
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoWIP increase content Sequence with ldap
sstamer [Thu, 18 Dec 2014 10:04:03 +0000 (11:04 +0100)]
WIP increase content Sequence with ldap

- for now reverted

Change-Id: I40c66c87f68cf9f7555c7307f31b9acfbd297bbd
Reviewed-on: http://gerrit.tine20.com/customers/1462
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agofixes backend variable
Philipp Schüle [Mon, 15 Dec 2014 20:50:04 +0000 (21:50 +0100)]
fixes backend variable

Change-Id: Iea6f0b78f2582888d80aeed89b4797b413881c67
Reviewed-on: http://gerrit.tine20.com/customers/1452
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoFix leadstate length
Michael Spahn [Mon, 15 Dec 2014 14:50:45 +0000 (15:50 +0100)]
Fix leadstate length

Change-Id: Ib21b72fa7975964fceca6d31fc23c110fabd347c
Reviewed-on: http://gerrit.tine20.com/customers/1449
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoincrease sequence when updating user from sync Backend
sstamer [Mon, 8 Dec 2014 13:59:05 +0000 (14:59 +0100)]
increase sequence when updating user from sync Backend

and allows to configure, if user contact data should be synced

plus: renamed a function (syncContact -> createContactForSyncedUser)

Change-Id: I827dfcac287a99b72e89992a427d16e660a30ed9
Reviewed-on: http://gerrit.tine20.com/customers/1445
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010584: CLI function for resetting sync on devices
Philipp Schüle [Fri, 12 Dec 2014 10:47:21 +0000 (11:47 +0100)]
0010584: CLI function for resetting sync on devices

* allows to reset sync state for user + sync class (Calendar, Contacts,
...) via CLI
* adds a test
* moves parts of Syncroton init to ActiveSync_Controller

https://forge.tine20.org/view.php?id=10584

Change-Id: I1362fbee97c6a3cc6039233b2e23468fc846a7fb
Reviewed-on: http://gerrit.tine20.com/customers/1441
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agofill atendee cache only when needed
Lars Kneschke [Sun, 14 Dec 2014 18:26:29 +0000 (19:26 +0100)]
fill atendee cache only when needed

Change-Id: Id99d8d3ee139ca7857d6b9df6ef0ecf42d6291f2
Reviewed-on: http://gerrit.tine20.com/customers/1444
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoavoid duplicate call of isRegistered
Lars Kneschke [Fri, 12 Dec 2014 06:14:30 +0000 (07:14 +0100)]
avoid duplicate call of isRegistered

Change-Id: I2faf6597d9b52fbc643c3a03b7d7a0c51583c32e
Reviewed-on: http://gerrit.tine20.com/customers/1439
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoShort usernames script
sstamer [Thu, 30 Oct 2014 15:06:44 +0000 (16:06 +0100)]
Short usernames script

Change-Id: I9adca764fc69806933a32e943b56037e921b034b
Reviewed-on: http://gerrit.tine20.com/customers/1326
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agomake sure that caldav attachments filenames are decoded
Philipp Schüle [Mon, 8 Dec 2014 11:15:40 +0000 (12:15 +0100)]
make sure that caldav attachments filenames are decoded

* always (raw)urldecode attachment filenames before saving them in Tine
2.0 vfs
* adjusts regex for utf-8 dispositions

Change-Id: I894e53f02792c52b965133d03a39747ce4d7d4c0
Reviewed-on: http://gerrit.tine20.com/customers/1424
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010578: Fix for groups in active directory is broken
sstamer [Tue, 9 Dec 2014 15:35:27 +0000 (16:35 +0100)]
0010578: Fix for groups in active directory is broken

https://forge.tine20.org/view.php?id=10578

Change-Id: Ie72c06f612a85e34b5ffb60654ede3a61c80ae80
Reviewed-on: http://gerrit.tine20.com/customers/1432
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoChange internet access default
sstamer [Tue, 9 Dec 2014 14:54:58 +0000 (15:54 +0100)]
Change internet access default

- and translations

Change-Id: I1020c1f5f12ea23197b5cc77ce003c229ee9deca
Reviewed-on: http://gerrit.tine20.com/customers/1431
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agooptimized _checkGrants for performance
Lars Kneschke [Sun, 7 Dec 2014 13:25:52 +0000 (14:25 +0100)]
optimized _checkGrants for performance

- resultset will not be cloned any more
- needed data will stored in separate variables
- avoid unneeded function calls

Change-Id: I94cce34bdf394aab9a9df94dbb76b1ed774b9dc3
Reviewed-on: http://gerrit.tine20.com/customers/1419
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010554: create default department (school) on Courses installation
Philipp Schüle [Mon, 8 Dec 2014 10:54:20 +0000 (11:54 +0100)]
0010554: create default department (school) on Courses installation

https://forge.tine20.org/view.php?id=10554

Change-Id: Ie2dce15ec889f2738b02b623a1571a2e29abb1e6
Reviewed-on: http://gerrit.tine20.com/customers/1423
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010568: maximal username length
sstamer [Wed, 29 Oct 2014 14:38:33 +0000 (15:38 +0100)]
0010568: maximal username length

https://forge.tine20.org/view.php?id=10568

- Config optiont for max username length

Change-Id: I4d6fc19f84dc811fd3178b3546cbb3ea81aee8d5
Reviewed-on: http://gerrit.tine20.com/customers/1318
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimprove perfomance of Tinebase_Core::isLogLevel
Lars Kneschke [Mon, 8 Dec 2014 09:35:31 +0000 (10:35 +0100)]
improve perfomance of Tinebase_Core::isLogLevel

- cache value of getLogLevel in class variable
- 58 calls took 625 ms before modification
- 58 calls took  10 ms after modification

Change-Id: I3604fbdf7a9612c6cafefe79d4bc57457a743d12
Reviewed-on: http://gerrit.tine20.com/customers/1422
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agosplitted logic of container grants in to two functions
Lars Kneschke [Sun, 7 Dec 2014 13:22:07 +0000 (14:22 +0100)]
splitted logic of container grants in to two functions

- one function will return the grants only
- another one to merge the grants into resultset

Change-Id: I03aefcaa984aa7d4fa4b65d61aeb1863b951bc3a
Reviewed-on: http://gerrit.tine20.com/customers/1418
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimprove performance of Tinebase_Core::get
Lars Kneschke [Mon, 8 Dec 2014 09:28:19 +0000 (10:28 +0100)]
improve performance of Tinebase_Core::get

Zend_Registry::get calls Zend_Registry::isRegistered too and throws an
exception when the key is not registered.

Executiontime for Tinebase_Core::get is reduced by 20%.

Change-Id: I09b8457665ca2c4dce923ee6b4dd9ec8c66069c7
Reviewed-on: http://gerrit.tine20.com/customers/1421
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoattendee has to be cloned before it can be added to result set
Lars Kneschke [Sun, 7 Dec 2014 12:50:00 +0000 (13:50 +0100)]
attendee has to be cloned before it can be added to result set

Change-Id: I718fa0cae78c3ff8bf71451e75d1649ef592aa7a
Reviewed-on: http://gerrit.tine20.com/customers/1417
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agofix test testAlarmAckInRecurException
Lars Kneschke [Sat, 6 Dec 2014 03:44:08 +0000 (04:44 +0100)]
fix test testAlarmAckInRecurException

- the format of the validated string was wrong

Change-Id: I7942dbfa728cd7a967be36df33547407da41fcf5
Reviewed-on: http://gerrit.tine20.com/customers/1416
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoarray key must be scalar value
Lars Kneschke [Fri, 5 Dec 2014 23:02:32 +0000 (00:02 +0100)]
array key must be scalar value

Change-Id: I073b28a5e8a09609dd21be0f9b77cecfbc098aae
Reviewed-on: http://gerrit.tine20.com/customers/1415
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoExtend filter field for leadsource to 350px
Michael Spahn [Fri, 5 Dec 2014 10:26:58 +0000 (11:26 +0100)]
Extend filter field for leadsource to 350px

Change-Id: Ifed480726344f7d4b73954cf27db1100150cbf81
Reviewed-on: http://gerrit.tine20.com/customers/1411
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
6 years agodelay creating instance of converter until really needed
Lars Kneschke [Fri, 5 Dec 2014 06:37:55 +0000 (07:37 +0100)]
delay creating instance of converter until really needed

... to improve performance

- creating the converter instance can be avoided in many use cases

Change-Id: Iaae99edd1006b075bc60feec2fd9289b7d3c78f0
Reviewed-on: http://gerrit.tine20.com/customers/1410
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
6 years agorefactored Calendar_Model_Attender::getAttendee
Lars Kneschke [Fri, 5 Dec 2014 05:00:27 +0000 (06:00 +0100)]
refactored Calendar_Model_Attender::getAttendee

... to improve performance

- don't process empty $_attendeesSet
- avoid manipulating $_attendeesSet
- avoid calling ->filter 4 times in worst case
- stop processing as soon as possible (->filter always loops all elements in recordSet)

Change-Id: Idc02a533a1ce840a9fd513b14c7e21111f4ba023
Reviewed-on: http://gerrit.tine20.com/customers/1408
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
6 years agorefactored getGrantsOfRecords to improve performance
Lars Kneschke [Wed, 3 Dec 2014 00:07:44 +0000 (01:07 +0100)]
refactored getGrantsOfRecords to improve performance

- resolve path only once for every container
- made logic easier to understand

Change-Id: Ibe999a30a72bc4548735fb51eb6f58d6ab7485d1
Reviewed-on: http://gerrit.tine20.com/customers/1404
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agosplitted logic Calendar_Model_Attender::resolveAttendee to improve
Lars Kneschke [Fri, 5 Dec 2014 06:29:15 +0000 (07:29 +0100)]
splitted logic Calendar_Model_Attender::resolveAttendee to improve
performance

- add 2 new functions
 - to fill attendees cache
 - to return resolved attendees
- use the new function to fill attendees cache in MSEventFacade

Change-Id: I5a2a43b65b5d50e5b84d7c95e8645951f72f42dd
Reviewed-on: http://gerrit.tine20.com/customers/1409
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadds user agent to alarm ack information
Philipp Schüle [Thu, 27 Nov 2014 15:44:37 +0000 (16:44 +0100)]
adds user agent to alarm ack information

Change-Id: Ia946811a6e8d0d58383359860146a6722f32ea75
Reviewed-on: http://gerrit.tine20.com/customers/1398
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agocache parsed user-agent
Lars Kneschke [Wed, 3 Dec 2014 00:16:46 +0000 (01:16 +0100)]
cache parsed user-agent

- speed up request with multiple events, by caching parsed user-agnt to
classname mapping

Change-Id: I1cd96054abc3df0c90b9c985225f177b1ea44022
Reviewed-on: http://gerrit.tine20.com/customers/1405
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoremoved index handling
Lars Kneschke [Tue, 2 Dec 2014 16:00:13 +0000 (17:00 +0100)]
removed index handling

- slows down code execution
- was not working in all cases

closes 0007558: reactivate indices in Tinebase_Record_RecordSet
https://forge.tine20.org/view.php?id=7558

Change-Id: I67f6cbaa7bb00006006b5454473d24a02b296a1c
Reviewed-on: http://gerrit.tine20.com/customers/1403
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoremoves db config that's incompatible with pgsql
Philipp Schüle [Mon, 24 Nov 2014 19:56:20 +0000 (20:56 +0100)]
removes db config that's incompatible with pgsql

* pgsql does not like 'default' and 'not null'

SQLSTATE[42601]: Syntax error: 7 ERROR:  syntax error at or near "NULL"

Change-Id: I79b5b6814e21e5d9a4e0ff1ee22cbdb0a0beb053
Reviewed-on: http://gerrit.tine20.com/customers/1378
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agocolumn might already exist
Philipp Schüle [Mon, 24 Nov 2014 18:45:26 +0000 (19:45 +0100)]
column might already exist

Change-Id: Id2c790d1059ddbda8b4afa69383c90d3e3a07384
Reviewed-on: http://gerrit.tine20.com/customers/1377
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agochecks for existing class before calling constructor
Philipp Schüle [Mon, 24 Nov 2014 12:42:20 +0000 (13:42 +0100)]
checks for existing class before calling constructor

Change-Id: Iddb2e2ce967f9526c5af85ba9d07da68dcab066d
Reviewed-on: http://gerrit.tine20.com/customers/1374
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoNew url for bugreports script
sstamer [Mon, 10 Nov 2014 10:26:57 +0000 (11:26 +0100)]
New url for bugreports script

Change-Id: Iae4f8f9a94b2c8b56d5f9ad8faae3b8cb67d2ea5
Reviewed-on: http://gerrit.tine20.com/customers/1349
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agofixes compareCalendars: filter summary matching subset
Philipp Schüle [Mon, 17 Nov 2014 21:00:04 +0000 (22:00 +0100)]
fixes compareCalendars: filter summary matching subset

and adds a test for all day events

Change-Id: I0edf45625c25eb5a27380c105dbc2e6eb36edb16
Reviewed-on: http://gerrit.tine20.com/customers/1361
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010454: cli script for comparing calendars
Philipp Schüle [Fri, 14 Nov 2014 11:17:08 +0000 (12:17 +0100)]
0010454: cli script for comparing calendars

* ignore events only in displaycontainer

https://forge.tine20.org/view.php?id=10454

Change-Id: Ie0b42a66441bc4978b3845fa10f5a16c13d2e507
Reviewed-on: http://gerrit.tine20.com/customers/1358
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoRevert "respect deleted attendee in event search"
Philipp Schüle [Fri, 14 Nov 2014 09:45:35 +0000 (10:45 +0100)]
Revert "respect deleted attendee in event search"

-> this is wrong as it removes events with "other" deleted attendee

This reverts commit 3656ce71c238ffc3a6d3b30c842a19422a58d439.

Change-Id: I008f1b9b07c99255621450141f5e44b3183363f8
Reviewed-on: http://gerrit.tine20.com/customers/1357
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010464: cli script for repairing attendee
Philipp Schüle [Thu, 13 Nov 2014 20:52:16 +0000 (21:52 +0100)]
0010464: cli script for repairing attendee

* adds cli/controller functions and test
* adds isRecurInstance helper to event model

https://forge.tine20.org/view.php?id=10464

Change-Id: I0a2a17fe8673d88162bab63893ceb76fc6fd1787
Reviewed-on: http://gerrit.tine20.com/customers/1356
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010454: cli script for comparing calendars
Philipp Schüle [Thu, 13 Nov 2014 16:40:14 +0000 (17:40 +0100)]
0010454: cli script for comparing calendars

* adds new cli function with test
* echo report (CLI)

https://forge.tine20.org/view.php?id=10454

Change-Id: I947231097c80d1e069574fe647a63bab579ecf84
Reviewed-on: http://gerrit.tine20.com/customers/1355
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agorespect deleted attendee in event search
Philipp Schüle [Thu, 13 Nov 2014 11:20:48 +0000 (12:20 +0100)]
respect deleted attendee in event search

Change-Id: Iefb36a421ad124c694e947cbbb99fffc6b9e7ea1
Reviewed-on: http://gerrit.tine20.com/customers/1354
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010449: allow to ignore data when importing ics
Philipp Schüle [Mon, 10 Nov 2014 21:03:25 +0000 (22:03 +0100)]
0010449: allow to ignore data when importing ics

* allows to ignore alarms, attachments, attendee, ... on ics import
* improves CLI error message if import fails

https://forge.tine20.org/mantisbt/view.php?id=10449

Change-Id: I5fd775039041937bf2b5342130f0672878351c59
Reviewed-on: http://gerrit.tine20.com/customers/1351
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agolowers log level for deprecated message
Philipp Schüle [Tue, 11 Nov 2014 19:59:32 +0000 (20:59 +0100)]
lowers log level for deprecated message

Change-Id: I9ffbc1c5edda61e0c3f20850c1ce31531b589990
Reviewed-on: http://gerrit.tine20.com/customers/1352
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimproves alarmAckReport: add recurring events and show period
Philipp Schüle [Fri, 7 Nov 2014 21:12:09 +0000 (22:12 +0100)]
improves alarmAckReport: add recurring events and show period

Change-Id: Ic2ee1d2632d2959726d7122eb3e684a1966d4946
Reviewed-on: http://gerrit.tine20.com/customers/1346
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadjust function signature of fromTine20RecordSet in json converters
Philipp Schüle [Fri, 7 Nov 2014 20:49:58 +0000 (21:49 +0100)]
adjust function signature of fromTine20RecordSet in json converters

Change-Id: Ice90565ad6b5a2656a7a0a39e8b2d6fbaa8afa1e
Reviewed-on: http://gerrit.tine20.com/customers/1345
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimproves sorting and logging of deleteDuplicateEvents
Philipp Schüle [Mon, 10 Nov 2014 14:11:17 +0000 (15:11 +0100)]
improves sorting and logging of deleteDuplicateEvents

Change-Id: Ifa521a6501f2eb72939170c8696238f26dee9a92
Reviewed-on: http://gerrit.tine20.com/customers/1350
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0008364: saving phone settings should close session writing
Philipp Schüle [Fri, 7 Nov 2014 10:26:31 +0000 (11:26 +0100)]
0008364: saving phone settings should close session writing

https://forge.tine20.org/mantisbt/view.php?id=8364

Change-Id: I0d35ae9468bf564d7af499b6eea6187e9bb76133
Reviewed-on: http://gerrit.tine20.com/customers/1341
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadds index for id column of table container_content
Philipp Schüle [Fri, 7 Nov 2014 11:50:31 +0000 (12:50 +0100)]
adds index for id column of table container_content

* we detected some slow queries that used the id col in a where part

Change-Id: Ia961672b84a0e1263bf8b0cabca39ba5abc3925a
Reviewed-on: http://gerrit.tine20.com/customers/1343
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010439: require Syncroton 1.1.0
Philipp Schüle [Fri, 7 Nov 2014 15:28:48 +0000 (16:28 +0100)]
0010439: require Syncroton 1.1.0

https://forge.tine20.org/mantisbt/view.php?id=10439

Change-Id: Ie09f1c116ddd409890617e63ce047ceaaa00a91a
Reviewed-on: http://gerrit.tine20.com/customers/1344
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010435: report script for acknowledged alarms
Philipp Schüle [Thu, 6 Nov 2014 17:01:19 +0000 (18:01 +0100)]
0010435: report script for acknowledged alarms

https://forge.tine20.org/mantisbt/view.php?id=10435

Change-Id: Ie8ef63502fc25598cc4e264e375b64b424eda3ee
Reviewed-on: http://gerrit.tine20.com/customers/1338
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010433: save access log / client information when acknowledging alarm
Philipp Schüle [Thu, 6 Nov 2014 15:58:48 +0000 (16:58 +0100)]
0010433: save access log / client information when acknowledging alarm

* adds clienttype + ip to alarm options
* save current access log record in registry

https://forge.tine20.org/mantisbt/view.php?id=10433

Change-Id: I3f3d1d56ca4416f61fff63449689d031f2ab239b
Reviewed-on: http://gerrit.tine20.com/customers/1337
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoremoves sensitive information from smtp config DEBUG log
Philipp Schüle [Thu, 6 Nov 2014 11:27:17 +0000 (12:27 +0100)]
removes sensitive information from smtp config DEBUG log

Change-Id: I609f8bdd23bd2fbf8fe1d394013c118460b17860
Reviewed-on: http://gerrit.tine20.com/customers/1333
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoallows to pass params to deleteDuplicateEvents CLI fn
Philipp Schüle [Mon, 3 Nov 2014 10:04:52 +0000 (11:04 +0100)]
allows to pass params to deleteDuplicateEvents CLI fn

* and exit with return = 1 code if duplicates could be found
* improves duplicate detection

Change-Id: Ibdfbb85ef21c012fcaafc3af73fecd4f9ff3e288
Reviewed-on: http://gerrit.tine20.com/customers/1325
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010345: create synced events even if the id already exists
Philipp Schüle [Mon, 3 Nov 2014 09:20:15 +0000 (10:20 +0100)]
0010345: create synced events even if the id already exists

* adds another ics import
* reactivates test

https://forge.tine20.org/mantisbt/view.php?id=10345

Change-Id: Ibb1cd711a4394fb97a2aa916d5073374afd3eac3
Reviewed-on: http://gerrit.tine20.com/customers/1324
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agomore container query optimization
Lars Kneschke [Thu, 6 Nov 2014 17:42:31 +0000 (18:42 +0100)]
more container query optimization

Change-Id: I90b95d7f19be1461bca8bf37e0357a1fdecc337e
Reviewed-on: http://gerrit.tine20.com/customers/1339
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimproves "only id" container fetching (getContainerByACL)
Philipp Schüle [Thu, 6 Nov 2014 14:07:38 +0000 (15:07 +0100)]
improves "only id" container fetching (getContainerByACL)

Change-Id: Iffacafbd1c617f74705af559ffb48f0eb76f487f
Reviewed-on: http://gerrit.tine20.com/customers/1336
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoFelamimail_Controller_Message_Send: original_id might be an array
Philipp Schüle [Tue, 4 Nov 2014 13:54:55 +0000 (14:54 +0100)]
Felamimail_Controller_Message_Send: original_id might be an array

* handle this case and log NOTICE

Change-Id: I05d3753af21ac722c1bda1276942b7ddad4b1532
Reviewed-on: http://gerrit.tine20.com/customers/1331
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010421: could not delete resource if resource container got deleted
Philipp Schüle [Mon, 3 Nov 2014 15:19:17 +0000 (16:19 +0100)]
0010421: could not delete resource if resource container got deleted

* catch "not found" exception if container already got deleted

https://forge.tine20.org/mantisbt/view.php?id=10421

Change-Id: I3c8871ab3975c7dda608fa57c7a4c5261a22361c
Reviewed-on: http://gerrit.tine20.com/customers/1327
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010417: Exdate update doesn't update base event container content_seq
Philipp Schüle [Thu, 30 Oct 2014 14:43:48 +0000 (15:43 +0100)]
0010417: Exdate update doesn't update base event container content_seq

https://forge.tine20.org/mantisbt/view.php?id=10417

Change-Id: I3af7b458ec9b7f7b90c10ab377504f57ba735f80
Reviewed-on: http://gerrit.tine20.com/customers/1321
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Cornelius Weiss <c.weiss@metaways.de>
6 years ago0010347: fix failing tests in Sales_JsonTest (user is not resolved)
Alexander Stintzing [Wed, 29 Oct 2014 13:13:36 +0000 (14:13 +0100)]
0010347: fix failing tests in Sales_JsonTest (user is not resolved)

it looks like the user could not be resolved in some cases.
might be a modelconfig problem. we need more debugging there
to be able to fix this.

Change-Id: If07cc545140a4d6b7a7f36c0466d1608e13c42f0
Reviewed-on: http://gerrit.tine20.com/customers/1317
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agochecks if user has right for Tasks application
Philipp Schüle [Thu, 30 Oct 2014 11:03:38 +0000 (12:03 +0100)]
checks if user has right for Tasks application

... before fetching Tasks collections in getChildren()

Change-Id: I7f437a3e2bda0e1bbecf79ae87d1011d61f9c5a5
Reviewed-on: http://gerrit.tine20.com/customers/1320
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010285: CalDAV / CardDav stopped working after Koriander update
Philipp Schüle [Fri, 24 Oct 2014 15:57:09 +0000 (17:57 +0200)]
0010285: CalDAV / CardDav stopped working after Koriander update

* adds some logging when principals could not be found

https://forge.tine20.org/mantisbt/view.php?id=10285

Change-Id: Ib6f98ae093400d6896a834450860b6e079ce9cee
Reviewed-on: https://gerrit.tine20.org/tine20/2937
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago10275: Fail to intelligent add resources to an new entry
sstamer [Fri, 24 Oct 2014 12:20:40 +0000 (14:20 +0200)]
10275: Fail to intelligent add resources to an new entry

distinguish between user and resource

https://forge.tine20.org/mantisbt/view.php?id=10275

Change-Id: Ib60ba899ed1d0b398c31cdbedd3625adff7d88e4
Reviewed-on: http://gerrit.tine20.com/customers/1297
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoModelConfig: Allow to render float as money
Alexander Stintzing [Wed, 29 Oct 2014 11:28:59 +0000 (12:28 +0100)]
ModelConfig: Allow to render float as money

Change-Id: I5785659217c0820827a05b7f457b650d5003dedf
Reviewed-on: http://gerrit.tine20.com/customers/1315
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010405: adopt testAdoptAlarmTimeOfYearlyEvent
Philipp Schüle [Mon, 27 Oct 2014 10:44:10 +0000 (11:44 +0100)]
0010405: adopt testAdoptAlarmTimeOfYearlyEvent

... by setting dynamic year depending on current date

https://forge.tine20.org/mantisbt/view.php?id=10405

Change-Id: Id41337edd37af598c00a53089b529a920c2886e1
Reviewed-on: http://gerrit.tine20.com/customers/1299
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010397: Allow caldav updates for OSX 10.10 ical
Philipp Schüle [Thu, 23 Oct 2014 14:10:29 +0000 (16:10 +0200)]
0010397: Allow caldav updates for OSX 10.10 ical

* adds support for Mac OSX 10.10

https://forge.tine20.org/mantisbt/view.php?id=10397

Change-Id: I007d5ce9b24c793e1d2f1f5734a994fa121e11e1
Reviewed-on: http://gerrit.tine20.com/customers/1296
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agohandles "no user object available"-case
Philipp Schüle [Wed, 22 Oct 2014 09:52:30 +0000 (11:52 +0200)]
handles "no user object available"-case

Change-Id: If744bf424dad5a942d2342a21ac8e81cd586a85e
Reviewed-on: http://gerrit.tine20.com/customers/1293
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agouse current user as organizer with 'me' strategy
Philipp Schüle [Mon, 27 Oct 2014 10:23:11 +0000 (11:23 +0100)]
use current user as organizer with 'me' strategy

* this allows to return to the previous behavior
* AND: me-Strategy is now default

Change-Id: I5b6ada660a81eb2d9a3cd68e7e765e1bbbe17ac9
Reviewed-on: http://gerrit.tine20.com/customers/1298
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agodon't try to set turnover for empty relations
Philipp Schüle [Thu, 23 Oct 2014 08:57:53 +0000 (10:57 +0200)]
don't try to set turnover for empty relations

Change-Id: Ib907e01d3a7aa5f7283eeacc66516ef5d7dc2948
Reviewed-on: http://gerrit.tine20.com/customers/1295
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoSales: Use nicer image for costcenter
Alexander Stintzing [Wed, 22 Oct 2014 14:26:02 +0000 (16:26 +0200)]
Sales: Use nicer image for costcenter

Change-Id: I27feedcffd0876c19dd8cfced0bc114a6e706201
Reviewed-on: http://gerrit.tine20.com/customers/1294
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch 'pu/2013.10-caldav' into 2013.10
Philipp Schüle [Wed, 22 Oct 2014 08:59:53 +0000 (10:59 +0200)]
Merge branch 'pu/2013.10-caldav' into 2013.10

Conflicts:
tine20/Calendar/Backend/Sql.php
tine20/Calendar/Model/Rrule.php
tine20/Calendar/Setup/Update/Release8.php
tine20/Calendar/Setup/setup.xml

Change-Id: I0f2bba1f5200ed93f65f1956e8e965132cd1d8d2

6 years agoprevent overwriting of container name with the uuid value
Philipp Schüle [Fri, 17 Oct 2014 19:21:20 +0000 (21:21 +0200)]
prevent overwriting of container name with the uuid value

Change-Id: Ia0a8ee34762118c34323c530d49b808f0c9acf86
Reviewed-on: http://gerrit.tine20.com/customers/1283
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010383: CLI script for repairing containers
Philipp Schüle [Mon, 20 Oct 2014 09:42:04 +0000 (11:42 +0200)]
0010383: CLI script for repairing containers

* reset default names for containers with name == uuid
* call it like this:
tine20.php --method=Tinebase.repairContainerName -- locale=de
(-d for dry run)

https://forge.tine20.org/mantisbt/view.php?id=10383

Change-Id: I245e108718774747d65c05bc0c909268e5a45bb1
Reviewed-on: http://gerrit.tine20.com/customers/1284
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010365: attendee filter grid breaks
Philipp Schüle [Fri, 17 Oct 2014 08:15:06 +0000 (10:15 +0200)]
0010365: attendee filter grid breaks

* catch grid refresh exceptions

https://forge.tine20.org/mantisbt/view.php?id=10365

Change-Id: Ifa77d9c51ff913cd6338fa8886f8c339b22abcbf
Reviewed-on: http://gerrit.tine20.com/customers/1279
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoReturn keyField default
sstamer [Wed, 15 Oct 2014 10:02:26 +0000 (12:02 +0200)]
Return keyField default

Change-Id: I204557135ea3ecb7408b2fbad6216c9caf80321b
Reviewed-on: http://gerrit.tine20.com/customers/1260
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoinventory import
sstamer [Wed, 27 Aug 2014 14:56:11 +0000 (16:56 +0200)]
inventory import

- Import more fields

Change-Id: Ie1f585f0aaec7a1aab67ca6741a1cff0c9ed8e01
Reviewed-on: http://gerrit.tine20.com/customers/1069
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010198: Latest GIT breaks some Cal/CardDAV stuff
Philipp Schüle [Tue, 14 Oct 2014 14:38:08 +0000 (16:38 +0200)]
0010198: Latest GIT breaks some Cal/CardDAV stuff

* show all containers for path /<applicationPrefix>/<contactid> if
client does not support delegations

https://forge.tine20.org/mantisbt/view.php?id=10198

Change-Id: I4e772c9da1ed33721acbe29f4887c7138a557079
Reviewed-on: http://gerrit.tine20.com/customers/1259
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010345: create synced events even if the id already exists / test
Philipp Schüle [Wed, 15 Oct 2014 15:18:30 +0000 (17:18 +0200)]
0010345: create synced events even if the id already exists / test

* deactivated test

https://forge.tine20.org/mantisbt/view.php?id=10345

Change-Id: I621fa23faa1dd7e76f2a7e4aefffbc6482681caa
Reviewed-on: http://gerrit.tine20.com/customers/1269
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010355: Calendar sync not working with invalid mail credentials
Philipp Schüle [Wed, 15 Oct 2014 11:04:29 +0000 (13:04 +0200)]
0010355: Calendar sync not working with invalid mail credentials

* catch invalid credentials exceptions and reutrn empty folder list on
folder sync

https://forge.tine20.org/mantisbt/view.php?id=10355

Change-Id: If98d82f16c36d0578d0a721b6584a75d73b98a4b
Reviewed-on: http://gerrit.tine20.com/customers/1261
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoremove var_dump from test
sstamer [Wed, 15 Oct 2014 13:49:28 +0000 (15:49 +0200)]
remove var_dump from test

Change-Id: I4f090e6ed5b638ea3ea516dbb3aad8e80902eedd
Reviewed-on: http://gerrit.tine20.com/customers/1263
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago10333: loginname generating functions break Umlaute
sstamer [Wed, 8 Oct 2014 09:10:47 +0000 (11:10 +0200)]
10333: loginname generating functions break Umlaute
https://forge.tine20.org/mantisbt/view.php?id=10333

- replace specialChars before using substr

Change-Id: Ia021f8640a64ddcec38e89e9fcf8cb2ec8a2037a
Reviewed-on: http://gerrit.tine20.com/customers/1236
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010221: Updating fails due to conversion problem
Philipp Schüle [Mon, 13 Oct 2014 15:38:00 +0000 (17:38 +0200)]
0010221: Updating fails due to conversion problem

* catch Tinebase_Exception_UnexpectedValue when updating rrules

https://forge.tine20.org/mantisbt/view.php?id=10221

Change-Id: I8b35e53048425ab06eacdb2e89994c01a37af3bb
Reviewed-on: http://gerrit.tine20.com/customers/1256
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoonly update image data if different
Philipp Schüle [Mon, 13 Oct 2014 11:02:34 +0000 (13:02 +0200)]
only update image data if different

Change-Id: I10018ca70e9542fa517ddf55f66ed103634faf54
Reviewed-on: http://gerrit.tine20.com/customers/1255
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimproves Exception logging
Philipp Schüle [Fri, 10 Oct 2014 11:54:52 +0000 (13:54 +0200)]
improves Exception logging

* use same log level: ERR
* allows to pass additional data for logging via print_r)

Change-Id: I7d8366cd5f193279b7dd304609e94e5c6d9ee519
Reviewed-on: https://gerrit.tine20.org/tine20/2906
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoattachment filenames need to be (raw)urlencoded
Philipp Schüle [Fri, 10 Oct 2014 14:38:35 +0000 (16:38 +0200)]
attachment filenames need to be (raw)urlencoded

* otherwise, mac clients can't see and download them

Change-Id: If46bde36964926d4ca7910c3605fcad77379b121
Reviewed-on: http://gerrit.tine20.com/customers/1254
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0010345: create synced events even if the id already exists
Philipp Schüle [Fri, 10 Oct 2014 11:28:18 +0000 (13:28 +0200)]
0010345: create synced events even if the id already exists

create synced events even if the id already exists and the user has no
access on the other event (maybe another user already imported the same
event)

https://forge.tine20.org/mantisbt/view.php?id=10345

Change-Id: I0d5619738b1c8d55ff584494152aac809caef05b
Reviewed-on: http://gerrit.tine20.com/customers/1252
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoAdd helper clifunction to repair/set samba options
sstamer [Fri, 10 Oct 2014 09:40:06 +0000 (11:40 +0200)]
Add helper clifunction to repair/set samba options

Change-Id: I2e691ce494567e999faa21a91062b1654e0bd836
Reviewed-on: http://gerrit.tine20.com/customers/1250
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agodon't try to cache translations without config
Philipp Schüle [Thu, 9 Oct 2014 13:39:47 +0000 (15:39 +0200)]
don't try to cache translations without config

* the config system might not be ready (for example during package
building)

6 years agocheck if Tinebase is installed before accessing config
Philipp Schüle [Thu, 9 Oct 2014 12:58:52 +0000 (14:58 +0200)]
check if Tinebase is installed before accessing config

Change-Id: I3a10fdb12e58c8dda4471e53afb407f9bb81c448
Reviewed-on: http://gerrit.tine20.com/customers/1247
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>