tine20
6 years ago #9544: Improvement of application generator
Flávio Gomes da Silva Lisboa [Thu, 16 Jan 2014 13:06:12 +0000 (11:06 -0200)]
 #9544: Improvement of application generator

 - The duplicate templates were removed
 - Command can be executed from everywhere now
 - Code updated to use composer autoload

Change-Id: Ia3b7c85a02857b4a84334ae6791cd1732ebb1649
Reviewed-on: https://gerrit.tine20.org/tine20/2740
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Thu, 16 Jan 2014 20:59:46 +0000 (21:59 +0100)]
Merge branch '2013.10'

6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Thu, 16 Jan 2014 20:57:01 +0000 (21:57 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tine20/Addressbook/js/ContactEditDialog.js

6 years agoimproved logging when moving records
Philipp Schüle [Thu, 16 Jan 2014 14:41:40 +0000 (15:41 +0100)]
improved logging when moving records

Change-Id: Id4b0ec41245cca77da3892c2cf3e87fa82fcd828
Reviewed-on: https://gerrit.tine20.org/tine20/2741
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9552: improve grid update behavior
Philipp Schüle [Thu, 16 Jan 2014 14:10:23 +0000 (15:10 +0100)]
#9552: improve grid update behavior

- removes grid reload on flag change
- only shows new message notification if count changed

https://forge.tine20.org/mantisbt/view.php?id=9552

Change-Id: I5c94402632db47d80d8e009bc679c8f1f2b8ce59
Reviewed-on: https://gerrit.tine20.org/tine20/2738
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9418: copied contact is always added to selected container
Philipp Schüle [Thu, 16 Jan 2014 14:01:50 +0000 (15:01 +0100)]
#9418: copied contact is always added to selected container

- removes special container handling in contact edit dialog that
prevented the resolved container from duplicate panel to be used when
saving

https://forge.tine20.org/mantisbt/view.php?id=9418

Change-Id: I050d7a02a6c64e3c30b194e8efe0ec078bc8fceb
Reviewed-on: http://gerrit.tine20.com/customers/281
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9550: fix Sales_JsonTest.testAllCostCenterMethods
Philipp Schüle [Thu, 16 Jan 2014 09:02:43 +0000 (10:02 +0100)]
#9550: fix Sales_JsonTest.testAllCostCenterMethods

- disables the test

https://forge.tine20.org/mantisbt/view.php?id=9550

Change-Id: I4ca306209b7b0ad2823e1b2aea28c7feea51a4c6
Reviewed-on: https://gerrit.tine20.org/tine20/2737
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadd tine.vagrant vhost config
Cornelius Weiß [Wed, 15 Jan 2014 18:04:20 +0000 (19:04 +0100)]
add tine.vagrant vhost config

- tests for iCal need propper vhost config
- be able to have more than one version on one vagrant machine

Change-Id: I562080dfa4f2adabe1d8901855e1612d4e10285f
Reviewed-on: https://gerrit.tine20.org/tine20/2735
Reviewed-by: Cornelius Weiß <c.weiss@metaways.de>
Tested-by: Cornelius Weiß <c.weiss@metaways.de>
6 years agobumps version to 2013.10.4
Philipp Schüle [Wed, 15 Jan 2014 17:43:47 +0000 (18:43 +0100)]
bumps version to 2013.10.4

6 years agoMerge branch '2013.10'
Philipp Schüle [Wed, 15 Jan 2014 17:32:42 +0000 (18:32 +0100)]
Merge branch '2013.10'

6 years ago0009502: New unexcused sickness days aren't bookable as vacation days
Alexander Stintzing [Thu, 9 Jan 2014 14:30:24 +0000 (15:30 +0100)]
0009502: New unexcused sickness days aren't bookable as vacation days

When creating unexcused sickness days and trying to book
them as vacation days in one step, the panel breaks.

https://forge.tine20.org/mantisbt/view.php?id=9502

Change-Id: Id3c19d6a3128b33fad9bf876037cbd23d2114210
Reviewed-on: https://gerrit.tine20.org/tine20/2706
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009528: fix concurrency handling in CalDAV Frontend
Cornelius Weiß [Wed, 15 Jan 2014 17:06:01 +0000 (18:06 +0100)]
0009528: fix concurrency handling in CalDAV Frontend

- sequence based eTag
- removes exdate+attendee+timestamp based handling

https://forge.tine20.org/mantisbt/view.php?id=9528

Change-Id: I7073ffcf5edb99e4ff5608ff1cdfc9b5086e43d2
Reviewed-on: https://gerrit.tine20.org/tine20/2724
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9314: validation error is not cleared, no saving possible
Philipp Schüle [Wed, 15 Jan 2014 14:41:32 +0000 (15:41 +0100)]
#9314: validation error is not cleared, no saving possible

- sets this.saving flag to false after validation error

https://forge.tine20.org/mantisbt/view.php?id=9314

Change-Id: I202b98551e462629d33733c2146e285382b52a2c
Reviewed-on: https://gerrit.tine20.org/tine20/2733
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9348: don't show zero counts in edit dialog
Philipp Schüle [Wed, 15 Jan 2014 15:16:00 +0000 (16:16 +0100)]
#9348: don't show zero counts in edit dialog

- shows counts according to the styleguide
- fixes tags count for new records

https://forge.tine20.org/mantisbt/view.php?id=9348

Change-Id: I47ce30f7a2ae1ef0d7e462a53a955207026920d7
Reviewed-on: https://gerrit.tine20.org/tine20/2734
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009528: fix concurrency handling in CalDAV Frontend
Cornelius Weiß [Wed, 15 Jan 2014 13:42:21 +0000 (14:42 +0100)]
0009528: fix concurrency handling in CalDAV Frontend

- start sequence with 1 like the clients do
- take modlog properties from existing records
  when updateing from xDAV cause concurrency
  is prevented by etags

https://forge.tine20.org/mantisbt/view.php?id=9528

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c7a
Reviewed-on: https://gerrit.tine20.org/tine20/2718
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009520: update transifex strings and translations
Philipp Schüle [Wed, 15 Jan 2014 14:35:14 +0000 (15:35 +0100)]
0009520: update transifex strings and translations

6 years ago0009520: update transifex strings and translations
Philipp Schüle [Wed, 15 Jan 2014 13:58:26 +0000 (14:58 +0100)]
0009520: update transifex strings and translations

6 years agoMerge branch '2013.10'
Philipp Schüle [Wed, 15 Jan 2014 13:21:09 +0000 (14:21 +0100)]
Merge branch '2013.10'

Conflicts:
tine20/build.xml

6 years ago#9510: is it allowed to have no main vevent in ics?
Philipp Schüle [Wed, 15 Jan 2014 11:02:47 +0000 (12:02 +0100)]
#9510: is it allowed to have no main vevent in ics?

- answer: yes! see test testAcceptInvitationForRecurringEventException
- removes exception in converter that was thrown when main vevent was
missing

https://forge.tine20.org/mantisbt/view.php?id=9510

Change-Id: I886ab5438a2d0ea413c6b453a3183f3405d65f62
Reviewed-on: https://gerrit.tine20.org/tine20/2727
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9412: event loses saved relations on reload
Philipp Schüle [Wed, 15 Jan 2014 11:14:37 +0000 (12:14 +0100)]
#9412: event loses saved relations on reload

- removes relations panel from event edit dialog
- adds debug log to relations panel init fn

https://forge.tine20.org/mantisbt/view.php?id=9412

Change-Id: I6f4130cbd5989b10ba2c9b15f93c7f3851a72bc3
Reviewed-on: https://gerrit.tine20.org/tine20/2728
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadd alarm demo data for em-client
Cornelius Weiß [Mon, 6 Jan 2014 13:58:13 +0000 (14:58 +0100)]
add alarm demo data for em-client

- add basic tests
- demodata thanks to tomp at topanet dot de

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c7f
Reviewed-on: https://gerrit.tine20.org/tine20/2697
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoremove ununsed filter
Cornelius Weiß [Tue, 14 Jan 2014 18:24:07 +0000 (19:24 +0100)]
remove ununsed filter

Change-Id: I8a02c8b4b76c83ddba2926a42f9abc4e1646d91b
Reviewed-on: https://gerrit.tine20.org/tine20/2725
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoencode folder name when calling appendMessage()
Philipp Schüle [Sun, 12 Jan 2014 16:10:58 +0000 (17:10 +0100)]
encode folder name when calling appendMessage()

see https://www.tine20.org/forum/viewtopic.php?f=12&t=15718

Change-Id: Iefaae248e901df4acb8b1a3ad48efa6cd7177fa7
Reviewed-on: https://gerrit.tine20.org/tine20/2715
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agodon't use github api for composer
Cornelius Weiß [Tue, 14 Jan 2014 11:33:49 +0000 (12:33 +0100)]
don't use github api for composer

circumvent github access limits

Change-Id: I7073ffcf5edb99e4ff5608ff1cdfc9b5086e43ef
Reviewed-on: https://gerrit.tine20.org/tine20/2723
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoupdate to latest puphpet version
Cornelius Weiß [Mon, 13 Jan 2014 14:08:29 +0000 (15:08 +0100)]
update to latest puphpet version

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c9f
Reviewed-on: https://gerrit.tine20.org/tine20/2720
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Cornelius Weiß <c.weiss@metaways.de>
Tested-by: Cornelius Weiß <c.weiss@metaways.de>
6 years ago0009530: Firefox does not show tags and notes count in edit dialog
Alexander Stintzing [Mon, 13 Jan 2014 10:57:10 +0000 (11:57 +0100)]
0009530: Firefox does not show tags and notes count in edit dialog

Firefox does not show tags and notes count in edit dialog

https://forge.tine20.org/mantisbt/view.php?id=9530

Change-Id: I7073ffcf5edb99e4ff5608ff1cdfc9b5086e43cf
Reviewed-on: https://gerrit.tine20.org/tine20/2719
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Mon, 13 Jan 2014 10:24:40 +0000 (11:24 +0100)]
Merge branch '2013.10'

6 years ago#9524: save ack and snooze in alarm
Cornelius Weiß [Mon, 13 Jan 2014 09:58:05 +0000 (10:58 +0100)]
#9524: save ack and snooze in alarm

- save ack & snooze as option in alarm
- allow all users to save ack & snooze
- migrate old ack/snooze settings from attendee to alarms

https://forge.tine20.org/mantisbt/view.php?id=9524

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c8f
Reviewed-on: https://gerrit.tine20.org/tine20/2698
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9480: missing translation for 'Datei'
Philipp Schüle [Mon, 13 Jan 2014 09:30:56 +0000 (10:30 +0100)]
#9480: missing translation for 'Datei'

- fixed file upload / attachment grid i18n file string handling

https://forge.tine20.org/mantisbt/view.php?id=9480

Change-Id: I4154e66f7136698580104224ca6b62dd8e0225a7
Reviewed-on: https://gerrit.tine20.org/tine20/2717
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agohandle empty exception data
Philipp Schüle [Mon, 13 Jan 2014 09:04:05 +0000 (10:04 +0100)]
handle empty exception data

Change-Id: I725b7ef456d4d0702c4d15f10a7b0e12fc2001f5
Reviewed-on: https://gerrit.tine20.org/tine20/2716
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadded some logging when trying to delete customfield
Philipp Schüle [Sat, 11 Jan 2014 18:16:29 +0000 (19:16 +0100)]
added some logging when trying to delete customfield

Change-Id: Idbce8cdf057f9165d27f301adcd59f8b940e3dad
Reviewed-on: https://gerrit.tine20.org/tine20/2714
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Sat, 11 Jan 2014 17:43:34 +0000 (18:43 +0100)]
Merge branch '2013.10'

6 years ago#9522: update htmlpurifier to 4.6.0
Philipp Schüle [Fri, 10 Jan 2014 16:20:21 +0000 (17:20 +0100)]
#9522: update htmlpurifier to 4.6.0

- composer update ezyang/htmlpurifier

https://forge.tine20.org/mantisbt/view.php?id=9522

Change-Id: I5c410300b581b6828506c96d890d179663beb340
Reviewed-on: https://gerrit.tine20.org/tine20/2711
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago# 9440: IP in logfile
Lars Kneschke [Fri, 10 Jan 2014 16:13:23 +0000 (17:13 +0100)]
# 9440: IP in logfile

https://forge.tine20.org/mantisbt/view.php?id=9440

Change-Id: I677edbe8ec92ca7ea0ff3f9c4ef5cca756cb427d
Reviewed-on: https://gerrit.tine20.org/tine20/2712
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Fri, 10 Jan 2014 16:04:35 +0000 (17:04 +0100)]
Merge branch '2013.10'

6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Fri, 10 Jan 2014 16:03:11 +0000 (17:03 +0100)]
Merge branch '2013.03' into 2013.10

6 years agoimproved sikuli test case (login/logout)
Philipp Schüle [Fri, 10 Jan 2014 13:32:13 +0000 (14:32 +0100)]
improved sikuli test case (login/logout)

- uses Chromium class for simple browser management
- adds logout
- imports unittest
- uses testsuite

Change-Id: I3db9395b54ab3ef9201463048ba31ec38fdc4983
Reviewed-on: https://gerrit.tine20.org/tine20/2710
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#3730: support CONDSTORE extension for quick flag sync
Emerson Faria Nobre [Fri, 10 Jan 2014 13:30:46 +0000 (14:30 +0100)]
#3730: support CONDSTORE extension for quick flag sync

- Expresso#7182
- adds new modseq and support_condstore field to folder record
- always check flags change if condstore is supported on cache update
- client now reloads the grid if flags have changed

https://forge.tine20.org/mantisbt/view.php?id=3730

Change-Id: Icf7840fe73ce29bb4ba0fd1fa2e8dd39310553eb
Reviewed-on: https://gerrit.tine20.org/tine20/2647
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#4169: reduce memory consumption when sending message
Philipp Schüle [Fri, 10 Jan 2014 14:32:16 +0000 (15:32 +0100)]
#4169: reduce memory consumption when sending message

- allow to configure logging in Zend_Mail_Protocol_Abstract
- disabled logging in Zend_Mail_Protocol by default
- enable logging in one test for checking smtp log

https://forge.tine20.org/mantisbt/view.php?id=4169

Change-Id: Ib2b709ab53a696de176a4ae3211370e4e5d08b3a
Reviewed-on: http://gerrit.tine20.com/customers/261
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Fri, 10 Jan 2014 14:04:56 +0000 (15:04 +0100)]
Merge branch '2013.10'

Conflicts:
tine20/HumanResources/translations/de.po
tine20/HumanResources/translations/template.pot

6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Fri, 10 Jan 2014 14:03:05 +0000 (15:03 +0100)]
Merge branch '2013.03' into 2013.10

6 years ago0009496: HR Account calculates wrong working hours
Alexander Stintzing [Thu, 9 Jan 2014 12:49:48 +0000 (13:49 +0100)]
0009496: HR Account calculates wrong working hours

- HR Account calculates wrong working hours.
- shows real working days/hours (minus sickness/vacation)

https://forge.tine20.org/mantisbt/view.php?id=9496

Change-Id: Iaa4f5d1dfabb4d9c2f5b2e3a727de42565c9da8d
Reviewed-on: https://gerrit.tine20.org/tine20/2705
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9500 add note buttons missing in edit dialog
sstamer [Fri, 10 Jan 2014 09:36:39 +0000 (10:36 +0100)]
#9500 add note buttons missing in edit dialog

- add note buttons missing in edit dialog

Change-Id: I5efcc040fc992a7daaa90b35ada02f53b1e4c8ab
Reviewed-on: https://gerrit.tine20.org/tine20/2709
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#8230: added alarm to event on iOS 6.1 -> description removed
Philipp Schüle [Thu, 9 Jan 2014 20:58:00 +0000 (21:58 +0100)]
#8230: added alarm to event on iOS 6.1 -> description removed

- do not remove event description if missing from AS xml request (only
when device is an iPhone)
- this is only a quick fix for the problem. we should implemented
"ghosted properties" as suggested in the mantis task

https://forge.tine20.org/mantisbt/view.php?id=8230

Change-Id: Iaeb1c7e693aa909bcf7258b533cf34980a807450
Reviewed-on: https://gerrit.tine20.org/tine20/2707
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9512: preserve windowNameConnection files in package
Philipp Schüle [Thu, 9 Jan 2014 20:08:53 +0000 (21:08 +0100)]
#9512: preserve windowNameConnection files in package

https://forge.tine20.org/mantisbt/view.php?id=9512

Change-Id: Idbcd4c60607516d60564d6a9a1abcc681cfab4e9
Reviewed-on: http://gerrit.tine20.com/customers/276
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Thu, 9 Jan 2014 19:58:48 +0000 (20:58 +0100)]
Merge branch '2013.10'

6 years ago#9510: is it allowed to have no main vevent in ics?
Philipp Schüle [Thu, 9 Jan 2014 19:55:26 +0000 (20:55 +0100)]
#9510: is it allowed to have no main vevent in ics?

- disables test and adds some comments

https://forge.tine20.org/mantisbt/view.php?id=9510

6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Thu, 9 Jan 2014 19:41:43 +0000 (20:41 +0100)]
Merge branch '2013.03' into 2013.10

6 years agoinitialize $baseVevent variable
Philipp Schüle [Thu, 9 Jan 2014 19:41:05 +0000 (20:41 +0100)]
initialize $baseVevent variable

6 years agoMerge branch '2013.10'
Philipp Schüle [Thu, 9 Jan 2014 14:25:23 +0000 (15:25 +0100)]
Merge branch '2013.10'

Conflicts:
tests/tine20/Calendar/Controller/MSEventFacadeTest.php
tests/tine20/Calendar/TestCase.php

6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Thu, 9 Jan 2014 14:20:41 +0000 (15:20 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tests/tine20/Calendar/Controller/MSEventFacadeTest.php
tests/tine20/Calendar/TestCase.php
tine20/Calendar/Controller/MSEventFacade.php
tine20/Calendar/Convert/Event/VCalendar/Abstract.php
tine20/Tinebase/ActionQueue.php
tine20/Tinebase/js/widgets/form/RecordPickerComboBox.js

6 years ago#9396: alarm_ack_time and alarm_snooze_time are not updated
Philipp Schüle [Wed, 8 Jan 2014 17:15:08 +0000 (18:15 +0100)]
#9396: alarm_ack_time and alarm_snooze_time are not updated

- adds tests for mseventfacade and vcalendar converter
- moz ack+snooze properties need to be passed to exdates (converter)
- some minor improvements

https://forge.tine20.org/mantisbt/view.php?id=9396

Change-Id: Ic37f4a94acab6f437ee80f452ab498711513f147
Reviewed-on: http://gerrit.tine20.com/customers/234
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9498: improve sorting of contacts in attendee picker grid
Philipp Schüle [Thu, 9 Jan 2014 13:47:24 +0000 (14:47 +0100)]
#9498: improve sorting of contacts in attendee picker grid

improves attendee picker combo sorting:
- sort contacts by type (users first)
- sort groups/resources by name

introduces sortDir config in RecordPickerComboBox

https://forge.tine20.org/mantisbt/view.php?id=9498

Change-Id: Ifa5cca4722d5df3b06ba3167ef1cae3e542203b8
Reviewed-on: http://gerrit.tine20.com/customers/274
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agofixed wrong message/action param handling
Philipp Schüle [Thu, 4 Jul 2013 15:00:03 +0000 (17:00 +0200)]
fixed wrong message/action param handling

6 years agofix failing test HRFrontend_Json::testCalculation
Alexander Stintzing [Thu, 9 Jan 2014 11:45:04 +0000 (12:45 +0100)]
fix failing test HRFrontend_Json::testCalculation

... after year change

Change-Id: I103f0c48228ae0cf6da5b6f2c42d96f4ebdeb9d4
Reviewed-on: https://gerrit.tine20.org/tine20/2704
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Thu, 9 Jan 2014 11:08:17 +0000 (12:08 +0100)]
Merge branch '2013.10'

6 years ago0009494: improve count sql query
Lars Kneschke [Thu, 9 Jan 2014 09:43:00 +0000 (10:43 +0100)]
0009494: improve count sql query

- completes commit 62f508e0cef90e0519a6c2cf497b55c2bced8951
- removes obsolete useSubselectForCount and preserve options
- adds timesheet totalsum(billable) test

https://forge.tine20.org/mantisbt/view.php?id=9494

Change-Id: I98ae309ec8b6c003b00db72b4f63c0176606872a
Reviewed-on: https://gerrit.tine20.org/tine20/2703
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agotemporarly disabled testCalculation
Philipp Schüle [Thu, 9 Jan 2014 11:05:16 +0000 (12:05 +0100)]
temporarly disabled testCalculation

6 years agoadd missing duration filter and fix format of search filter
Lars Kneschke [Wed, 8 Jan 2014 21:16:41 +0000 (22:16 +0100)]
add missing duration filter and fix format of search filter

- the duration(not defined) and account_id(wrong syntax) filter got
ignored during the test

Change-Id: Ia74a2c7d5ec610424efecfe5adbf066e6171d422
Reviewed-on: https://gerrit.tine20.org/tine20/2702
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years ago0009262: Import Calender fails
Philipp Schüle [Mon, 18 Nov 2013 10:19:06 +0000 (11:19 +0100)]
0009262: Import Calender fails

- log ics parse errors during import

https://forge.tine20.org/mantisbt/view.php?id=9262

Change-Id: Id7a22dfef861e4506460d3e5915cea4ae5f27385
Reviewed-on: https://gerrit.tine20.org/tine20/2555
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009476: Datepicker switches to january on changing the year
Alexander Stintzing [Tue, 7 Jan 2014 16:16:24 +0000 (17:16 +0100)]
0009476: Datepicker switches to january on changing the year

When browsing the calendar nested into the freetime edit dialog,
the calendar always switches to january on year change.

https://forge.tine20.org/mantisbt/view.php?id=9476

Change-Id: I01c75f4ee8aa8b122f91471cea952cdffc7baa4b
Reviewed-on: https://gerrit.tine20.org/tine20/2701
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Tue, 7 Jan 2014 16:28:47 +0000 (17:28 +0100)]
Merge branch '2013.10'

6 years agoAllows CardDAV clients to submit company addresses only
Ingo Ratsdorf [Tue, 7 Jan 2014 08:20:44 +0000 (21:20 +1300)]
Allows CardDAV clients to submit company addresses only

- Tine20 allows company addresses to be saved without first or last name
attached to it. This will fix CardDAV support for this feature

Change-Id: Ieb6af0d9fc89e896db3bccf098870d97521094e8
Reviewed-on: https://gerrit.tine20.org/tine20/2700
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009486: Month filter "date after" fails
Alexander Stintzing [Mon, 6 Jan 2014 16:18:35 +0000 (17:18 +0100)]
0009486: Month filter "date after" fails

When searching after the last day of a month,
the month itself is shown also, but shouldn't.

https://forge.tine20.org/mantisbt/view.php?id=9486

Change-Id: Ib90257a6d9e36a470122ec0998df4dd6b716f186
Reviewed-on: https://gerrit.tine20.org/tine20/2699
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Mon, 6 Jan 2014 16:41:34 +0000 (17:41 +0100)]
Merge branch '2013.10'

6 years agoMerge branch 'pu/2013.10-longrun'
Philipp Schüle [Mon, 6 Jan 2014 16:41:27 +0000 (17:41 +0100)]
Merge branch 'pu/2013.10-longrun'

6 years ago#6752: ci ldap tests
Philipp Schüle [Mon, 6 Jan 2014 15:22:01 +0000 (16:22 +0100)]
#6752: ci ldap tests

- fixed / updated some tests to make them capable of handling different
test user names, ldap ids and so on
- removed some obsolete code
- moved some more code to generic TestCase

https://forge.tine20.org/mantisbt/view.php?id=6752

Change-Id: I333b6fa044abd232e7294a8eca14247278d01645
Reviewed-on: https://gerrit.tine20.org/tine20/2690
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadd description field to hr-account
Alexander Stintzing [Mon, 6 Jan 2014 10:07:23 +0000 (11:07 +0100)]
add description field to hr-account

Change-Id: I9857e9fdbfede69412ec5ed7341155caa9f3ba22
Reviewed-on: https://gerrit.tine20.org/tine20/2696
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009470: Alarms from Mavericks (OSX 10.9) are not saved
Cornelius Weiß [Fri, 3 Jan 2014 12:35:46 +0000 (13:35 +0100)]
0009470: Alarms from Mavericks (OSX 10.9) are not saved

- Support TRIGGER:-PT15M
=> DURATION without VALUE parameter

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c6f
Reviewed-on: https://gerrit.tine20.org/tine20/2692
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009476: Datepicker switches to january on changing the year
Alexander Stintzing [Fri, 3 Jan 2014 13:34:23 +0000 (14:34 +0100)]
0009476: Datepicker switches to january on changing the year

When browsing the calendar nested into the freetime edit dialog,
the calendar always switches to january on year change.

requires: 0009472: Editing vacation days from last year fails

https://forge.tine20.org/mantisbt/view.php?id=9476

Change-Id: I66fb7daa5515699fc02a70c0fd2bb21028070477
Reviewed-on: https://gerrit.tine20.org/tine20/2695
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009472: Editing vacation days from last year fails
Alexander Stintzing [Fri, 3 Jan 2014 12:36:33 +0000 (13:36 +0100)]
0009472: Editing vacation days from last year fails

Editing vacation days from last year fails. On opening
the message "Year can not be changed" is shown

https://forge.tine20.org/mantisbt/view.php?id=9472

Change-Id: If4e3b4d20adb66698ed0d4c0261829b0aa2926d3
Reviewed-on: https://gerrit.tine20.org/tine20/2693
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009474: Extra vacation grid does not sort
Alexander Stintzing [Fri, 3 Jan 2014 12:54:48 +0000 (13:54 +0100)]
0009474: Extra vacation grid does not sort

Extra vacation grid does not sort but shows
"Method not found" message - should sort locally

https://forge.tine20.org/mantisbt/view.php?id=9474

Change-Id: I07753affc550943ed1ab621c58664dd5a7d5bcb5
Reviewed-on: https://gerrit.tine20.org/tine20/2694
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10' into pu/2013.10-longrun
Philipp Schüle [Mon, 6 Jan 2014 11:08:41 +0000 (12:08 +0100)]
Merge branch '2013.10' into pu/2013.10-longrun

Conflicts:
tine20/Tinebase/Convert/Json.php
tine20/Tinebase/ModelConfiguration.php

6 years agofix HR tests
Lars Kneschke [Thu, 2 Jan 2014 19:05:35 +0000 (20:05 +0100)]
fix HR tests

- use current year for filter
- don't read contact, as all information are stored in account already

Change-Id: I279a9097c1b15086bc8d6e93444144d3523a3451
Reviewed-on: https://gerrit.tine20.org/tine20/2691
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Fri, 27 Dec 2013 19:41:55 +0000 (20:41 +0100)]
Merge branch '2013.10'

6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Fri, 27 Dec 2013 19:40:36 +0000 (20:40 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tests/tine20/Calendar/RruleTests.php

6 years ago#9462: endless loop in Calendar_Controller_Event::adoptAlarmTime
Philipp Schüle [Fri, 27 Dec 2013 12:07:22 +0000 (13:07 +0100)]
#9462: endless loop in Calendar_Controller_Event::adoptAlarmTime

- adds test case
- adoptAlarmTime by instance // calculate from in usertime
  as otherwise time shifts due to DST changes may lead
  to wrong results

https://forge.tine20.org/mantisbt/view.php?id=9462

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c5f
Reviewed-on: http://gerrit.tine20.com/customers/259
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9458: allow to configure number of alarms
Philipp Schüle [Fri, 27 Dec 2013 14:33:14 +0000 (15:33 +0100)]
#9458: allow to configure number of alarms

- default is 100 alarm notifications for earch run of
sendPendingAlarms

https://forge.tine20.org/mantisbt/view.php?id=9458

Change-Id: Ia425e948c69755695e57f3087e54aa768e1e74a1
Reviewed-on: http://gerrit.tine20.com/customers/257
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9464: user grid does not refresh after ctx menu action
Philipp Schüle [Fri, 27 Dec 2013 14:12:42 +0000 (15:12 +0100)]
#9464: user grid does not refresh after ctx menu action

- as Users have no modlog yet, we have to make sure that the grid is
updated correctly after a record has changed

https://forge.tine20.org/mantisbt/view.php?id=9464

Change-Id: Ia3594409b856d417e2f4f1979f75afcb1d0a9ce1
Reviewed-on: http://gerrit.tine20.com/customers/260
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009320: Wrong notification on first occurrence exceptions
Cornelius Weiß [Fri, 27 Dec 2013 12:38:15 +0000 (13:38 +0100)]
0009320: Wrong notification on first occurrence exceptions

- ensure [start,end[ definition of getNextOccurence for baseEvents
  for WEEKLY events with BTDAY definition

Reviewed-on: https://gerrit.tine20.org/tine20/2648
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Conflicts:
tests/tine20/Calendar/Controller/EventTests.php
tests/tine20/Calendar/Export/ICalTest.php
tests/tine20/Calendar/RruleTests.php
tine20/Calendar/Model/Rrule.php

Change-Id: I74ab79c21a170db219caf6355838409df3c29caa
Reviewed-on: http://gerrit.tine20.com/customers/258
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Thu, 26 Dec 2013 21:46:09 +0000 (22:46 +0100)]
Merge branch '2013.10'

6 years agouse configured email addresses to avoid tests failing because of SMTP
Lars Kneschke [Thu, 26 Dec 2013 09:02:56 +0000 (10:02 +0100)]
use configured email addresses to avoid tests failing because of SMTP
errors

Change-Id: I0c417f000ed2891162b0738a6e286e14d5c98011
Reviewed-on: https://gerrit.tine20.org/tine20/2688
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago #9452: Enabling Tine 2.0 for working with transaction pooling level of PgBouncer
Flávio Gomes da Silva Lisboa [Mon, 23 Dec 2013 17:59:03 +0000 (15:59 -0200)]
 #9452: Enabling Tine 2.0 for working with transaction pooling level of PgBouncer

Change-Id: Ib1b0749a4904562648ae1a78667c356ed27d0cf1
Reviewed-on: https://gerrit.tine20.org/tine20/2685
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Mon, 23 Dec 2013 20:07:12 +0000 (21:07 +0100)]
Merge branch '2013.10'

6 years agoMerge branch 'pu/2013.10-longrun'
Philipp Schüle [Mon, 23 Dec 2013 20:06:43 +0000 (21:06 +0100)]
Merge branch 'pu/2013.10-longrun'

Conflicts:
tine20/Tinebase/ModelConfiguration.php

6 years ago#9450: allow to delete container without the required grants
Philipp Schüle [Mon, 23 Dec 2013 17:11:27 +0000 (18:11 +0100)]
#9450: allow to delete container without the required grants

https://forge.tine20.org/mantisbt/view.php?id=9450

Change-Id: I1991272886de6d1e2e9369250fd110ab770063b5
Reviewed-on: https://gerrit.tine20.org/tine20/2684
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agobetter resolving of dependent records when using modelconfig
Alexander Stintzing [Mon, 23 Dec 2013 15:59:56 +0000 (16:59 +0100)]
better resolving of dependent records when using modelconfig

Change-Id: Ibf16bca26acfa3fbc37e74f7c1013b7e6a7e1a8a
Reviewed-on: https://gerrit.tine20.org/tine20/2683
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agooptimize Tinebase_Record_Abstract::_hasToArray
Paul Mehrer [Sun, 22 Dec 2013 14:20:07 +0000 (15:20 +0100)]
optimize Tinebase_Record_Abstract::_hasToArray

as most properties are no objects, the old logic called is_object twice, it just stacks over time! Also a call to in_array AND class_implements is slower than just one call to method_exists.

For showing a list of 50 addressbook entries this saves around 50-60ms while xhprof being turned on on my local machine

Change-Id: I675b342c02c101ce0eb4cec9f2fe080f10ab05fa
Reviewed-on: https://gerrit.tine20.org/tine20/2677
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agooptimizing Tinebase_Record_Abstract::_convertDateTimeToString
Paul Mehrer [Sun, 22 Dec 2013 16:17:59 +0000 (17:17 +0100)]
optimizing Tinebase_Record_Abstract::_convertDateTimeToString

$value often evalutes to false, by rearranging the if statements calls to instanceof and is_array can be skipped for $value == false

Change-Id: I419b0d1dc79467b940163691e3616398d1faed4d
Reviewed-on: https://gerrit.tine20.org/tine20/2678
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agooptimizing Tinebase_Record_Abstract::setTimezone
Paul Mehrer [Sun, 22 Dec 2013 18:25:02 +0000 (19:25 +0100)]
optimizing Tinebase_Record_Abstract::setTimezone

iterates over all properties and checks for is_object. Amount of is_object calls can be reduced by first evaluating for true. Approx. halfs the is_object calls.

Change-Id: I78219b3395d7107d1f53602dfa3e2447fc1b9dc5
Reviewed-on: https://gerrit.tine20.org/tine20/2679
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoTinebase_Core::getLogLevel
Paul Mehrer [Sun, 22 Dec 2013 18:44:20 +0000 (19:44 +0100)]
Tinebase_Core::getLogLevel

self::get was called twice without sense. Now its being called only once. This can be up to 150 calls for Addressbook.searchContacts for example, easily an other 5ms.

Change-Id: Id6d8f4af77a3c2f48d57bc4841be639b8c08e73d
Reviewed-on: https://gerrit.tine20.org/tine20/2680
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.10'
Philipp Schüle [Mon, 23 Dec 2013 10:18:38 +0000 (11:18 +0100)]
Merge branch '2013.10'

6 years agoTinebase_Core::getLogLevel
Paul Mehrer [Sun, 22 Dec 2013 18:44:20 +0000 (19:44 +0100)]
Tinebase_Core::getLogLevel

self::get was called twice without sense. Now its being called only once. This can be up to 150 calls for Addressbook.searchContacts for example, easily an other 5ms.

Change-Id: Id6d8f4af77a3c2f48d57bc4841be639b8c08e73d
Reviewed-on: https://gerrit.tine20.org/tine20/2680
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agooptimizing Tinebase_Record_Abstract::setTimezone
Paul Mehrer [Sun, 22 Dec 2013 18:25:02 +0000 (19:25 +0100)]
optimizing Tinebase_Record_Abstract::setTimezone

iterates over all properties and checks for is_object. Amount of is_object calls can be reduced by first evaluating for true. Approx. halfs the is_object calls.

Change-Id: I78219b3395d7107d1f53602dfa3e2447fc1b9dc5
Reviewed-on: https://gerrit.tine20.org/tine20/2679
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agooptimizing Tinebase_Record_Abstract::_convertDateTimeToString
Paul Mehrer [Sun, 22 Dec 2013 16:17:59 +0000 (17:17 +0100)]
optimizing Tinebase_Record_Abstract::_convertDateTimeToString

$value often evalutes to false, by rearranging the if statements calls to instanceof and is_array can be skipped for $value == false

Change-Id: I419b0d1dc79467b940163691e3616398d1faed4d
Reviewed-on: https://gerrit.tine20.org/tine20/2678
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agooptimize Tinebase_Record_Abstract::_hasToArray
Paul Mehrer [Sun, 22 Dec 2013 14:20:07 +0000 (15:20 +0100)]
optimize Tinebase_Record_Abstract::_hasToArray

as most properties are no objects, the old logic called is_object twice, it just stacks over time! Also a call to in_array AND class_implements is slower than just one call to method_exists.

For showing a list of 50 addressbook entries this saves around 50-60ms while xhprof being turned on on my local machine

Change-Id: I675b342c02c101ce0eb4cec9f2fe080f10ab05fa
Reviewed-on: https://gerrit.tine20.org/tine20/2677
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agounnecessary query
Paul Mehrer [Sun, 22 Dec 2013 13:43:20 +0000 (14:43 +0100)]
unnecessary query

tine20/Tinebase/Backend/Sql/Abstract.php - search() selects ids first and then eventually makes a second query to fetch all the columns. Added logic to determin wether there is a difference in the joins of the first query vs. the second query. If first and second query are using the same joins, there is no sense in doing both queries. In that case now only one query will be performed. If there is a difference in the joins, then the logic as is will be executed.

Change-Id: Ib93584661ee1021c868a189603c79a50d16f3db5
Reviewed-on: https://gerrit.tine20.org/tine20/2627
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#7686: show container name in contact grid
Philipp Schüle [Fri, 20 Dec 2013 19:47:43 +0000 (20:47 +0100)]
#7686: show container name in contact grid

- adds container renderer to Addressbook

https://forge.tine20.org/mantisbt/view.php?id=7686

Change-Id: I987c59a0f71831051b4db8d61d5ba7b3e15e7e01
Reviewed-on: https://gerrit.tine20.org/tine20/2676
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoimprove count sql query
Lars Kneschke [Fri, 20 Dec 2013 13:08:47 +0000 (14:08 +0100)]
improve count sql query

Change-Id: I100f6178d6f57d6dd70c83e702d2625326a5f258
Reviewed-on: https://gerrit.tine20.org/tine20/2675
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Fri, 20 Dec 2013 13:12:11 +0000 (14:12 +0100)]
Merge branch '2013.03' into 2013.10