Philipp Schüle [Wed, 4 Feb 2015 16:56:49 +0000 (17:56 +0100)]
skips already deleted exdates during event update
* adds a new param skipMissing to
Tinebase_Record_RecordSet::setByIndices()
Change-Id: I6f986395011a91deb73e898ed62f213eedb12bf9
Reviewed-on: http://gerrit.tine20.com/customers/1609
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Wed, 18 Feb 2015 16:34:05 +0000 (17:34 +0100)]
Revert "0010834: defining a key-value costumfield breaks addressbook"
-> this is only needed with the registry changes introduced in pu/2013.10-mailto
This reverts commit
6ee7095ff75780e97425011642b315cdb5b4024a.
Change-Id: I7205d027979ac989fe3ff4e57165e60c46b0353b
Reviewed-on: http://gerrit.tine20.com/customers/1671
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Cornelius Weiß [Wed, 18 Feb 2015 10:05:05 +0000 (11:05 +0100)]
memberOf filter can only added once
* cope with list/group mix from server
Change-Id: I64ff9ffeb6dca42952e40b328f910f3af264266e
Reviewed-on: http://gerrit.tine20.com/customers/1668
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Tue, 17 Feb 2015 12:45:33 +0000 (13:45 +0100)]
0010834: defining a key-value costumfield breaks addressbook
* use set() to update config item in registry
* trying to set the object directly did not work any longer (did it ever
work?)
https://forge.tine20.org/view.php?id=10834
Change-Id: If9e0325648cdbe3c372e878d1b365d226291c8fb
Reviewed-on: http://gerrit.tine20.com/customers/1667
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Tue, 17 Feb 2015 11:57:32 +0000 (12:57 +0100)]
fixes invalid start/end time validation
* introduces adjustTimeToUserPreference helper function
* improves validation error strings
Change-Id: I4aa6eccdd5ff674973bee6dda7b954326ce14658
Reviewed-on: http://gerrit.tine20.com/customers/1666
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Wed, 11 Feb 2015 15:09:37 +0000 (16:09 +0100)]
find gidnumber for group objects too
Change-Id: I91270063c78e630e185cf9a6dea04d283d9c2206
Reviewed-on: http://gerrit.tine20.com/customers/1646
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 9 Feb 2015 15:41:11 +0000 (16:41 +0100)]
Merge branch 'pu/2013.10-clipboard' into 2013.10
Conflicts:
tine20/Calendar/translations/de.po
Change-Id: Iab280980cf051874a9363de1ca67b72c49bf5f18
Michael Spahn [Mon, 8 Dec 2014 16:20:42 +0000 (17:20 +0100)]
Send notification emails if user has edit right to resource
If you add a resource to your event, every user who is allowed
to edit this resouce receives the mail as well.
Change-Id: I1f3dfa321e28c475b6ec7b633763c5a96d5ac964
Reviewed-on: http://gerrit.tine20.com/customers/1430
Tested-by: Jenkins CI (http://ci.tine20.com/)
Tested-by: sstamer <s.stamer@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Wed, 4 Feb 2015 14:37:14 +0000 (15:37 +0100)]
Do not create recurring events that are longer than the interval
Change-Id: I9b964a9f46e51788ee1cab091559ee712b044362
Reviewed-on: http://gerrit.tine20.com/customers/1608
Tested-by: sstamer <s.stamer@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Wed, 4 Feb 2015 12:27:37 +0000 (13:27 +0100)]
prevent xDAV clients to change the container displayname to id/uuid
Change-Id: I33a310c7f52b1f9fc16b828ad53e3caffa56f843
Reviewed-on: http://gerrit.tine20.com/customers/1607
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Thu, 29 Jan 2015 15:04:07 +0000 (16:04 +0100)]
Mute Toggle with Reschedule, RecurException, StatusChange
+ Tests
Change-Id: I4b14f3ab7bf2fae837c59156c0787a57bdafe8a9
Reviewed-on: http://gerrit.tine20.com/customers/1603
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Thu, 29 Jan 2015 14:12:57 +0000 (15:12 +0100)]
0010560: Import contacts using merge mine
* adds a mergeMine test with tags
* fixes merge handling when importing via web interface
https://forge.tine20.org/view.php?id=10560
Change-Id: I04307bd01ca05ea57cb6aef9f792338c96f727ee
Reviewed-on: http://gerrit.tine20.com/customers/1578
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Cornelius Weiß [Thu, 22 Jan 2015 13:02:00 +0000 (14:02 +0100)]
fix dayview position & size in print sheets
* position all day events with percentages
Change-Id: If92869e42540bc2ad06ed8448812857b6ade7b10
Reviewed-on: http://gerrit.tine20.com/customers/1557
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Tue, 3 Feb 2015 08:33:09 +0000 (09:33 +0100)]
update for installations with PGSQL < 9.1 fails
- left function is not evailable for PGSQL < 9.1
- do the length calculation in PHP
- create the needed SQL query with Zend_Db_Select
Change-Id: I8de7ded086b7674d87da072da2424ee2bce35f16
Reviewed-on: http://gerrit.tine20.com/customers/1600
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Tue, 3 Feb 2015 09:12:11 +0000 (10:12 +0100)]
Merge branch 'pu/2013.10-mutenotification' into 2013.10
Conflicts:
tests/tine20/Calendar/Frontend/iMIPTest.php
Change-Id: I8352806b92bd3d75cac3fafeced6f4b765a8803b
Philipp Schüle [Tue, 3 Feb 2015 09:10:59 +0000 (10:10 +0100)]
Merge branch 'pu/2013.10-downloadlink' into 2013.10
Conflicts:
tine20/Filemanager/translations/de.po
tine20/Filemanager/translations/template.pot
Change-Id: I8ed2bfbee9d88ea1822e9ebac38fe8e50a349aa2
Philipp Schüle [Sat, 31 Jan 2015 17:28:30 +0000 (18:28 +0100)]
add action should be available by default
Change-Id: Ife2a0414c69e2be9bbaad55abf8b001dc57cfe55
Reviewed-on: http://gerrit.tine20.com/customers/1598
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Thu, 29 Jan 2015 14:25:05 +0000 (15:25 +0100)]
diff(): date field in record could be DateTime without compare()
-> convert to Tinebase_DateTime before comparing the dates
Change-Id: I4842d99fbf35910a9505035fb79daf409bf118aa
Reviewed-on: http://gerrit.tine20.com/customers/1584
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Thu, 29 Jan 2015 11:34:47 +0000 (12:34 +0100)]
0005578: activesync device management
* disables all fields in edit dialog as they are overwritten on the next
sync
https://forge.tine20.org/view.php?id=5578
Change-Id: I6d32304389f7ccfcbae7bfdc83f624ea330c275b
Reviewed-on: http://gerrit.tine20.com/customers/1577
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Wed, 28 Jan 2015 09:56:07 +0000 (10:56 +0100)]
validate 00:00 correctly
Change-Id: If4f733245f558638c8ccbc903a899c328fd949c0
Reviewed-on: http://gerrit.tine20.com/customers/1573
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Mon, 22 Dec 2014 08:05:24 +0000 (09:05 +0100)]
0005578: activesync device management
- Implemented UI
- Implemented Controller
- Integrated into Admin UI
- Inside of ActiveSync
- Adds device management tests
- Refactors ActiveSync controller tests
- adds device management as Admin module (if ActiveSync is installed)
https://forge.tine20.org/view.php?id=5578
Change-Id: I8259769506a1662f4433efaba0c33b4c2cb9961a
Reviewed-on: http://gerrit.tine20.com/customers/1482
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Cornelius Weiß [Fri, 23 Jan 2015 09:43:08 +0000 (10:43 +0100)]
Exdate delete does not update seq of base event
Change-Id: I2cffee8d26937dd5f2d002b6bf10ba3c981fcbaa
Reviewed-on: http://gerrit.tine20.com/customers/1558
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Sun, 18 Jan 2015 15:35:07 +0000 (16:35 +0100)]
set correct AS foldertype for drafts folder
https://forge.tine20.org/view.php?id=10520
Change-Id: Ie0dd527983cfa8076280ea860ab0289b74a96212
Reviewed-on: http://gerrit.tine20.com/customers/1538
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Lars Kneschke [Sun, 18 Jan 2015 19:33:27 +0000 (20:33 +0100)]
send all folders to client
- most unselectable folders have subfolders
Change-Id: If7fea99aef3cb8bb98aae0e2c6fda290e318498d
Reviewed-on: http://gerrit.tine20.com/customers/1539
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
sstamer [Fri, 9 Jan 2015 10:59:12 +0000 (11:59 +0100)]
scroll position in crop mode
* fix initial layouting:
scroller needs to be sized to apply scolling
otherwise mainBody is not bigger than scroller
and scrolling is not nessesary when initializing
Change-Id: Id580b2cdf46ec93b23d7b6f7ee50a97c5612b230
Reviewed-on: http://gerrit.tine20.com/customers/1524
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Fri, 9 Jan 2015 12:33:10 +0000 (13:33 +0100)]
Fix 24:00 again
Change-Id: I0d6b65f91be9ec1b465f45ff4f02b01fe50fabb0
Reviewed-on: http://gerrit.tine20.com/customers/1519
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Cornelius Weiß [Wed, 14 Jan 2015 10:53:17 +0000 (11:53 +0100)]
missing colon
Change-Id: I6fc9c72a9616970e3c35edc59c31d5a2fd0a674c
Reviewed-on: http://gerrit.tine20.com/customers/1528
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Tue, 6 Jan 2015 08:51:38 +0000 (09:51 +0100)]
Fix Printproblem with offset 0
- 24:00
Change-Id: I72ce7bb393b9920309f62807bda9304b99ea8e54
Reviewed-on: http://gerrit.tine20.com/customers/1510
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Wed, 7 Jan 2015 13:28:23 +0000 (14:28 +0100)]
0010710: Shorten Usernames
https://forge.tine20.org/view.php?id=10710
Change-Id: I7012154dea1b469bef78838c5aa6b442af48d1a2
Reviewed-on: http://gerrit.tine20.com/customers/1512
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Tue, 6 Jan 2015 10:11:43 +0000 (11:11 +0100)]
0010616: Tld with more than 4 letter in Webmail as receipt address
* increases allowed tld length to 63
https://forge.tine20.org/view.php?id=10616
Change-Id: I9c848c550053a546b0fa1016802339fe98724a6c
Reviewed-on: http://gerrit.tine20.com/customers/1505
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Sat, 20 Dec 2014 22:11:52 +0000 (23:11 +0100)]
added in class cache to Tinebase_Group_Abstract/Sql
Change-Id: I641a22c1db8ac4970e021a6ec29533d9a2894060
Reviewed-on: http://gerrit.tine20.com/customers/1478
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 5 Jan 2015 15:04:16 +0000 (16:04 +0100)]
replaces deprecated /e modifier in preg_replace
... by using preg_replace_callback
Change-Id: Icac5749b5b2cf7e884900176809c7b782c3dc4fc
Reviewed-on: http://gerrit.tine20.com/customers/1503
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 2 Jan 2015 12:57:12 +0000 (13:57 +0100)]
0010622: user contact email is not updated during LDAP sync
* includes email, name and other data from user object in LDAP contact
sync
* adds some logging
* only update contact if diff is not empty
https://forge.tine20.org/view.php?id=10622
Change-Id: I2168197676cfdd2a5c68359bf23b9781691e885a
Reviewed-on: http://gerrit.tine20.com/customers/1498
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 29 Dec 2014 12:25:34 +0000 (13:25 +0100)]
0010610: yearly event is not shown in week view
* Skipping performance optimization (removal of base events with
non-matching rrule) because we can't handle year boundaries yet
https://forge.tine20.org/view.php?id=10610
Change-Id: I2e35bf9fdc541264da6c8a5533078e4fd510ce7d
Reviewed-on: http://gerrit.tine20.com/customers/1489
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Tue, 30 Dec 2014 11:17:22 +0000 (12:17 +0100)]
improves HTTP Server exception handling
* return 500 error code if some error occurs during download or export
* adds a TODO in Calendar ods export test
Change-Id: I2d03e45397ab32557dc037838be550bc11556218
Reviewed-on: http://gerrit.tine20.com/customers/1492
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Mon, 29 Dec 2014 21:21:20 +0000 (22:21 +0100)]
check if cache is initialized and if result of describeTable is valid
Change-Id: I00e13a9cf5916840363f696579d4da0ad915ad20
Reviewed-on: http://gerrit.tine20.com/customers/1490
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Lars Kneschke [Mon, 29 Dec 2014 12:11:58 +0000 (13:11 +0100)]
improve perfomance by avoiding double cache hit
Change-Id: Ib5366851ed72f6ba5857f5a186e29f256cc340ec
Reviewed-on: http://gerrit.tine20.com/customers/1488
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Cornelius Weiß [Mon, 22 Dec 2014 16:05:22 +0000 (17:05 +0100)]
0009542: load event relations on demand
* exclude recurring events (not exceptions)
* adds generic getRelations() to Tinebase JSON frontend
https://forge.tine20.org/view.php?id=9542
Change-Id: I88a5311e42b2f9aae8d6665a21714bfb5fb181ef
Reviewed-on: http://gerrit.tine20.com/customers/1484
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 29 Dec 2014 11:27:56 +0000 (12:27 +0100)]
updates metaways/opendocument to version 0.2
* to allow direct styling of nodes and columns
Change-Id: I78126a740e58e85031b1efd9ccb1a8037d594cf2
Reviewed-on: http://gerrit.tine20.com/customers/1487
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Cornelius Weiß [Mon, 22 Dec 2014 13:47:49 +0000 (14:47 +0100)]
add ods export to calendar
* export button to be added in master
** merge with import btn to a single height btn group
Change-Id: Ic506628f165a0d39a59571cecb1c7f9dd0096537
Reviewed-on: http://gerrit.tine20.com/customers/1461
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Lars Kneschke [Sat, 20 Dec 2014 22:04:36 +0000 (23:04 +0100)]
performance improvements for Tinebase_Convert_Json
- skip hasGrant as Tinebase_Core::getApplicationInsatce calls hasGrant
anyway
- don't try to resolve id's of empty recordSets
Change-Id: I9c9ee43d9635948a4e8a28d3b118630e9b46ab08
Reviewed-on: http://gerrit.tine20.com/customers/1477
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Sat, 20 Dec 2014 22:16:08 +0000 (23:16 +0100)]
improved performance of getTableDescriptionFromCache
- call Zend_Db::describeTable() without the overhead of Zend_Db_Table
Change-Id: I584152a1c77b1552e45d78bb048dbefe782eec4e
Reviewed-on: http://gerrit.tine20.com/customers/1479
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Fri, 19 Dec 2014 21:14:32 +0000 (22:14 +0100)]
add inClassCache for Tinebase_Acl_Roles class
- read all rights of given account at once, cache them in class cache
and check for requested right in PHP
Change-Id: I8f85acf0accd16ebb32cba994887fcf212c049f4
Reviewed-on: http://gerrit.tine20.com/customers/1476
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Mon, 29 Dec 2014 07:34:27 +0000 (08:34 +0100)]
implemented users count function in user backend
Change-Id: I5a50a45c5daefcaf71b0475a437403054e53be97
Reviewed-on: http://gerrit.tine20.com/customers/1486
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Mon, 22 Dec 2014 09:45:11 +0000 (10:45 +0100)]
updated notes tests
- wrapped test in transaction
- added test to get notetypes ids only
Change-Id: I3f2e6ef44ac7d918f723c08aaa7152f8e90b460e
Reviewed-on: http://gerrit.tine20.com/customers/1483
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Lars Kneschke [Sat, 20 Dec 2014 22:21:54 +0000 (23:21 +0100)]
improve perfomance by avoiding double cache hit
Change-Id: I9e7b02b518cceda4db45537c563c0cb5fb85d1c3
Reviewed-on: http://gerrit.tine20.com/customers/1481
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Lars Kneschke [Sat, 20 Dec 2014 22:19:16 +0000 (23:19 +0100)]
improved performance of Tinebase_Notes
- switched from Zend_Db_Table to Zend_Db_Select to reduce processing
time
- added support for fetching id's of note_types only
Change-Id: Iaba8c075514883ad08eb0b5f300b69eac0218a0a
Reviewed-on: http://gerrit.tine20.com/customers/1480
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Lars Kneschke [Thu, 18 Dec 2014 12:15:28 +0000 (13:15 +0100)]
added in class cache for Tinebase_Container
Change-Id: Icd655be9c08fdef643a0ebeed4fc38399c0acc80
Reviewed-on: http://gerrit.tine20.com/customers/1465
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 19 Dec 2014 12:18:44 +0000 (13:18 +0100)]
robusten code by checking variables before accessing
Change-Id: I73b03fddfb221d55734d6f8fd6b43c7707e32b9a
Reviewed-on: http://gerrit.tine20.com/customers/1474
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Fri, 19 Dec 2014 11:54:37 +0000 (12:54 +0100)]
Fix 24:00 crop
- don't set height to 0 if offset is 0 (24:00 = no offset)
Change-Id: If585022a0abe1d85c518bfc4370df4951af05f82
Reviewed-on: http://gerrit.tine20.com/customers/1472
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Wed, 17 Dec 2014 08:09:35 +0000 (09:09 +0100)]
improved performance
- avoid multiple calls to get the same array value
- removed unused code
Change-Id: Ic6c6737a6c6f1ad850a875f130a4cec1c2dc4d98
Reviewed-on: http://gerrit.tine20.com/customers/1457
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Cornelius Weiss <c.weiss@metaways.de>
Lars Kneschke [Fri, 19 Dec 2014 08:54:53 +0000 (09:54 +0100)]
improve class logic
- avoid multiple calls to get the same variable (performance)
- avoid call to get all displayContainerIds
Change-Id: Ibf2284eef43d117cb823d9f749686d07a3a20454
Reviewed-on: http://gerrit.tine20.com/customers/1469
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Fri, 19 Dec 2014 09:01:28 +0000 (10:01 +0100)]
added internal class cache
- avoid multiple lookup of the same data
Change-Id: I9c5f7d2e119dd617ad41fe6e3e09ef85cb78a22f
Reviewed-on: http://gerrit.tine20.com/customers/1470
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Fri, 19 Dec 2014 08:49:39 +0000 (09:49 +0100)]
micro code optimization
- do string conversation only when not a DateTime object
Change-Id: Ic29f4657c4b72ba6d793c2291e190bd40ef5d3e1
Reviewed-on: http://gerrit.tine20.com/customers/1468
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Wed, 17 Dec 2014 20:30:00 +0000 (21:30 +0100)]
fixes some variable names (ActiveSync.resetsync CLI)
Change-Id: I46c87dcde2b2c6f1a6457d78421d4cc904ef3b14
Reviewed-on: http://gerrit.tine20.com/customers/1459
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Cornelius Weiß [Thu, 18 Dec 2014 09:29:24 +0000 (10:29 +0100)]
allign checkbox style to standards
Change-Id: I631d430650714a71cb98e55bcc84d3a89e7a29f3
Reviewed-on: http://gerrit.tine20.com/customers/1460
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Thu, 18 Dec 2014 10:04:03 +0000 (11:04 +0100)]
WIP increase content Sequence with ldap
- for now reverted
Change-Id: I40c66c87f68cf9f7555c7307f31b9acfbd297bbd
Reviewed-on: http://gerrit.tine20.com/customers/1462
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 15 Dec 2014 20:50:04 +0000 (21:50 +0100)]
fixes backend variable
Change-Id: Iea6f0b78f2582888d80aeed89b4797b413881c67
Reviewed-on: http://gerrit.tine20.com/customers/1452
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Michael Spahn [Mon, 15 Dec 2014 14:50:45 +0000 (15:50 +0100)]
Fix leadstate length
Change-Id: Ib21b72fa7975964fceca6d31fc23c110fabd347c
Reviewed-on: http://gerrit.tine20.com/customers/1449
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Mon, 8 Dec 2014 13:59:05 +0000 (14:59 +0100)]
increase sequence when updating user from sync Backend
and allows to configure, if user contact data should be synced
plus: renamed a function (syncContact -> createContactForSyncedUser)
Change-Id: I827dfcac287a99b72e89992a427d16e660a30ed9
Reviewed-on: http://gerrit.tine20.com/customers/1445
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 12 Dec 2014 10:47:21 +0000 (11:47 +0100)]
0010584: CLI function for resetting sync on devices
* allows to reset sync state for user + sync class (Calendar, Contacts,
...) via CLI
* adds a test
* moves parts of Syncroton init to ActiveSync_Controller
https://forge.tine20.org/view.php?id=10584
Change-Id: I1362fbee97c6a3cc6039233b2e23468fc846a7fb
Reviewed-on: http://gerrit.tine20.com/customers/1441
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Sun, 14 Dec 2014 18:26:29 +0000 (19:26 +0100)]
fill atendee cache only when needed
Change-Id: Id99d8d3ee139ca7857d6b9df6ef0ecf42d6291f2
Reviewed-on: http://gerrit.tine20.com/customers/1444
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Fri, 12 Dec 2014 06:14:30 +0000 (07:14 +0100)]
avoid duplicate call of isRegistered
Change-Id: I2faf6597d9b52fbc643c3a03b7d7a0c51583c32e
Reviewed-on: http://gerrit.tine20.com/customers/1439
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Thu, 30 Oct 2014 15:06:44 +0000 (16:06 +0100)]
Short usernames script
Change-Id: I9adca764fc69806933a32e943b56037e921b034b
Reviewed-on: http://gerrit.tine20.com/customers/1326
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 8 Dec 2014 11:15:40 +0000 (12:15 +0100)]
make sure that caldav attachments filenames are decoded
* always (raw)urldecode attachment filenames before saving them in Tine
2.0 vfs
* adjusts regex for utf-8 dispositions
Change-Id: I894e53f02792c52b965133d03a39747ce4d7d4c0
Reviewed-on: http://gerrit.tine20.com/customers/1424
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Tue, 9 Dec 2014 15:35:27 +0000 (16:35 +0100)]
0010578: Fix for groups in active directory is broken
https://forge.tine20.org/view.php?id=10578
Change-Id: Ie72c06f612a85e34b5ffb60654ede3a61c80ae80
Reviewed-on: http://gerrit.tine20.com/customers/1432
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Tue, 9 Dec 2014 14:54:58 +0000 (15:54 +0100)]
Change internet access default
- and translations
Change-Id: I1020c1f5f12ea23197b5cc77ce003c229ee9deca
Reviewed-on: http://gerrit.tine20.com/customers/1431
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Sun, 7 Dec 2014 13:25:52 +0000 (14:25 +0100)]
optimized _checkGrants for performance
- resultset will not be cloned any more
- needed data will stored in separate variables
- avoid unneeded function calls
Change-Id: I94cce34bdf394aab9a9df94dbb76b1ed774b9dc3
Reviewed-on: http://gerrit.tine20.com/customers/1419
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 8 Dec 2014 10:54:20 +0000 (11:54 +0100)]
0010554: create default department (school) on Courses installation
https://forge.tine20.org/view.php?id=10554
Change-Id: Ie2dce15ec889f2738b02b623a1571a2e29abb1e6
Reviewed-on: http://gerrit.tine20.com/customers/1423
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Wed, 29 Oct 2014 14:38:33 +0000 (15:38 +0100)]
0010568: maximal username length
https://forge.tine20.org/view.php?id=10568
- Config optiont for max username length
Change-Id: I4d6fc19f84dc811fd3178b3546cbb3ea81aee8d5
Reviewed-on: http://gerrit.tine20.com/customers/1318
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Mon, 8 Dec 2014 09:35:31 +0000 (10:35 +0100)]
improve perfomance of Tinebase_Core::isLogLevel
- cache value of getLogLevel in class variable
- 58 calls took 625 ms before modification
- 58 calls took 10 ms after modification
Change-Id: I3604fbdf7a9612c6cafefe79d4bc57457a743d12
Reviewed-on: http://gerrit.tine20.com/customers/1422
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Sun, 7 Dec 2014 13:22:07 +0000 (14:22 +0100)]
splitted logic of container grants in to two functions
- one function will return the grants only
- another one to merge the grants into resultset
Change-Id: I03aefcaa984aa7d4fa4b65d61aeb1863b951bc3a
Reviewed-on: http://gerrit.tine20.com/customers/1418
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Mon, 8 Dec 2014 09:28:19 +0000 (10:28 +0100)]
improve performance of Tinebase_Core::get
Zend_Registry::get calls Zend_Registry::isRegistered too and throws an
exception when the key is not registered.
Executiontime for Tinebase_Core::get is reduced by 20%.
Change-Id: I09b8457665ca2c4dce923ee6b4dd9ec8c66069c7
Reviewed-on: http://gerrit.tine20.com/customers/1421
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Sun, 7 Dec 2014 12:50:00 +0000 (13:50 +0100)]
attendee has to be cloned before it can be added to result set
Change-Id: I718fa0cae78c3ff8bf71451e75d1649ef592aa7a
Reviewed-on: http://gerrit.tine20.com/customers/1417
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Lars Kneschke [Sat, 6 Dec 2014 03:44:08 +0000 (04:44 +0100)]
fix test testAlarmAckInRecurException
- the format of the validated string was wrong
Change-Id: I7942dbfa728cd7a967be36df33547407da41fcf5
Reviewed-on: http://gerrit.tine20.com/customers/1416
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Lars Kneschke [Fri, 5 Dec 2014 23:02:32 +0000 (00:02 +0100)]
array key must be scalar value
Change-Id: I073b28a5e8a09609dd21be0f9b77cecfbc098aae
Reviewed-on: http://gerrit.tine20.com/customers/1415
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Tested-by: Lars Kneschke <l.kneschke@metaways.de>
Michael Spahn [Fri, 5 Dec 2014 10:26:58 +0000 (11:26 +0100)]
Extend filter field for leadsource to 350px
Change-Id: Ifed480726344f7d4b73954cf27db1100150cbf81
Reviewed-on: http://gerrit.tine20.com/customers/1411
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: sstamer <s.stamer@metaways.de>
Lars Kneschke [Fri, 5 Dec 2014 06:37:55 +0000 (07:37 +0100)]
delay creating instance of converter until really needed
... to improve performance
- creating the converter instance can be avoided in many use cases
Change-Id: Iaae99edd1006b075bc60feec2fd9289b7d3c78f0
Reviewed-on: http://gerrit.tine20.com/customers/1410
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Lars Kneschke [Fri, 5 Dec 2014 05:00:27 +0000 (06:00 +0100)]
refactored Calendar_Model_Attender::getAttendee
... to improve performance
- don't process empty $_attendeesSet
- avoid manipulating $_attendeesSet
- avoid calling ->filter 4 times in worst case
- stop processing as soon as possible (->filter always loops all elements in recordSet)
Change-Id: Idc02a533a1ce840a9fd513b14c7e21111f4ba023
Reviewed-on: http://gerrit.tine20.com/customers/1408
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Jenkins CI (http://ci.tine20.com/)
Lars Kneschke [Wed, 3 Dec 2014 00:07:44 +0000 (01:07 +0100)]
refactored getGrantsOfRecords to improve performance
- resolve path only once for every container
- made logic easier to understand
Change-Id: Ibe999a30a72bc4548735fb51eb6f58d6ab7485d1
Reviewed-on: http://gerrit.tine20.com/customers/1404
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Fri, 5 Dec 2014 06:29:15 +0000 (07:29 +0100)]
splitted logic Calendar_Model_Attender::resolveAttendee to improve
performance
- add 2 new functions
- to fill attendees cache
- to return resolved attendees
- use the new function to fill attendees cache in MSEventFacade
Change-Id: I5a2a43b65b5d50e5b84d7c95e8645951f72f42dd
Reviewed-on: http://gerrit.tine20.com/customers/1409
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Thu, 27 Nov 2014 15:44:37 +0000 (16:44 +0100)]
adds user agent to alarm ack information
Change-Id: Ia946811a6e8d0d58383359860146a6722f32ea75
Reviewed-on: http://gerrit.tine20.com/customers/1398
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Wed, 3 Dec 2014 00:16:46 +0000 (01:16 +0100)]
cache parsed user-agent
- speed up request with multiple events, by caching parsed user-agnt to
classname mapping
Change-Id: I1cd96054abc3df0c90b9c985225f177b1ea44022
Reviewed-on: http://gerrit.tine20.com/customers/1405
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Lars Kneschke [Tue, 2 Dec 2014 16:00:13 +0000 (17:00 +0100)]
removed index handling
- slows down code execution
- was not working in all cases
closes 0007558: reactivate indices in Tinebase_Record_RecordSet
https://forge.tine20.org/view.php?id=7558
Change-Id: I67f6cbaa7bb00006006b5454473d24a02b296a1c
Reviewed-on: http://gerrit.tine20.com/customers/1403
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 24 Nov 2014 19:56:20 +0000 (20:56 +0100)]
removes db config that's incompatible with pgsql
* pgsql does not like 'default' and 'not null'
SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near "NULL"
Change-Id: I79b5b6814e21e5d9a4e0ff1ee22cbdb0a0beb053
Reviewed-on: http://gerrit.tine20.com/customers/1378
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 24 Nov 2014 18:45:26 +0000 (19:45 +0100)]
column might already exist
Change-Id: Id2c790d1059ddbda8b4afa69383c90d3e3a07384
Reviewed-on: http://gerrit.tine20.com/customers/1377
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 24 Nov 2014 12:42:20 +0000 (13:42 +0100)]
checks for existing class before calling constructor
Change-Id: Iddb2e2ce967f9526c5af85ba9d07da68dcab066d
Reviewed-on: http://gerrit.tine20.com/customers/1374
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
sstamer [Mon, 10 Nov 2014 10:26:57 +0000 (11:26 +0100)]
New url for bugreports script
Change-Id: Iae4f8f9a94b2c8b56d5f9ad8faae3b8cb67d2ea5
Reviewed-on: http://gerrit.tine20.com/customers/1349
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 17 Nov 2014 21:00:04 +0000 (22:00 +0100)]
fixes compareCalendars: filter summary matching subset
and adds a test for all day events
Change-Id: I0edf45625c25eb5a27380c105dbc2e6eb36edb16
Reviewed-on: http://gerrit.tine20.com/customers/1361
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 14 Nov 2014 11:17:08 +0000 (12:17 +0100)]
0010454: cli script for comparing calendars
* ignore events only in displaycontainer
https://forge.tine20.org/view.php?id=10454
Change-Id: Ie0b42a66441bc4978b3845fa10f5a16c13d2e507
Reviewed-on: http://gerrit.tine20.com/customers/1358
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 14 Nov 2014 09:45:35 +0000 (10:45 +0100)]
Revert "respect deleted attendee in event search"
-> this is wrong as it removes events with "other" deleted attendee
This reverts commit
3656ce71c238ffc3a6d3b30c842a19422a58d439.
Change-Id: I008f1b9b07c99255621450141f5e44b3183363f8
Reviewed-on: http://gerrit.tine20.com/customers/1357
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Thu, 13 Nov 2014 20:52:16 +0000 (21:52 +0100)]
0010464: cli script for repairing attendee
* adds cli/controller functions and test
* adds isRecurInstance helper to event model
https://forge.tine20.org/view.php?id=10464
Change-Id: I0a2a17fe8673d88162bab63893ceb76fc6fd1787
Reviewed-on: http://gerrit.tine20.com/customers/1356
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Thu, 13 Nov 2014 16:40:14 +0000 (17:40 +0100)]
0010454: cli script for comparing calendars
* adds new cli function with test
* echo report (CLI)
https://forge.tine20.org/view.php?id=10454
Change-Id: I947231097c80d1e069574fe647a63bab579ecf84
Reviewed-on: http://gerrit.tine20.com/customers/1355
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Thu, 13 Nov 2014 11:20:48 +0000 (12:20 +0100)]
respect deleted attendee in event search
Change-Id: Iefb36a421ad124c694e947cbbb99fffc6b9e7ea1
Reviewed-on: http://gerrit.tine20.com/customers/1354
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 10 Nov 2014 21:03:25 +0000 (22:03 +0100)]
0010449: allow to ignore data when importing ics
* allows to ignore alarms, attachments, attendee, ... on ics import
* improves CLI error message if import fails
https://forge.tine20.org/mantisbt/view.php?id=10449
Change-Id: I5fd775039041937bf2b5342130f0672878351c59
Reviewed-on: http://gerrit.tine20.com/customers/1351
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Tue, 11 Nov 2014 19:59:32 +0000 (20:59 +0100)]
lowers log level for deprecated message
Change-Id: I9ffbc1c5edda61e0c3f20850c1ce31531b589990
Reviewed-on: http://gerrit.tine20.com/customers/1352
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 7 Nov 2014 21:12:09 +0000 (22:12 +0100)]
improves alarmAckReport: add recurring events and show period
Change-Id: Ic2ee1d2632d2959726d7122eb3e684a1966d4946
Reviewed-on: http://gerrit.tine20.com/customers/1346
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 7 Nov 2014 20:49:58 +0000 (21:49 +0100)]
adjust function signature of fromTine20RecordSet in json converters
Change-Id: Ice90565ad6b5a2656a7a0a39e8b2d6fbaa8afa1e
Reviewed-on: http://gerrit.tine20.com/customers/1345
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Mon, 10 Nov 2014 14:11:17 +0000 (15:11 +0100)]
improves sorting and logging of deleteDuplicateEvents
Change-Id: Ifa521a6501f2eb72939170c8696238f26dee9a92
Reviewed-on: http://gerrit.tine20.com/customers/1350
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Philipp Schüle [Fri, 7 Nov 2014 10:26:31 +0000 (11:26 +0100)]
0008364: saving phone settings should close session writing
https://forge.tine20.org/mantisbt/view.php?id=8364
Change-Id: I0d35ae9468bf564d7af499b6eea6187e9bb76133
Reviewed-on: http://gerrit.tine20.com/customers/1341
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>