tine20
5 years ago11788: Always set is_billable if timeaccount is billable
sstamer [Fri, 15 Apr 2016 10:15:30 +0000 (12:15 +0200)]
11788: Always set is_billable if timeaccount is billable

https://forge.tine20.org/view.php?id=11788

- This is needed for copied sheets

Change-Id: I0513c4ef7057d91b9a014aa1c9e1d5d81cb308c6
Reviewed-on: http://gerrit.tine20.com/customers/3050
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodon't show duplicates as failures in import summary
Philipp Schüle [Wed, 13 Apr 2016 14:42:07 +0000 (16:42 +0200)]
don't show duplicates as failures in import summary

Change-Id: I30ce6908787035985993017bb7014e9aaeb93b45
Reviewed-on: http://gerrit.tine20.com/customers/3047
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoonly try to replace matching target fields
Philipp Schüle [Wed, 13 Apr 2016 14:41:27 +0000 (16:41 +0200)]
only try to replace matching target fields

... of related records during import when
targetField option is given
.... and check if it's a scalar, we can't handle
 non-scalars yet

Change-Id: I555aefcf6c67d051de8da8c213d3088ab5b09749
Reviewed-on: http://gerrit.tine20.com/customers/3046
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoset param defaults in createNodes
Philipp Schüle [Sat, 19 Mar 2016 12:45:44 +0000 (13:45 +0100)]
set param defaults in createNodes

... client might omit tempFileIds and/or forceOverwrite

Change-Id: I1754f125adaecf879761bcfbfa1b9fa8c3b4a67b
Reviewed-on: http://gerrit.tine20.com/customers/2938
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011794: lazy init of comboboxes fails sometimes
Philipp Schüle [Mon, 18 Apr 2016 14:13:25 +0000 (16:13 +0200)]
0011794: lazy init of comboboxes fails sometimes

deactivates lazyInit for
* recipient search
* timeaccount search

https://forge.tine20.org/view.php?id=11794

Change-Id: I583f2a31b05bd46d8de310876a22652cd5f223cc
Reviewed-on: http://gerrit.tine20.com/customers/3055
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011792: private email address is added on recipient selection
Philipp Schüle [Mon, 18 Apr 2016 14:03:42 +0000 (16:03 +0200)]
0011792: private email address is added on recipient selection

* when editor combo is reset, the record with the private
 address is fetched from store
* we no longer search for records with an empty id in the record
 picker combo

https://forge.tine20.org/view.php?id=11792

Change-Id: I33c5ec3bd0a593d97e9d1fbd8ca7e2449450eae6
Reviewed-on: http://gerrit.tine20.com/customers/3054
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2015.11-sambaad' into 2015.11
Philipp Schüle [Tue, 19 Apr 2016 13:13:06 +0000 (15:13 +0200)]
Merge branch '2015.11-sambaad' into 2015.11

5 years agofixes tests for samba ad
Philipp Schüle [Tue, 5 Apr 2016 16:18:07 +0000 (18:18 +0200)]
fixes tests for samba ad

* use getDefaultGroup fns instead of hard coded group names
* skip some tests that try to create multiple users with same CN
* obey to default ad password complexity
* users and groups can't have the same name in ad default setup
 (same base dn)
* disabled some test (users have no account
 email addresses with samba ad)

... and makes sure that users/groups are deleted
 in TestCase::tearDown, too

Change-Id: I80440ac13006bd0942c43daefabfbe289fb7ea19
Reviewed-on: http://gerrit.tine20.com/customers/3007
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoallows startTLS for ad accounts backend
Philipp Schüle [Mon, 18 Apr 2016 16:15:42 +0000 (18:15 +0200)]
allows startTLS for ad accounts backend

Change-Id: I943e88eb5633ad4216713a5cf285cf4425211451
Reviewed-on: http://gerrit.tine20.com/customers/3056
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoremove "org" from jsclient.php
Philipp Schüle [Mon, 18 Apr 2016 08:52:04 +0000 (10:52 +0200)]
remove "org" from jsclient.php

Change-Id: I521a94c41f36ee5fa11ba77fc1313be1d4072b6e
Reviewed-on: http://gerrit.tine20.com/customers/3053
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011766: Show date at all busy conflict
sstamer [Tue, 5 Apr 2016 12:07:53 +0000 (14:07 +0200)]
0011766: Show date at all busy conflict

https://forge.tine20.org/view.php?id=11766

Change-Id: Idaa5f4005797c9239af4079cf5d16046b3d88492
Reviewed-on: http://gerrit.tine20.com/customers/3002
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoTrim whitespace in combined import fields
sstamer [Mon, 11 Apr 2016 09:46:35 +0000 (11:46 +0200)]
Trim whitespace in combined import fields

Change-Id: Ie2fe5153ef0e8669af0023280933c89922546e9b
Reviewed-on: http://gerrit.tine20.com/customers/3029
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011770: FF: "null" displayed in contact data template
Philipp Schüle [Fri, 8 Apr 2016 14:53:03 +0000 (16:53 +0200)]
0011770: FF: "null" displayed in contact data template

* return empty string in encode/doubleEncode if value is null

https://forge.tine20.org/view.php?id=11770

Change-Id: If51e39b1f674d656fb6ac0cfabf5bcad913551fe
Reviewed-on: http://gerrit.tine20.com/customers/3023
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011768: import relations: allow to define more filter and record fields
Philipp Schüle [Fri, 8 Apr 2016 11:45:05 +0000 (13:45 +0200)]
0011768: import relations: allow to define more filter and record fields

* adds new filterValueAdd field config to be able to search for multiple
 record properties when trying to find a related record in import

 https://forge.tine20.org/view.php?id=11768

Change-Id: Id92bc3afe6cb0a3c00d90423088d5f2d42f646bf
Reviewed-on: http://gerrit.tine20.com/customers/3022
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadds duplicate resolve configuration and labels for Leads
Philipp Schüle [Fri, 8 Apr 2016 09:05:01 +0000 (11:05 +0200)]
adds duplicate resolve configuration and labels for Leads

Change-Id: I2e16e2640e7d4afcfc174b83f0706af019097328
Reviewed-on: http://gerrit.tine20.com/customers/3019
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agocatch problem with missing tags
Philipp Schüle [Fri, 8 Apr 2016 09:05:18 +0000 (11:05 +0200)]
catch problem with missing tags

... in duplicate resolve panel

Change-Id: I4a1758137d6017344af68b8c39310c277a466ee0
Reviewed-on: http://gerrit.tine20.com/customers/3020
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Thu, 7 Apr 2016 07:42:32 +0000 (09:42 +0200)]
Merge branch '2014.11-develop' into 2015.11

5 years agoMerge branch '2014.11' into 2014.11-develop
Philipp Schüle [Thu, 7 Apr 2016 07:42:13 +0000 (09:42 +0200)]
Merge branch '2014.11' into 2014.11-develop

5 years ago0011728: Split of a recurring series is not displayed correctly
Cornelius Weiß [Mon, 14 Mar 2016 13:27:14 +0000 (14:27 +0100)]
0011728: Split of a recurring series is not displayed correctly

- Split of a recurring series on multiple days (delete this and
all future) is not displayed correctly in days view

https://forge.tine20.org/view.php?id=11728

Change-Id: Ia5a3bbc95b086561c93ecca886233113d311c147
Reviewed-on: http://gerrit.tine20.com/customers/2900
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2015.11-ldap' into 2015.11
Philipp Schüle [Wed, 6 Apr 2016 14:41:45 +0000 (16:41 +0200)]
Merge branch '2015.11-ldap' into 2015.11

5 years agoSet quicksearch as default filter for invoces and purchase invoces
sstamer [Tue, 5 Apr 2016 12:56:53 +0000 (14:56 +0200)]
Set quicksearch as default filter for invoces and purchase invoces

Change-Id: Ib867cc483b29edd62cad99627730fe353c5ada12
Reviewed-on: http://gerrit.tine20.com/customers/3010
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2015.11-php7' into 2015.11
Philipp Schüle [Wed, 6 Apr 2016 08:35:31 +0000 (10:35 +0200)]
Merge branch '2015.11-php7' into 2015.11

5 years agoremoves deprecated warning for iconv_set_encoding
Philipp Schüle [Tue, 5 Apr 2016 13:49:37 +0000 (15:49 +0200)]
removes deprecated warning for iconv_set_encoding

.... with php > 5.6

Change-Id: Ibb6cd9bd7319c94f65ee13fdaba0a6aa08a81e60
Reviewed-on: http://gerrit.tine20.com/customers/3005
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agouse getDefaultGroup() in DemoData instead of hard coded 'Users'
Philipp Schüle [Tue, 5 Apr 2016 13:56:57 +0000 (15:56 +0200)]
use getDefaultGroup() in DemoData instead of hard coded 'Users'

... as this breaks in samba ad setup

Change-Id: I56b4560cc18d0757a28fb8c348352f587e70eae1
Reviewed-on: http://gerrit.tine20.com/customers/3006
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2015.11-sambaad' into 2015.11
Philipp Schüle [Tue, 5 Apr 2016 13:58:08 +0000 (15:58 +0200)]
Merge branch '2015.11-sambaad' into 2015.11

5 years ago0011686: Editing Users / Sync with Active Directory doesn't work
Philipp Schüle [Wed, 30 Mar 2016 18:26:46 +0000 (20:26 +0200)]
0011686: Editing Users / Sync with Active Directory doesn't work

* don't try to set cn when updating AD entries as
 this is only allowed via rename()
* fixes rename() case for AD groups by using configured groupsDN
* improves some variable names

https://forge.tine20.org/view.php?id=11686

Change-Id: If3cd22f5e7b25b37c50199a7bf542739cac289fa
Reviewed-on: http://gerrit.tine20.com/customers/2996
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2015.11-php7' into 2015.11
Philipp Schüle [Mon, 4 Apr 2016 15:25:24 +0000 (17:25 +0200)]
Merge branch '2015.11-php7' into 2015.11

5 years ago0011704 / PHP 7 can't decode empty JSON
Johannes Nohl [Wed, 23 Mar 2016 00:58:15 +0000 (01:58 +0100)]
0011704 / PHP 7 can't decode empty JSON

https://forge.tine20.org/view.php?id=11704

Change-Id: I38d9f35754f7e6815e2c122a9c0b5c3da08f3795
Reviewed-on: http://gerrit.tine20.com/customers/2960
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011746: fix multiple php7 issues
Paul Mehrer [Thu, 31 Mar 2016 10:53:01 +0000 (12:53 +0200)]
0011746: fix multiple php7 issues

* silenced deprecation message in Zend/Locale/Format.php
* temporary marked Crm_Export_XlsTest::testExportXls to skip for php7
* fixed simpleXML syntax for php7 compatibility
* properly broke TMZ in testBrokenTimezoneInTineEvent
* chg $obj->$arr['s'] to $obj->{$arr['s']} for php7
* fixed Zend_Ldap_ConvertTest (important for php5x too!)

https://forge.tine20.org/view.php?id=11746

Change-Id: I8b6469d0cbe9c158744d52e56566006112881263
Reviewed-on: http://gerrit.tine20.com/customers/2986
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoconvert param to array
Philipp Schüle [Fri, 1 Apr 2016 10:51:11 +0000 (12:51 +0200)]
convert param to array

... as giving a string this was causing an error in
 Calendar_Setup_Update_Release8->update_11():
 Invalid argument supplied for foreach()
 in /usr/share/tine20/ActiveSync/Controller.php::84

Change-Id: Ie0f8861c83549f5c0929a6a5e7ec0e8042994f73
Reviewed-on: http://gerrit.tine20.com/customers/2987
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoskip Doc export test in php7
Philipp Schüle [Wed, 23 Mar 2016 19:23:59 +0000 (20:23 +0100)]
skip Doc export test in php7

TODO: update phpoffice/phpword lib when it supports php7

see 0011730: fix doc export for php7
https://forge.tine20.org/view.php?id=11730

Change-Id: I720e38f8e8f7c5435749ceb311fcf22f44bc5980
Reviewed-on: http://gerrit.tine20.com/customers/2970
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agofix variable name in log message
Philipp Schüle [Wed, 23 Mar 2016 19:15:12 +0000 (20:15 +0100)]
fix variable name in log message

Change-Id: I45d0b71eeb72bf0f2d9cc57557c3e214a2abe533
Reviewed-on: http://gerrit.tine20.com/customers/2971
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodon't add account email address in contact search combo
Philipp Schüle [Wed, 30 Mar 2016 13:24:48 +0000 (15:24 +0200)]
don't add account email address in contact search combo

see 0011108: show contact/user email in user grids

Change-Id: Idf7c2c2e53f4733224f123df3dab9dd7e5dcff72
Reviewed-on: http://gerrit.tine20.com/customers/2980
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011108: show contact/user email in user grids
Philipp Schüle [Wed, 30 Mar 2016 11:27:58 +0000 (13:27 +0200)]
0011108: show contact/user email in user grids

* show email address in attendee and grants grids
* show email address in contact search combo
* adds getTitle() to contact model
* adds feature switch

https://forge.tine20.org/view.php?id=11108

Change-Id: Ibf5ff24b7c73bc20c2538fbe152d29dccf9c574c
Reviewed-on: http://gerrit.tine20.com/customers/2976
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Wed, 30 Mar 2016 10:01:49 +0000 (12:01 +0200)]
Merge branch '2014.11-develop' into 2015.11

5 years agoMerge branch '2014.11' into 2014.11-develop
Philipp Schüle [Wed, 30 Mar 2016 10:01:25 +0000 (12:01 +0200)]
Merge branch '2014.11' into 2014.11-develop

5 years agohandle missing keyfield config during export
Philipp Schüle [Wed, 23 Mar 2016 15:42:57 +0000 (16:42 +0100)]
handle missing keyfield config during export

Change-Id: I50553b82ce1b726f9927445325c6bb716a8288d4
Reviewed-on: http://gerrit.tine20.com/customers/2967
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoreturn an empty array in _mapRelation
Philipp Schüle [Wed, 23 Mar 2016 13:30:44 +0000 (14:30 +0100)]
return an empty array  in _mapRelation

... otherwise, the array_merge fails.

Change-Id: Ifee25e598a064bb4b144093950394b9cfcf2e0b5
Reviewed-on: http://gerrit.tine20.com/customers/2963
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011698: contact image quality too low in sync
Cornelius Weiß [Thu, 17 Mar 2016 11:26:46 +0000 (12:26 +0100)]
0011698: contact image quality too low in sync

* fixed image reduction
* added caching for reduction

https://forge.tine20.org/view.php?id=11698

Change-Id: If4cf4a4b9aae308977208f4460496c6971fe37ac
Reviewed-on: http://gerrit.tine20.com/customers/2955
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoAdd remark for imported product relations
sstamer [Tue, 22 Mar 2016 13:52:59 +0000 (14:52 +0100)]
Add remark for imported product relations

- This is needed for product count in CRM export for example

Change-Id: I3a738826088685afff24f687f3aa5611e0517dbb
Reviewed-on: http://gerrit.tine20.com/customers/2946
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimproves syncDeletedUser test
Philipp Schüle [Wed, 23 Mar 2016 10:06:25 +0000 (11:06 +0100)]
improves syncDeletedUser test

... by allowing expired date to be earlier

Change-Id: I673c1e2c6c6c916289a30142f1ea3acb1b6b4d18
Reviewed-on: http://gerrit.tine20.com/customers/2954
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agofail build if tine-install has a problem (rc != 0)
Philipp Schüle [Tue, 22 Mar 2016 19:53:18 +0000 (20:53 +0100)]
fail build if tine-install has a problem (rc != 0)

Change-Id: I87a6584d5cf90df9ce682ffd2ce93ca07d292363
Reviewed-on: http://gerrit.tine20.com/customers/2948
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Thu, 17 Mar 2016 10:38:34 +0000 (11:38 +0100)]
Merge branch '2014.11-develop' into 2015.11

5 years agoTinebase_Relation_Backend: fixed removeApplication
Paul Mehrer [Tue, 15 Mar 2016 14:30:54 +0000 (15:30 +0100)]
Tinebase_Relation_Backend: fixed removeApplication

Zend_Db_Select->from()->columns()
+
Zend_Db->fetchCol()
doesnt work together well, you need to pass the columns to
the method from() or it will not work

Change-Id: I7459717252330d99f445ec93d1aa8f6e27b2dc63
Reviewed-on: http://gerrit.tine20.com/customers/2920
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoresolve customfields in Sales controllers
Philipp Schüle [Wed, 16 Mar 2016 16:12:23 +0000 (17:12 +0100)]
resolve customfields in Sales controllers

... of models that support customfields

TODO: controller should ask model(config) if it hasCustomFields

Change-Id: I9133a4b345e998ffb5d847cba057a0ab4a29ce3c
Reviewed-on: http://gerrit.tine20.com/customers/2923
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoonly allow non-scalars for updates in Lead notification
Philipp Schüle [Thu, 17 Mar 2016 10:08:05 +0000 (11:08 +0100)]
only allow non-scalars for updates in Lead notification

see 0011694: show tags and history / latest changes in lead notification mail

Change-Id: I25c85d18422aac37d9e68ce3d3c57d117f063d17
Reviewed-on: http://gerrit.tine20.com/customers/2926
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Wed, 16 Mar 2016 16:53:16 +0000 (17:53 +0100)]
Merge branch '2014.11-develop' into 2015.11

5 years agoMerge branch '2014.11' into 2014.11-develop
Philipp Schüle [Wed, 16 Mar 2016 16:53:07 +0000 (17:53 +0100)]
Merge branch '2014.11' into 2014.11-develop

5 years agoremoves duplicate test
Philipp Schüle [Wed, 16 Mar 2016 16:52:42 +0000 (17:52 +0100)]
removes duplicate test

Change-Id: Ide4459652cfe09919e58c94fa933e49f4e191ac6

5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Wed, 16 Mar 2016 16:17:23 +0000 (17:17 +0100)]
Merge branch '2014.11-develop' into 2015.11

5 years agoMerge branch '2014.11' into 2014.11-develop
Philipp Schüle [Wed, 16 Mar 2016 16:17:08 +0000 (17:17 +0100)]
Merge branch '2014.11' into 2014.11-develop

5 years agoMerge branch '2013.10' into 2014.11
Philipp Schüle [Wed, 16 Mar 2016 16:16:58 +0000 (17:16 +0100)]
Merge branch '2013.10' into 2014.11

5 years ago0011694: show tags and history / latest changes in lead notification mail
sstamer [Mon, 14 Mar 2016 12:45:37 +0000 (13:45 +0100)]
0011694: show tags and history / latest changes in lead notification mail

* Add Tags to lead notification Mail
* Add update diff
* Updates translations

https://forge.tine20.org/view.php?id=11694

Change-Id: I8b70b4896de25376d43ce3115244c72817b14b4b
Reviewed-on: http://gerrit.tine20.com/customers/2906
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoprevents fatal error if mcrypt module is missing
Philipp Schüle [Tue, 15 Mar 2016 08:53:01 +0000 (09:53 +0100)]
prevents fatal error if mcrypt module is missing

Change-Id: I3f18dd16fc8e769d811fbc69df2923269dbb2f2d
Reviewed-on: http://gerrit.tine20.com/customers/2908
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoapplication $xml might be false during installation
Philipp Schüle [Tue, 15 Mar 2016 08:59:01 +0000 (09:59 +0100)]
application $xml might be false during installation

Change-Id: Ib347c5ea61e37c0d52f38240fe297d91e2b466ac
Reviewed-on: http://gerrit.tine20.com/customers/2909
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadds missing "new" keyword
Philipp Schüle [Tue, 15 Mar 2016 09:05:16 +0000 (10:05 +0100)]
adds missing "new" keyword

Change-Id: Iafc237e485f558985f4bde3b8411d5e874f82892
Reviewed-on: http://gerrit.tine20.com/customers/2910
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agolog warning if one of the nodes could not be moved/copied
Philipp Schüle [Tue, 15 Mar 2016 09:13:58 +0000 (10:13 +0100)]
log warning if one of the nodes could not be moved/copied

Change-Id: I7086cf1d0c4a3c0f473f85948ecb4814e14fbcbe
Reviewed-on: http://gerrit.tine20.com/customers/2911
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoprevent problem with wrong return data
Philipp Schüle [Mon, 14 Mar 2016 14:32:01 +0000 (15:32 +0100)]
prevent problem with wrong return data

Change-Id: I86bcb1c4e8ed8ad788a2027c24b4488812c0b79f
Reviewed-on: http://gerrit.tine20.com/customers/2905
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011232: support ATTENDEE in OSX 10.10
Cornelius Weiß [Thu, 13 Aug 2015 15:02:59 +0000 (17:02 +0200)]
0011232: support ATTENDEE in OSX 10.10

* In yosemite iCal adds organiser with role "chair" but has no roles for
other attendee
* In mavericks iCal adds organiser as attendee without role

https://forge.tine20.org/view.php?id=11232

Change-Id: Ie645a6a574ef9c94fa0803333e25f3c89835a432
Reviewed-on: http://gerrit.tine20.com/customers/2108
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-on: http://gerrit.tine20.com/customers/2904
Tested-by: Jenkins CI (http://ci.tine20.com/)
5 years agocut/copy reschedules event time when pasting to monthView
Cornelius Weiß [Mon, 14 Mar 2016 12:43:54 +0000 (13:43 +0100)]
cut/copy reschedules event time when pasting to monthView

https://forge.tine20.org/view.php?id=11690

Change-Id: I0f6e4648e577747c5dce927b9871093a28168eb5
Reviewed-on: http://gerrit.tine20.com/customers/2897
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011682: daysView Event Cut/Paste duplicates current user as attendee
Cornelius Weiß [Mon, 14 Mar 2016 10:17:53 +0000 (11:17 +0100)]
0011682: daysView Event Cut/Paste duplicates current user as attendee

https://forge.tine20.org/view.php?id=11682

Change-Id: I5f4804d7e3770312bf5638734985cbcecf5774b1
Reviewed-on: http://gerrit.tine20.com/customers/2895
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2015.11-pgsql' into 2015.11
Philipp Schüle [Mon, 14 Mar 2016 12:44:04 +0000 (13:44 +0100)]
Merge branch '2015.11-pgsql' into 2015.11

5 years agoTinebase_Lock fixed pgsql part that only worked as of php 5.6.3
Paul Mehrer [Mon, 14 Mar 2016 11:37:48 +0000 (12:37 +0100)]
Tinebase_Lock fixed pgsql part that only worked as of php 5.6.3

see 0011692: Tinebase_LockTest with pgsql
https://forge.tine20.org/view.php?id=11692

Change-Id: Ic532eb5efef6e73aa6c46e4f99fd3fe0b4a5581b
Reviewed-on: http://gerrit.tine20.com/customers/2896
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agolimit event SUMMARY and LOCATION to 1024 mb chars
Philipp Schüle [Fri, 11 Mar 2016 10:29:47 +0000 (11:29 +0100)]
limit event SUMMARY and LOCATION to 1024 mb chars

 ... as this breaks in pgsql for longer strings

Change-Id: If74509cb0515cf6082b9fe3fb95f15a3083b3633
Reviewed-on: http://gerrit.tine20.com/customers/2886
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodeactivated Calendar_Controller_EventTests::testAttendeeNotInFilter for pgsql
Philipp Schüle [Fri, 11 Mar 2016 10:14:57 +0000 (11:14 +0100)]
deactivated Calendar_Controller_EventTests::testAttendeeNotInFilter for pgsql

0011674: problem with Attendee "NotIn" Filter (pgsql)
https://forge.tine20.org/view.php?id=11674

Change-Id: I43b735f0870cc57ed2e7c67b7a2fdff7da3ed9d0
Reviewed-on: http://gerrit.tine20.com/customers/2885
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agointeger fields are not allowed in query filter
Philipp Schüle [Fri, 11 Mar 2016 09:34:49 +0000 (10:34 +0100)]
integer fields are not allowed in query filter

... because pgsql is picky here. to allow them, we
would need a typecast in the query

Zend_Db_Statement_Exception: SQLSTATE[42883]: Undefined function: 7
ERROR:  operator does not exist: integer ~~* unknown
LINE 1: ...is_deleted" = 0) AND (("sales_customers"."number" iLIKE('%wo..

Change-Id: I1051bad84f88fba0604d59370f7fd8450ca80d08
Reviewed-on: http://gerrit.tine20.com/customers/2883
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodeactivates some Invoices tests for pgsql backends
Philipp Schüle [Thu, 10 Mar 2016 16:53:53 +0000 (17:53 +0100)]
deactivates some Invoices tests for pgsql backends

0011670: fix Sales_Invoices Tests with postgresql backend
https://forge.tine20.org/view.php?id=11670

Change-Id: I9214cad393c519acee9305934770c8a7665633b1
Reviewed-on: http://gerrit.tine20.com/customers/2882
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodeactivates some Calendar_Frontend tests for pgsql backends
Philipp Schüle [Thu, 10 Mar 2016 16:48:01 +0000 (17:48 +0100)]
deactivates some Calendar_Frontend tests for pgsql backends

0011668: fix Calendar_Frontend_* Tests with postgresql backend
https://forge.tine20.org/view.php?id=11668

Change-Id: I9c1e2473a4ace57eceb95c1dc43f7648f73fcd84
Reviewed-on: http://gerrit.tine20.com/customers/2881
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadds fn for checking pgsql adapter in tests
Philipp Schüle [Thu, 10 Mar 2016 16:39:47 +0000 (17:39 +0100)]
adds fn for checking pgsql adapter in tests

 ... and disable one test that is not working with pgsql

Change-Id: Ide9e4be550921147da922011cdf8fe29daadc688
Reviewed-on: http://gerrit.tine20.com/customers/2880
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoadds a sleep(2) to give mailserver a little bit more time
Philipp Schüle [Thu, 10 Mar 2016 14:48:05 +0000 (15:48 +0100)]
adds a sleep(2) to give mailserver a little bit more time

... to send and receive the mails

Change-Id: I0b6a2e09e1623f6e62bd2b5100560ce328cec0d3
Reviewed-on: http://gerrit.tine20.com/customers/2879
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Thu, 10 Mar 2016 14:06:09 +0000 (15:06 +0100)]
Merge branch '2014.11-develop' into 2015.11

5 years agoMerge branch '2014.11' into 2014.11-develop
Philipp Schüle [Thu, 10 Mar 2016 14:05:59 +0000 (15:05 +0100)]
Merge branch '2014.11' into 2014.11-develop

5 years agoMerge branch '2015.11-ldap' into 2015.11
Philipp Schüle [Thu, 10 Mar 2016 14:04:14 +0000 (15:04 +0100)]
Merge branch '2015.11-ldap' into 2015.11

5 years agofixes/improves some more tests for ldap backend
Philipp Schüle [Thu, 10 Mar 2016 11:58:35 +0000 (12:58 +0100)]
fixes/improves some more tests for ldap backend

    + Tinebase_Group_LdapTest
    + Addressbook_Import_CsvTest
    + Admin_ControllerTest.testGetAccounts
    + Calendar_Controller_EventTests.testAttendeeGroupMembers

disables some tests, because they work if run on their own but fail in complete
test suite run:

    + Tinebase_ControllerTest::testMaintenanceModeLoginFail
    + Calendar_Model_AttenderTests.testEmailsToAttendeeWithGroups
    + Crm_JsonTest.testCreateLeadWithAttachment
    + Crm_JsonTest.testUpdateLeadWithAttachment
    + Crm_JsonTest.testRemoveAttachmentFromLead
    + Crm_JsonTest.testDeleteLeadWithAttachment

Change-Id: I1fd68d4fccf326eb1313ed1f2ce4ef23d31fd9fa
Reviewed-on: http://gerrit.tine20.com/customers/2877
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agocan't delete files with name '0'
Cornelius Weiß [Wed, 9 Mar 2016 07:51:50 +0000 (08:51 +0100)]
can't delete files with name '0'

Change-Id: I227f95f088f5aa5063a9fc148176a54fa3bbd3b9
Reviewed-on: http://gerrit.tine20.com/customers/2865
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimproves Ldap Group Tests
Philipp Schüle [Thu, 10 Mar 2016 11:05:09 +0000 (12:05 +0100)]
improves Ldap Group Tests

Change-Id: I36fe34148ca65488fd84d746025998b26b033007
Reviewed-on: http://gerrit.tine20.com/customers/2876
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodo not try to loop non-array in TestCase group cleanup
Philipp Schüle [Thu, 10 Mar 2016 09:06:00 +0000 (10:06 +0100)]
do not try to loop non-array in TestCase group cleanup

LDAP tests:
Invalid argument supplied for foreach()

/usr/local/share/tine20.git/tests/tine20/TestCase.php:209
/usr/local/share/tine20.git/tests/tine20/TestCase.php:114
/usr/local/share/tine20.git/tests/tine20/Addressbook/JsonTest.php:150

Change-Id: I3f5b63f95da4741c8ed9a70e65659a0f1ccd7549
Reviewed-on: http://gerrit.tine20.com/customers/2875
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodon't count deactivated users in countNonSystemUsers()
Philipp Schüle [Wed, 9 Mar 2016 16:12:00 +0000 (17:12 +0100)]
don't count deactivated users in countNonSystemUsers()

Change-Id: I71ac942ea66a8e653836ca420a426e53fb9d1909
Reviewed-on: http://gerrit.tine20.com/customers/2868
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011090: user id replaced "currentAccount" placeholder
Philipp Schüle [Wed, 2 Mar 2016 09:20:07 +0000 (10:20 +0100)]
0011090: user id replaced "currentAccount" placeholder

* adds a test and updates json frontend tests
* problem fixed in Tinebase_Model_Filter_User::setValue/toArray:
  -> we save the magic CURRENTACCOUNT value in setValue and
   return it in toArray

https://forge.tine20.org/view.php?id=11090

Change-Id: Ie64155782258c2673add89cceaedb574d11aab01
Reviewed-on: http://gerrit.tine20.com/customers/2838
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Wed, 9 Mar 2016 14:39:13 +0000 (15:39 +0100)]
Merge branch '2014.11-develop' into 2015.11

5 years agoMerge branch '2014.11' into 2014.11-develop
Philipp Schüle [Wed, 9 Mar 2016 14:39:00 +0000 (15:39 +0100)]
Merge branch '2014.11' into 2014.11-develop

5 years agosetting secure-http to false in composer.json
Philipp Schüle [Wed, 9 Mar 2016 11:20:59 +0000 (12:20 +0100)]
setting secure-http to false in composer.json

... because some repos are only reachable via HTTP

see https://www.tine20.org/forum/viewtopic.php?f=10&t=17900

Change-Id: Ia7d4af915233f2aae4d726fedb7c19050e01a5db
Reviewed-on: http://gerrit.tine20.com/customers/2866
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoprevent error if store.namespace is not availiable
Philipp Schüle [Mon, 7 Mar 2016 11:11:59 +0000 (12:11 +0100)]
prevent error if store.namespace is not availiable

... during clearRegistry

Change-Id: If613a81a9eac001fdd5affc1b6836910ea840aca
Reviewed-on: http://gerrit.tine20.com/customers/2857
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011658: show reload confirmation after config setting changed
Philipp Schüle [Tue, 1 Mar 2016 16:33:35 +0000 (17:33 +0100)]
0011658: show reload confirmation after config setting changed

* moves confirmation message box to common.js
* this could be improved by changing the registry on the fly

https://forge.tine20.org/view.php?id=11658

Change-Id: I49bd95716bb7e4b148b414401f19d54a413f20f2
Reviewed-on: http://gerrit.tine20.com/customers/2836
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agomoves time logging into INFO if-block
Philipp Schüle [Thu, 3 Mar 2016 11:32:27 +0000 (12:32 +0100)]
moves time logging into INFO if-block

Change-Id: I2afa704c4ee7da03ed581103d321d67cc9189224
Reviewed-on: http://gerrit.tine20.com/customers/2849
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoredis cache: prevent "member function on a non-object" problems
Philipp Schüle [Tue, 1 Mar 2016 14:55:41 +0000 (15:55 +0100)]
redis cache: prevent "member function on a non-object" problems

... if Redis server has gone away

Change-Id: I1cb564b5b120628ddf18c5eee8a9243f2afdb8d6
Reviewed-on: http://gerrit.tine20.com/customers/2834
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoSales - PurchaseInvoice - added empty value '0' for discount
Paul Mehrer [Tue, 2 Feb 2016 15:58:48 +0000 (16:58 +0100)]
Sales - PurchaseInvoice - added empty value '0' for discount

Change-Id: I79b1ed42d5ca878268283a0b2afb6cc584781db5
Reviewed-on: http://gerrit.tine20.com/customers/2656
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoimproves container selector grants check
Philipp Schüle [Mon, 29 Feb 2016 14:40:25 +0000 (15:40 +0100)]
improves container selector grants check

... admin grants includes others

Change-Id: Iac9b8e4889365444cd2535b08f8d9fb607f09d49
Reviewed-on: http://gerrit.tine20.com/customers/2825
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011602: Database extensions not working for MySQL install: mysql with PHP7.0
Philipp Schüle [Thu, 25 Feb 2016 16:34:24 +0000 (17:34 +0100)]
0011602: Database extensions not working for MySQL install: mysql with PHP7.0

* only pdo_mysql is required now
* mysql module is deprecated since php5.5

https://forge.tine20.org/view.php?id=11602

Change-Id: I8b0f4d0a2d2f62a139d59a7b7a77f13be59cb096
Reviewed-on: http://gerrit.tine20.com/customers/2811
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodistro packaging has moved to separate repo
Philipp Schüle [Thu, 25 Feb 2016 11:13:53 +0000 (12:13 +0100)]
distro packaging has moved to separate repo

Change-Id: I1bf4fa6b99b74a4f364e007a2f0aa2c5e97355ef
Reviewed-on: http://gerrit.tine20.com/customers/2801
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agodisable randomly failing testInvoiceRecreation
Philipp Schüle [Wed, 24 Feb 2016 09:54:28 +0000 (10:54 +0100)]
disable randomly failing testInvoiceRecreation

Change-Id: I856a54df11ee71268657280f9d4629d5130b4c49
Reviewed-on: http://gerrit.tine20.com/customers/2793
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoprevent errors in renderer if keyfields are not available
Philipp Schüle [Tue, 23 Feb 2016 16:11:04 +0000 (17:11 +0100)]
prevent errors in renderer if keyfields are not available

Change-Id: I1aa903da60cbcad813e328756992c02977ca6ce7
Reviewed-on: http://gerrit.tine20.com/customers/2788
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agohandle additional LDAP user attributes
Philipp Schüle [Tue, 23 Feb 2016 07:52:05 +0000 (08:52 +0100)]
handle additional LDAP user attributes

* adds mailalternateaddress (qmail schema)
* moves additional attribs to a member var

Change-Id: I75be5ad264135a8f842a39346b3fbbae81248d83
Reviewed-on: http://gerrit.tine20.com/customers/2778
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoTinebase_User::syncUsers - catch all exceptions and continue syncing
Paul Mehrer [Wed, 17 Feb 2016 13:13:46 +0000 (14:13 +0100)]
Tinebase_User::syncUsers - catch all exceptions and continue syncing

not all exceptions were catched and the sync aboarted in case of an
uncatched exception.

now all exceptions are catched and only the sync of the user causing
the exception will be skiped, the sync will continue with the next user.

Change-Id: Ie885ce32178267141c76fd85b075e2ba93c26cf9
Reviewed-on: http://gerrit.tine20.com/customers/2737
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011508: Felamimail not creating correct SMTP settings
Cornelius Weiß [Tue, 16 Feb 2016 22:10:44 +0000 (23:10 +0100)]
0011508: Felamimail not creating correct SMTP settings

https://forge.tine20.org/view.php?id=11508

Change-Id: I5b64881490ab72421f7c488b17bd682f6f62af7f
Reviewed-on: http://gerrit.tine20.com/customers/2735
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoupdate to lates PHPWord lib
Cornelius Weiß [Thu, 21 Jan 2016 08:54:26 +0000 (09:54 +0100)]
update to lates PHPWord lib

* adopt to latest api
* add test for doc export

Change-Id: Ic09fb9a1741b5d9c4dbd950d4854b491c01fa751
Reviewed-on: http://gerrit.tine20.com/customers/2606
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
5 years ago0011614: add custom field filter to calendar
Philipp Schüle [Mon, 15 Feb 2016 17:45:20 +0000 (18:45 +0100)]
0011614: add custom field filter to calendar

Change-Id: I9754dad09fb4b8b4c75441dc1aedbc0a53770f1a
Reviewed-on: http://gerrit.tine20.com/customers/2720
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
5 years agoMerge branch '2014.11-develop' into 2015.11
Philipp Schüle [Mon, 15 Feb 2016 11:16:28 +0000 (12:16 +0100)]
Merge branch '2014.11-develop' into 2015.11

Conflicts:
tine20/Addressbook/js/ContactGrid.js

Change-Id: Icc36f634708854940beb29ff75a81e4e9b620d1e

5 years agoMerge branch '2014.11' into 2014.11-develop
Philipp Schüle [Mon, 15 Feb 2016 11:12:15 +0000 (12:12 +0100)]
Merge branch '2014.11' into 2014.11-develop

5 years agorender country names in adressbook grid
sstamer [Fri, 22 Jan 2016 15:02:53 +0000 (16:02 +0100)]
render country names in adressbook grid

Change-Id: I3cae6594cadd98a0602d735529b3f4d196577414
Reviewed-on: http://gerrit.tine20.com/customers/2612
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>