tine20
6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Mon, 10 Feb 2014 12:19:55 +0000 (13:19 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tine20/Tinebase/Setup/Update/Release7.php
tine20/Tinebase/Setup/setup.xml

6 years ago0009652: Own record filter duplicate entries
Alexander Stintzing [Mon, 10 Feb 2014 10:26:33 +0000 (11:26 +0100)]
0009652: Own record filter duplicate entries

Own record filter show each filter twice on modelconfig apps

https://forge.tine20.org/mantisbt/view.php?id=9652

Change-Id: I6a0d919dd3f1b8d4ec6f6033afcb99e3a1379c77
Reviewed-on: https://gerrit.tine20.org/tine20/2784
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009648: Create more DemoData
Alexander Stintzing [Thu, 6 Feb 2014 18:17:58 +0000 (19:17 +0100)]
0009648: Create more DemoData

 - Create some Sales.Products
 - Create more Crm.Leads

https://forge.tine20.org/mantisbt/view.php?id=9648

Change-Id: I9a48ab9e3df7c2518ed2c2f454ad083d79ab076a
Reviewed-on: https://gerrit.tine20.org/tine20/2782
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009638: xls exports always exports only 100 leads
Alexander Stintzing [Fri, 7 Feb 2014 14:18:25 +0000 (15:18 +0100)]
0009638: xls exports always exports only 100 leads

 - xls exports always exports only 100 leads
   (even if there are many more)

https://forge.tine20.org/mantisbt/view.php?id=9638

Change-Id: I9ff8d4a764300b5cfef92bba5d223fc292d62f62
Reviewed-on: http://gerrit.tine20.com/customers/324
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9644: remove user registration
Philipp Schüle [Fri, 7 Feb 2014 13:13:14 +0000 (14:13 +0100)]
#9644: remove user registration

- removes all registration tables and code

https://forge.tine20.org/mantisbt/view.php?id=9644

Change-Id: I45898b5a30de892c73f44044c148738a71520435
Reviewed-on: http://gerrit.tine20.com/customers/321
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009548: iCal: default attendee missing in exdates
Cornelius Weiß [Thu, 16 Jan 2014 06:38:01 +0000 (07:38 +0100)]
0009548: iCal: default attendee missing in exdates

recur exceptions created & first updated via iCal loose their default
attendee

- add test case
- repair c&p failure

Change-Id: Ia2c40ef66802a36d17ea5c5eb8aa5bf820e9a6b3
Reviewed-on: https://gerrit.tine20.org/tine20/2736
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009640: grid toolbar is missing in Roles, Groups and Tags modules
Alexander Stintzing [Thu, 6 Feb 2014 10:32:25 +0000 (11:32 +0100)]
0009640: grid toolbar is missing in Roles, Groups and Tags modules

Admin toolbar is missing for Roles, Groups and Tags modules
Works before Chrome Version 32.x

https://forge.tine20.org/mantisbt/view.php?id=9640

Change-Id: I444aa059661bf104559f7267669471c0b53136b0
Reviewed-on: https://gerrit.tine20.org/tine20/2779
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009632: adopt notification level for external attendee
Cornelius Weiß [Tue, 4 Feb 2014 17:45:12 +0000 (18:45 +0100)]
0009632: adopt notification level for external attendee

- use NOTIFICATION_LEVEL_EVENT_UPDATE for external attendee
- this skips status changes & alarm handling stuff

Change-Id: I267643a33049d5918ceac2150c42bb02a5873a5b
Reviewed-on: https://gerrit.tine20.org/tine20/2777
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agodon't use github api when composing from puppet
Cornelius Weiß [Tue, 4 Feb 2014 16:44:00 +0000 (17:44 +0100)]
don't use github api when composing from puppet

Change-Id: I16c7ea4c060036a25d3704bba24e43c41c7a50c4
Reviewed-on: https://gerrit.tine20.org/tine20/2776
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9628: can't remove attender from attendee filter (west panel)
Philipp Schüle [Mon, 3 Feb 2014 16:10:44 +0000 (17:10 +0100)]
#9628: can't remove attender from attendee filter (west panel)

- use matching select method of current selection model

https://forge.tine20.org/mantisbt/view.php?id=9628

Change-Id: I0f80cb22805f1896423136f614d2922a6bef44f0
Reviewed-on: https://gerrit.tine20.org/tine20/2775
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009592: Adding a new cost center to a employee fails
Alexander Stintzing [Fri, 31 Jan 2014 13:14:55 +0000 (14:14 +0100)]
0009592: Adding a new cost center to a employee fails

Adding a new cost center to a employee fails if there are vacations booked already
 - do not try update dependent records if they haven't changed

 - extends commit ea15381456727a77308c5afef6e298284c4fdb9d

https://forge.tine20.org/mantisbt/view.php?id=9592

Change-Id: I54329ed59f24d56e3384d1a35bae8478b769d79d
Reviewed-on: https://gerrit.tine20.org/tine20/2771
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agorefactor modssl authentication
Lars Kneschke [Mon, 13 Jan 2014 08:11:07 +0000 (09:11 +0100)]
refactor modssl authentication

- code refactoring
- make ModSSL selectable and configurable in authentication config UI

Change-Id: I0f050761d2f8dfa895103202b460316566d1b5e2
Reviewed-on: https://gerrit.tine20.org/tine20/2722
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Wed, 29 Jan 2014 15:40:07 +0000 (16:40 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tests/tine20/Crm/JsonTest.php
tine20/Crm/Model/Lead.php
tine20/Tinebase/Preference/Abstract.php

6 years ago#9606: preferences: forcing current default value is not working
Philipp Schüle [Wed, 29 Jan 2014 12:46:23 +0000 (13:46 +0100)]
#9606: preferences: forcing current default value is not working

- adds a test
- improves condition for saving admin preferences

https://forge.tine20.org/mantisbt/view.php?id=9606

Change-Id: I9f89649ea13903859a9d1a29ae11d7422279e9a3
Reviewed-on: http://gerrit.tine20.com/customers/302
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9602: CRM should cope with empty start of leads
Philipp Schüle [Wed, 29 Jan 2014 10:17:33 +0000 (11:17 +0100)]
#9602: CRM should cope with empty start of leads

- sanitizes empty start date coming via JSON frontend
- updates some TODOs

https://forge.tine20.org/mantisbt/view.php?id=9602

Change-Id: Ic551bb532688ee0347f2eddcf0a857823f7e115d
Reviewed-on: http://gerrit.tine20.com/customers/298
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009592: Adding a new cost center to a employee fails
Alexander Stintzing [Wed, 29 Jan 2014 14:01:13 +0000 (15:01 +0100)]
0009592: Adding a new cost center to a employee fails

Adding a new cost center to a employee fails if there are vacations
booked already

 - do not try update dependent records if they haven't changed

https://forge.tine20.org/mantisbt/view.php?id=9592

Change-Id: Ie7b8300eb812c076741b96ddbc55d115808ebdaa
Reviewed-on: https://gerrit.tine20.org/tine20/2766
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#9598: imip invitation mails show js error (in Felamimail)
Philipp Schüle [Wed, 29 Jan 2014 09:48:47 +0000 (10:48 +0100)]
#9598: imip invitation mails show js error (in Felamimail)

- convert VCALENDAR even if it contains only a recur exception
- adds fallbacks if certain values are empty

https://forge.tine20.org/mantisbt/view.php?id=9598

Change-Id: I7f864fb6de20bc2ff097ee1ef87e50926fbd3a12
Reviewed-on: https://gerrit.tine20.org/tine20/2763
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009588: InventoryItem-CostCenter filter fails
Alexander Stintzing [Mon, 27 Jan 2014 11:46:23 +0000 (12:46 +0100)]
0009588: InventoryItem-CostCenter filter fails

... without rights on Sales-App

InventoryItem-CostCenter filter fails if the user does not have rights
on the sales app

https://forge.tine20.org/mantisbt/bug_update_page.php?bug_id=9588

Change-Id: I3f99091d66cde49f04c1b4a0958e733170f2da25
Reviewed-on: https://gerrit.tine20.org/tine20/2760
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Tue, 28 Jan 2014 11:53:41 +0000 (12:53 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tine20/Tinebase/Helper.php

6 years agoFixes Tasks for CalDAV
Ingo Ratsdorf [Tue, 21 Jan 2014 13:55:50 +0000 (14:55 +0100)]
Fixes Tasks for CalDAV

- fixes typo in all day tasks
- add CATEGORIES reading via CalDAV
- removed old Sabre library reference

Change-Id: Ie8d53b65cca21c43908fffc6d92053bda9f0ff07
Reviewed-on: https://gerrit.tine20.org/tine20/2749
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoallows IMAP protocol request/response logging
Philipp Schüle [Tue, 21 Jan 2014 16:41:09 +0000 (17:41 +0100)]
allows IMAP protocol request/response logging

- and removes some obsolete code

Change-Id: I4a06b95a5bb35021928981e1a49e37ed3c04a7c1
Reviewed-on: https://gerrit.tine20.org/tine20/2752
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoremoves some record data from request
Philipp Schüle [Tue, 28 Jan 2014 11:34:34 +0000 (12:34 +0100)]
removes some record data from request

Change-Id: I5de57ddde2a41b60104c0d1ca96d5ac976cf000e
Reviewed-on: http://gerrit.tine20.com/customers/292
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago# 9566: allow to pass json arrays as config values via CLI
sstamer [Mon, 27 Jan 2014 15:45:28 +0000 (16:45 +0100)]
# 9566: allow to pass json arrays as config values via CLI

https://forge.tine20.org/mantisbt/view.php?id=9566

- decode string if Json
- don't double encode

Change-Id: I0f4939ff7684eca2816e9207a7cca0ff10d7b415
Reviewed-on: http://gerrit.tine20.com/customers/291
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009584: Sales Contract Container Grants are not editable
Alexander Stintzing [Fri, 24 Jan 2014 12:45:30 +0000 (13:45 +0100)]
0009584: Sales Contract Container Grants are not editable

the context menu at the tree node of sales-contract does not work anymore.

 - fix edit sales-contract default container context menu in treepanel
 - also prevent modelconfig to need any default data

https://forge.tine20.org/mantisbt/view.php?id=9584

Change-Id: Ie60f511c181c158f45c2f3d82d2a7c38641e07c2
Reviewed-on: https://gerrit.tine20.org/tine20/2759
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0009574: vacation or sickness days can't be booked on the last working day
Alexander Stintzing [Thu, 23 Jan 2014 13:43:07 +0000 (14:43 +0100)]
0009574: vacation or sickness days can't be booked on the last working day

when the contract ends at the 12.x.x, a vacation or sickness day can't be
booked on the 12. If a contract begins at the 15.x.x a vacation day can
be booked on the 11th.

https://forge.tine20.org/mantisbt/view.php?id=9574

Change-Id: I80e45d4091ce0bf10c6c527ae4cbcbc66e807aba
Reviewed-on: https://gerrit.tine20.org/tine20/2756
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agoadds a log statement and improves formatting
Philipp Schüle [Wed, 22 Jan 2014 14:18:29 +0000 (15:18 +0100)]
adds a log statement and improves formatting

Change-Id: I6004b988cb4d9f448f815e2157aaf184d4896a84
Reviewed-on: https://gerrit.tine20.org/tine20/2754
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago0005418: disallow event "cleanup" in the past
Cornelius Weiß [Tue, 21 Jan 2014 08:47:15 +0000 (09:47 +0100)]
0005418: disallow event "cleanup" in the past

- deny deletes for events older than 2 month

Change-Id: I90e7a044e4b4be4bcf70d3dc576517d14e27da21
Reviewed-on: https://gerrit.tine20.org/tine20/2747
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agomodelconfig handles modlog-seq
Alexander Stintzing [Tue, 21 Jan 2014 15:05:36 +0000 (16:05 +0100)]
modelconfig handles modlog-seq

Change-Id: I915fcd9872ffef884a550c79f652ed94b4d2d2b3
Reviewed-on: https://gerrit.tine20.org/tine20/2751
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years agohave puppet generated config in seperate config dir
Cornelius Weiß [Tue, 21 Jan 2014 09:12:38 +0000 (10:12 +0100)]
have puppet generated config in seperate config dir

- don't overwrite existing once
- allow multi domain

Change-Id: I4c7eac69a34b08429ba0566bdf2eff9ac8bb7bd5
Reviewed-on: https://gerrit.tine20.org/tine20/2748
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
6 years ago#6752: ci ldap tests
Philipp Schüle [Tue, 21 Jan 2014 09:06:40 +0000 (10:06 +0100)]
#6752: ci ldap tests

- makes some tests more robust (check if groups exist, use current users
email instead of unittest@tine20.org, ...)

https://forge.tine20.org/mantisbt/view.php?id=6752

Change-Id: I15eb9a71274c42879ce8a6c254c86a519da08e3c
Reviewed-on: https://gerrit.tine20.org/tine20/2745
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Thu, 16 Jan 2014 20:57:01 +0000 (21:57 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tine20/Addressbook/js/ContactEditDialog.js

7 years agoimproved logging when moving records
Philipp Schüle [Thu, 16 Jan 2014 14:41:40 +0000 (15:41 +0100)]
improved logging when moving records

Change-Id: Id4b0ec41245cca77da3892c2cf3e87fa82fcd828
Reviewed-on: https://gerrit.tine20.org/tine20/2741
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9552: improve grid update behavior
Philipp Schüle [Thu, 16 Jan 2014 14:10:23 +0000 (15:10 +0100)]
#9552: improve grid update behavior

- removes grid reload on flag change
- only shows new message notification if count changed

https://forge.tine20.org/mantisbt/view.php?id=9552

Change-Id: I5c94402632db47d80d8e009bc679c8f1f2b8ce59
Reviewed-on: https://gerrit.tine20.org/tine20/2738
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9418: copied contact is always added to selected container
Philipp Schüle [Thu, 16 Jan 2014 14:01:50 +0000 (15:01 +0100)]
#9418: copied contact is always added to selected container

- removes special container handling in contact edit dialog that
prevented the resolved container from duplicate panel to be used when
saving

https://forge.tine20.org/mantisbt/view.php?id=9418

Change-Id: I050d7a02a6c64e3c30b194e8efe0ec078bc8fceb
Reviewed-on: http://gerrit.tine20.com/customers/281
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoadd tine.vagrant vhost config
Cornelius Weiß [Wed, 15 Jan 2014 18:04:20 +0000 (19:04 +0100)]
add tine.vagrant vhost config

- tests for iCal need propper vhost config
- be able to have more than one version on one vagrant machine

Change-Id: I562080dfa4f2adabe1d8901855e1612d4e10285f
Reviewed-on: https://gerrit.tine20.org/tine20/2735
Reviewed-by: Cornelius Weiß <c.weiss@metaways.de>
Tested-by: Cornelius Weiß <c.weiss@metaways.de>
7 years agobumps version to 2013.10.4
Philipp Schüle [Wed, 15 Jan 2014 17:43:47 +0000 (18:43 +0100)]
bumps version to 2013.10.4

7 years ago0009502: New unexcused sickness days aren't bookable as vacation days
Alexander Stintzing [Thu, 9 Jan 2014 14:30:24 +0000 (15:30 +0100)]
0009502: New unexcused sickness days aren't bookable as vacation days

When creating unexcused sickness days and trying to book
them as vacation days in one step, the panel breaks.

https://forge.tine20.org/mantisbt/view.php?id=9502

Change-Id: Id3c19d6a3128b33fad9bf876037cbd23d2114210
Reviewed-on: https://gerrit.tine20.org/tine20/2706
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009528: fix concurrency handling in CalDAV Frontend
Cornelius Weiß [Wed, 15 Jan 2014 17:06:01 +0000 (18:06 +0100)]
0009528: fix concurrency handling in CalDAV Frontend

- sequence based eTag
- removes exdate+attendee+timestamp based handling

https://forge.tine20.org/mantisbt/view.php?id=9528

Change-Id: I7073ffcf5edb99e4ff5608ff1cdfc9b5086e43d2
Reviewed-on: https://gerrit.tine20.org/tine20/2724
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9314: validation error is not cleared, no saving possible
Philipp Schüle [Wed, 15 Jan 2014 14:41:32 +0000 (15:41 +0100)]
#9314: validation error is not cleared, no saving possible

- sets this.saving flag to false after validation error

https://forge.tine20.org/mantisbt/view.php?id=9314

Change-Id: I202b98551e462629d33733c2146e285382b52a2c
Reviewed-on: https://gerrit.tine20.org/tine20/2733
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9348: don't show zero counts in edit dialog
Philipp Schüle [Wed, 15 Jan 2014 15:16:00 +0000 (16:16 +0100)]
#9348: don't show zero counts in edit dialog

- shows counts according to the styleguide
- fixes tags count for new records

https://forge.tine20.org/mantisbt/view.php?id=9348

Change-Id: I47ce30f7a2ae1ef0d7e462a53a955207026920d7
Reviewed-on: https://gerrit.tine20.org/tine20/2734
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009528: fix concurrency handling in CalDAV Frontend
Cornelius Weiß [Wed, 15 Jan 2014 13:42:21 +0000 (14:42 +0100)]
0009528: fix concurrency handling in CalDAV Frontend

- start sequence with 1 like the clients do
- take modlog properties from existing records
  when updateing from xDAV cause concurrency
  is prevented by etags

https://forge.tine20.org/mantisbt/view.php?id=9528

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c7a
Reviewed-on: https://gerrit.tine20.org/tine20/2718
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009520: update transifex strings and translations
Philipp Schüle [Wed, 15 Jan 2014 14:35:14 +0000 (15:35 +0100)]
0009520: update transifex strings and translations

7 years ago0009520: update transifex strings and translations
Philipp Schüle [Wed, 15 Jan 2014 13:58:26 +0000 (14:58 +0100)]
0009520: update transifex strings and translations

7 years ago#9510: is it allowed to have no main vevent in ics?
Philipp Schüle [Wed, 15 Jan 2014 11:02:47 +0000 (12:02 +0100)]
#9510: is it allowed to have no main vevent in ics?

- answer: yes! see test testAcceptInvitationForRecurringEventException
- removes exception in converter that was thrown when main vevent was
missing

https://forge.tine20.org/mantisbt/view.php?id=9510

Change-Id: I886ab5438a2d0ea413c6b453a3183f3405d65f62
Reviewed-on: https://gerrit.tine20.org/tine20/2727
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9412: event loses saved relations on reload
Philipp Schüle [Wed, 15 Jan 2014 11:14:37 +0000 (12:14 +0100)]
#9412: event loses saved relations on reload

- removes relations panel from event edit dialog
- adds debug log to relations panel init fn

https://forge.tine20.org/mantisbt/view.php?id=9412

Change-Id: I6f4130cbd5989b10ba2c9b15f93c7f3851a72bc3
Reviewed-on: https://gerrit.tine20.org/tine20/2728
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoadd alarm demo data for em-client
Cornelius Weiß [Mon, 6 Jan 2014 13:58:13 +0000 (14:58 +0100)]
add alarm demo data for em-client

- add basic tests
- demodata thanks to tomp at topanet dot de

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c7f
Reviewed-on: https://gerrit.tine20.org/tine20/2697
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoremove ununsed filter
Cornelius Weiß [Tue, 14 Jan 2014 18:24:07 +0000 (19:24 +0100)]
remove ununsed filter

Change-Id: I8a02c8b4b76c83ddba2926a42f9abc4e1646d91b
Reviewed-on: https://gerrit.tine20.org/tine20/2725
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoencode folder name when calling appendMessage()
Philipp Schüle [Sun, 12 Jan 2014 16:10:58 +0000 (17:10 +0100)]
encode folder name when calling appendMessage()

see https://www.tine20.org/forum/viewtopic.php?f=12&t=15718

Change-Id: Iefaae248e901df4acb8b1a3ad48efa6cd7177fa7
Reviewed-on: https://gerrit.tine20.org/tine20/2715
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agodon't use github api for composer
Cornelius Weiß [Tue, 14 Jan 2014 11:33:49 +0000 (12:33 +0100)]
don't use github api for composer

circumvent github access limits

Change-Id: I7073ffcf5edb99e4ff5608ff1cdfc9b5086e43ef
Reviewed-on: https://gerrit.tine20.org/tine20/2723
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoupdate to latest puphpet version
Cornelius Weiß [Mon, 13 Jan 2014 14:08:29 +0000 (15:08 +0100)]
update to latest puphpet version

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c9f
Reviewed-on: https://gerrit.tine20.org/tine20/2720
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Cornelius Weiß <c.weiss@metaways.de>
Tested-by: Cornelius Weiß <c.weiss@metaways.de>
7 years ago0009530: Firefox does not show tags and notes count in edit dialog
Alexander Stintzing [Mon, 13 Jan 2014 10:57:10 +0000 (11:57 +0100)]
0009530: Firefox does not show tags and notes count in edit dialog

Firefox does not show tags and notes count in edit dialog

https://forge.tine20.org/mantisbt/view.php?id=9530

Change-Id: I7073ffcf5edb99e4ff5608ff1cdfc9b5086e43cf
Reviewed-on: https://gerrit.tine20.org/tine20/2719
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9524: save ack and snooze in alarm
Cornelius Weiß [Mon, 13 Jan 2014 09:58:05 +0000 (10:58 +0100)]
#9524: save ack and snooze in alarm

- save ack & snooze as option in alarm
- allow all users to save ack & snooze
- migrate old ack/snooze settings from attendee to alarms

https://forge.tine20.org/mantisbt/view.php?id=9524

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c8f
Reviewed-on: https://gerrit.tine20.org/tine20/2698
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9480: missing translation for 'Datei'
Philipp Schüle [Mon, 13 Jan 2014 09:30:56 +0000 (10:30 +0100)]
#9480: missing translation for 'Datei'

- fixed file upload / attachment grid i18n file string handling

https://forge.tine20.org/mantisbt/view.php?id=9480

Change-Id: I4154e66f7136698580104224ca6b62dd8e0225a7
Reviewed-on: https://gerrit.tine20.org/tine20/2717
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agohandle empty exception data
Philipp Schüle [Mon, 13 Jan 2014 09:04:05 +0000 (10:04 +0100)]
handle empty exception data

Change-Id: I725b7ef456d4d0702c4d15f10a7b0e12fc2001f5
Reviewed-on: https://gerrit.tine20.org/tine20/2716
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoadded some logging when trying to delete customfield
Philipp Schüle [Sat, 11 Jan 2014 18:16:29 +0000 (19:16 +0100)]
added some logging when trying to delete customfield

Change-Id: Idbce8cdf057f9165d27f301adcd59f8b940e3dad
Reviewed-on: https://gerrit.tine20.org/tine20/2714
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9522: update htmlpurifier to 4.6.0
Philipp Schüle [Fri, 10 Jan 2014 16:20:21 +0000 (17:20 +0100)]
#9522: update htmlpurifier to 4.6.0

- composer update ezyang/htmlpurifier

https://forge.tine20.org/mantisbt/view.php?id=9522

Change-Id: I5c410300b581b6828506c96d890d179663beb340
Reviewed-on: https://gerrit.tine20.org/tine20/2711
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago# 9440: IP in logfile
Lars Kneschke [Fri, 10 Jan 2014 16:13:23 +0000 (17:13 +0100)]
# 9440: IP in logfile

https://forge.tine20.org/mantisbt/view.php?id=9440

Change-Id: I677edbe8ec92ca7ea0ff3f9c4ef5cca756cb427d
Reviewed-on: https://gerrit.tine20.org/tine20/2712
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Fri, 10 Jan 2014 16:03:11 +0000 (17:03 +0100)]
Merge branch '2013.03' into 2013.10

7 years agoimproved sikuli test case (login/logout)
Philipp Schüle [Fri, 10 Jan 2014 13:32:13 +0000 (14:32 +0100)]
improved sikuli test case (login/logout)

- uses Chromium class for simple browser management
- adds logout
- imports unittest
- uses testsuite

Change-Id: I3db9395b54ab3ef9201463048ba31ec38fdc4983
Reviewed-on: https://gerrit.tine20.org/tine20/2710
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#3730: support CONDSTORE extension for quick flag sync
Emerson Faria Nobre [Fri, 10 Jan 2014 13:30:46 +0000 (14:30 +0100)]
#3730: support CONDSTORE extension for quick flag sync

- Expresso#7182
- adds new modseq and support_condstore field to folder record
- always check flags change if condstore is supported on cache update
- client now reloads the grid if flags have changed

https://forge.tine20.org/mantisbt/view.php?id=3730

Change-Id: Icf7840fe73ce29bb4ba0fd1fa2e8dd39310553eb
Reviewed-on: https://gerrit.tine20.org/tine20/2647
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#4169: reduce memory consumption when sending message
Philipp Schüle [Fri, 10 Jan 2014 14:32:16 +0000 (15:32 +0100)]
#4169: reduce memory consumption when sending message

- allow to configure logging in Zend_Mail_Protocol_Abstract
- disabled logging in Zend_Mail_Protocol by default
- enable logging in one test for checking smtp log

https://forge.tine20.org/mantisbt/view.php?id=4169

Change-Id: Ib2b709ab53a696de176a4ae3211370e4e5d08b3a
Reviewed-on: http://gerrit.tine20.com/customers/261
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Fri, 10 Jan 2014 14:03:05 +0000 (15:03 +0100)]
Merge branch '2013.03' into 2013.10

7 years ago0009496: HR Account calculates wrong working hours
Alexander Stintzing [Thu, 9 Jan 2014 12:49:48 +0000 (13:49 +0100)]
0009496: HR Account calculates wrong working hours

- HR Account calculates wrong working hours.
- shows real working days/hours (minus sickness/vacation)

https://forge.tine20.org/mantisbt/view.php?id=9496

Change-Id: Iaa4f5d1dfabb4d9c2f5b2e3a727de42565c9da8d
Reviewed-on: https://gerrit.tine20.org/tine20/2705
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9500 add note buttons missing in edit dialog
sstamer [Fri, 10 Jan 2014 09:36:39 +0000 (10:36 +0100)]
#9500 add note buttons missing in edit dialog

- add note buttons missing in edit dialog

Change-Id: I5efcc040fc992a7daaa90b35ada02f53b1e4c8ab
Reviewed-on: https://gerrit.tine20.org/tine20/2709
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#8230: added alarm to event on iOS 6.1 -> description removed
Philipp Schüle [Thu, 9 Jan 2014 20:58:00 +0000 (21:58 +0100)]
#8230: added alarm to event on iOS 6.1 -> description removed

- do not remove event description if missing from AS xml request (only
when device is an iPhone)
- this is only a quick fix for the problem. we should implemented
"ghosted properties" as suggested in the mantis task

https://forge.tine20.org/mantisbt/view.php?id=8230

Change-Id: Iaeb1c7e693aa909bcf7258b533cf34980a807450
Reviewed-on: https://gerrit.tine20.org/tine20/2707
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9512: preserve windowNameConnection files in package
Philipp Schüle [Thu, 9 Jan 2014 20:08:53 +0000 (21:08 +0100)]
#9512: preserve windowNameConnection files in package

https://forge.tine20.org/mantisbt/view.php?id=9512

Change-Id: Idbcd4c60607516d60564d6a9a1abcc681cfab4e9
Reviewed-on: http://gerrit.tine20.com/customers/276
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9510: is it allowed to have no main vevent in ics?
Philipp Schüle [Thu, 9 Jan 2014 19:55:26 +0000 (20:55 +0100)]
#9510: is it allowed to have no main vevent in ics?

- disables test and adds some comments

https://forge.tine20.org/mantisbt/view.php?id=9510

7 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Thu, 9 Jan 2014 19:41:43 +0000 (20:41 +0100)]
Merge branch '2013.03' into 2013.10

7 years agoinitialize $baseVevent variable
Philipp Schüle [Thu, 9 Jan 2014 19:41:05 +0000 (20:41 +0100)]
initialize $baseVevent variable

7 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Thu, 9 Jan 2014 14:20:41 +0000 (15:20 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tests/tine20/Calendar/Controller/MSEventFacadeTest.php
tests/tine20/Calendar/TestCase.php
tine20/Calendar/Controller/MSEventFacade.php
tine20/Calendar/Convert/Event/VCalendar/Abstract.php
tine20/Tinebase/ActionQueue.php
tine20/Tinebase/js/widgets/form/RecordPickerComboBox.js

7 years ago#9396: alarm_ack_time and alarm_snooze_time are not updated
Philipp Schüle [Wed, 8 Jan 2014 17:15:08 +0000 (18:15 +0100)]
#9396: alarm_ack_time and alarm_snooze_time are not updated

- adds tests for mseventfacade and vcalendar converter
- moz ack+snooze properties need to be passed to exdates (converter)
- some minor improvements

https://forge.tine20.org/mantisbt/view.php?id=9396

Change-Id: Ic37f4a94acab6f437ee80f452ab498711513f147
Reviewed-on: http://gerrit.tine20.com/customers/234
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9498: improve sorting of contacts in attendee picker grid
Philipp Schüle [Thu, 9 Jan 2014 13:47:24 +0000 (14:47 +0100)]
#9498: improve sorting of contacts in attendee picker grid

improves attendee picker combo sorting:
- sort contacts by type (users first)
- sort groups/resources by name

introduces sortDir config in RecordPickerComboBox

https://forge.tine20.org/mantisbt/view.php?id=9498

Change-Id: Ifa5cca4722d5df3b06ba3167ef1cae3e542203b8
Reviewed-on: http://gerrit.tine20.com/customers/274
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agofixed wrong message/action param handling
Philipp Schüle [Thu, 4 Jul 2013 15:00:03 +0000 (17:00 +0200)]
fixed wrong message/action param handling

7 years agofix failing test HRFrontend_Json::testCalculation
Alexander Stintzing [Thu, 9 Jan 2014 11:45:04 +0000 (12:45 +0100)]
fix failing test HRFrontend_Json::testCalculation

... after year change

Change-Id: I103f0c48228ae0cf6da5b6f2c42d96f4ebdeb9d4
Reviewed-on: https://gerrit.tine20.org/tine20/2704
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009494: improve count sql query
Lars Kneschke [Thu, 9 Jan 2014 09:43:00 +0000 (10:43 +0100)]
0009494: improve count sql query

- completes commit 62f508e0cef90e0519a6c2cf497b55c2bced8951
- removes obsolete useSubselectForCount and preserve options
- adds timesheet totalsum(billable) test

https://forge.tine20.org/mantisbt/view.php?id=9494

Change-Id: I98ae309ec8b6c003b00db72b4f63c0176606872a
Reviewed-on: https://gerrit.tine20.org/tine20/2703
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agotemporarly disabled testCalculation
Philipp Schüle [Thu, 9 Jan 2014 11:05:16 +0000 (12:05 +0100)]
temporarly disabled testCalculation

7 years agoadd missing duration filter and fix format of search filter
Lars Kneschke [Wed, 8 Jan 2014 21:16:41 +0000 (22:16 +0100)]
add missing duration filter and fix format of search filter

- the duration(not defined) and account_id(wrong syntax) filter got
ignored during the test

Change-Id: Ia74a2c7d5ec610424efecfe5adbf066e6171d422
Reviewed-on: https://gerrit.tine20.org/tine20/2702
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
7 years ago0009262: Import Calender fails
Philipp Schüle [Mon, 18 Nov 2013 10:19:06 +0000 (11:19 +0100)]
0009262: Import Calender fails

- log ics parse errors during import

https://forge.tine20.org/mantisbt/view.php?id=9262

Change-Id: Id7a22dfef861e4506460d3e5915cea4ae5f27385
Reviewed-on: https://gerrit.tine20.org/tine20/2555
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009476: Datepicker switches to january on changing the year
Alexander Stintzing [Tue, 7 Jan 2014 16:16:24 +0000 (17:16 +0100)]
0009476: Datepicker switches to january on changing the year

When browsing the calendar nested into the freetime edit dialog,
the calendar always switches to january on year change.

https://forge.tine20.org/mantisbt/view.php?id=9476

Change-Id: I01c75f4ee8aa8b122f91471cea952cdffc7baa4b
Reviewed-on: https://gerrit.tine20.org/tine20/2701
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoAllows CardDAV clients to submit company addresses only
Ingo Ratsdorf [Tue, 7 Jan 2014 08:20:44 +0000 (21:20 +1300)]
Allows CardDAV clients to submit company addresses only

- Tine20 allows company addresses to be saved without first or last name
attached to it. This will fix CardDAV support for this feature

Change-Id: Ieb6af0d9fc89e896db3bccf098870d97521094e8
Reviewed-on: https://gerrit.tine20.org/tine20/2700
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009486: Month filter "date after" fails
Alexander Stintzing [Mon, 6 Jan 2014 16:18:35 +0000 (17:18 +0100)]
0009486: Month filter "date after" fails

When searching after the last day of a month,
the month itself is shown also, but shouldn't.

https://forge.tine20.org/mantisbt/view.php?id=9486

Change-Id: Ib90257a6d9e36a470122ec0998df4dd6b716f186
Reviewed-on: https://gerrit.tine20.org/tine20/2699
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#6752: ci ldap tests
Philipp Schüle [Mon, 6 Jan 2014 15:22:01 +0000 (16:22 +0100)]
#6752: ci ldap tests

- fixed / updated some tests to make them capable of handling different
test user names, ldap ids and so on
- removed some obsolete code
- moved some more code to generic TestCase

https://forge.tine20.org/mantisbt/view.php?id=6752

Change-Id: I333b6fa044abd232e7294a8eca14247278d01645
Reviewed-on: https://gerrit.tine20.org/tine20/2690
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009470: Alarms from Mavericks (OSX 10.9) are not saved
Cornelius Weiß [Fri, 3 Jan 2014 12:35:46 +0000 (13:35 +0100)]
0009470: Alarms from Mavericks (OSX 10.9) are not saved

- Support TRIGGER:-PT15M
=> DURATION without VALUE parameter

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c6f
Reviewed-on: https://gerrit.tine20.org/tine20/2692
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009476: Datepicker switches to january on changing the year
Alexander Stintzing [Fri, 3 Jan 2014 13:34:23 +0000 (14:34 +0100)]
0009476: Datepicker switches to january on changing the year

When browsing the calendar nested into the freetime edit dialog,
the calendar always switches to january on year change.

requires: 0009472: Editing vacation days from last year fails

https://forge.tine20.org/mantisbt/view.php?id=9476

Change-Id: I66fb7daa5515699fc02a70c0fd2bb21028070477
Reviewed-on: https://gerrit.tine20.org/tine20/2695
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009472: Editing vacation days from last year fails
Alexander Stintzing [Fri, 3 Jan 2014 12:36:33 +0000 (13:36 +0100)]
0009472: Editing vacation days from last year fails

Editing vacation days from last year fails. On opening
the message "Year can not be changed" is shown

https://forge.tine20.org/mantisbt/view.php?id=9472

Change-Id: If4e3b4d20adb66698ed0d4c0261829b0aa2926d3
Reviewed-on: https://gerrit.tine20.org/tine20/2693
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009474: Extra vacation grid does not sort
Alexander Stintzing [Fri, 3 Jan 2014 12:54:48 +0000 (13:54 +0100)]
0009474: Extra vacation grid does not sort

Extra vacation grid does not sort but shows
"Method not found" message - should sort locally

https://forge.tine20.org/mantisbt/view.php?id=9474

Change-Id: I07753affc550943ed1ab621c58664dd5a7d5bcb5
Reviewed-on: https://gerrit.tine20.org/tine20/2694
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agofix HR tests
Lars Kneschke [Thu, 2 Jan 2014 19:05:35 +0000 (20:05 +0100)]
fix HR tests

- use current year for filter
- don't read contact, as all information are stored in account already

Change-Id: I279a9097c1b15086bc8d6e93444144d3523a3451
Reviewed-on: https://gerrit.tine20.org/tine20/2691
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>
7 years agoMerge branch '2013.03' into 2013.10
Philipp Schüle [Fri, 27 Dec 2013 19:40:36 +0000 (20:40 +0100)]
Merge branch '2013.03' into 2013.10

Conflicts:
tests/tine20/Calendar/RruleTests.php

7 years ago#9462: endless loop in Calendar_Controller_Event::adoptAlarmTime
Philipp Schüle [Fri, 27 Dec 2013 12:07:22 +0000 (13:07 +0100)]
#9462: endless loop in Calendar_Controller_Event::adoptAlarmTime

- adds test case
- adoptAlarmTime by instance // calculate from in usertime
  as otherwise time shifts due to DST changes may lead
  to wrong results

https://forge.tine20.org/mantisbt/view.php?id=9462

Change-Id: I689412dac2ecddbb31ef443a28ca5d239ca88c5f
Reviewed-on: http://gerrit.tine20.com/customers/259
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9458: allow to configure number of alarms
Philipp Schüle [Fri, 27 Dec 2013 14:33:14 +0000 (15:33 +0100)]
#9458: allow to configure number of alarms

- default is 100 alarm notifications for earch run of
sendPendingAlarms

https://forge.tine20.org/mantisbt/view.php?id=9458

Change-Id: Ia425e948c69755695e57f3087e54aa768e1e74a1
Reviewed-on: http://gerrit.tine20.com/customers/257
Tested-by: Jenkins CI (http://ci.tine20.com/)
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9464: user grid does not refresh after ctx menu action
Philipp Schüle [Fri, 27 Dec 2013 14:12:42 +0000 (15:12 +0100)]
#9464: user grid does not refresh after ctx menu action

- as Users have no modlog yet, we have to make sure that the grid is
updated correctly after a record has changed

https://forge.tine20.org/mantisbt/view.php?id=9464

Change-Id: Ia3594409b856d417e2f4f1979f75afcb1d0a9ce1
Reviewed-on: http://gerrit.tine20.com/customers/260
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago0009320: Wrong notification on first occurrence exceptions
Cornelius Weiß [Fri, 27 Dec 2013 12:38:15 +0000 (13:38 +0100)]
0009320: Wrong notification on first occurrence exceptions

- ensure [start,end[ definition of getNextOccurence for baseEvents
  for WEEKLY events with BTDAY definition

Reviewed-on: https://gerrit.tine20.org/tine20/2648
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Conflicts:
tests/tine20/Calendar/Controller/EventTests.php
tests/tine20/Calendar/Export/ICalTest.php
tests/tine20/Calendar/RruleTests.php
tine20/Calendar/Model/Rrule.php

Change-Id: I74ab79c21a170db219caf6355838409df3c29caa
Reviewed-on: http://gerrit.tine20.com/customers/258
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agouse configured email addresses to avoid tests failing because of SMTP
Lars Kneschke [Thu, 26 Dec 2013 09:02:56 +0000 (10:02 +0100)]
use configured email addresses to avoid tests failing because of SMTP
errors

Change-Id: I0c417f000ed2891162b0738a6e286e14d5c98011
Reviewed-on: https://gerrit.tine20.org/tine20/2688
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#9450: allow to delete container without the required grants
Philipp Schüle [Mon, 23 Dec 2013 17:11:27 +0000 (18:11 +0100)]
#9450: allow to delete container without the required grants

https://forge.tine20.org/mantisbt/view.php?id=9450

Change-Id: I1991272886de6d1e2e9369250fd110ab770063b5
Reviewed-on: https://gerrit.tine20.org/tine20/2684
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: Philipp Schüle <p.schuele@metaways.de>
7 years agooptimize Tinebase_Record_Abstract::_hasToArray
Paul Mehrer [Sun, 22 Dec 2013 14:20:07 +0000 (15:20 +0100)]
optimize Tinebase_Record_Abstract::_hasToArray

as most properties are no objects, the old logic called is_object twice, it just stacks over time! Also a call to in_array AND class_implements is slower than just one call to method_exists.

For showing a list of 50 addressbook entries this saves around 50-60ms while xhprof being turned on on my local machine

Change-Id: I675b342c02c101ce0eb4cec9f2fe080f10ab05fa
Reviewed-on: https://gerrit.tine20.org/tine20/2677
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agooptimizing Tinebase_Record_Abstract::_convertDateTimeToString
Paul Mehrer [Sun, 22 Dec 2013 16:17:59 +0000 (17:17 +0100)]
optimizing Tinebase_Record_Abstract::_convertDateTimeToString

$value often evalutes to false, by rearranging the if statements calls to instanceof and is_array can be skipped for $value == false

Change-Id: I419b0d1dc79467b940163691e3616398d1faed4d
Reviewed-on: https://gerrit.tine20.org/tine20/2678
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agooptimizing Tinebase_Record_Abstract::setTimezone
Paul Mehrer [Sun, 22 Dec 2013 18:25:02 +0000 (19:25 +0100)]
optimizing Tinebase_Record_Abstract::setTimezone

iterates over all properties and checks for is_object. Amount of is_object calls can be reduced by first evaluating for true. Approx. halfs the is_object calls.

Change-Id: I78219b3395d7107d1f53602dfa3e2447fc1b9dc5
Reviewed-on: https://gerrit.tine20.org/tine20/2679
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoTinebase_Core::getLogLevel
Paul Mehrer [Sun, 22 Dec 2013 18:44:20 +0000 (19:44 +0100)]
Tinebase_Core::getLogLevel

self::get was called twice without sense. Now its being called only once. This can be up to 150 calls for Addressbook.searchContacts for example, easily an other 5ms.

Change-Id: Id6d8f4af77a3c2f48d57bc4841be639b8c08e73d
Reviewed-on: https://gerrit.tine20.org/tine20/2680
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years ago#7686: show container name in contact grid
Philipp Schüle [Fri, 20 Dec 2013 19:47:43 +0000 (20:47 +0100)]
#7686: show container name in contact grid

- adds container renderer to Addressbook

https://forge.tine20.org/mantisbt/view.php?id=7686

Change-Id: I987c59a0f71831051b4db8d61d5ba7b3e15e7e01
Reviewed-on: https://gerrit.tine20.org/tine20/2676
Tested-by: Philipp Schüle <p.schuele@metaways.de>
Tested-by: jenkins user
Reviewed-by: Philipp Schüle <p.schuele@metaways.de>
7 years agoimprove count sql query
Lars Kneschke [Fri, 20 Dec 2013 13:08:47 +0000 (14:08 +0100)]
improve count sql query

Change-Id: I100f6178d6f57d6dd70c83e702d2625326a5f258
Reviewed-on: https://gerrit.tine20.org/tine20/2675
Tested-by: jenkins user
Reviewed-by: Lars Kneschke <l.kneschke@metaways.de>